SilverStripe\StaticPublishQueue\Service\URLSanitisationService

Complexity

Total Complexity

8

Size/Duplication

Total Lines	80
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	addURLs()	0	4	2
A	getURLs()	0	7	2
A	getForceSSL()	0	3	1
A	addURL()	0	23	3

<?php

namespace SilverStripe\StaticPublishQueue\Service;

use SilverStripe\Core\Config\Configurable;
use SilverStripe\Core\Environment;

/**
 * Class URLSanitisationService
 * Provides an abstraction for populating and generating a list of
 * URLs to be cached by StaticPublishQueue.
 *
 * @package SilverStripe\StaticPublishQueue\Service
 */
class URLSanitisationService
{
    use Configurable;

    /**
     * Enable to force all URLs to be changed to https
     *
     * @var bool
     * @config
     */
    private static $force_ssl = false;

The private property $force_ssl is not used, and could be removed.

    /**
     * @var array
     */
    private $urls = [];

    /**
     * @var int
     */
    private $pointer = 0;

    /**
     * @param string $url
     */
    public function addURL(string $url): void
    {
        // We never want to have stage=Stage present in our cached URLs. This will safely remove "stage" params, but
        // keep any others. It doesn't matter where in the string "stage=" exists.
        $url = preg_replace('/([?&])stage=[^&]+(&|$)/', '$1', $url);
        // Trim any trailing "?" or "&".
        $url = $string = rtrim($url, '&');

The assignment to $string is dead and can be removed.

        $url = $string = rtrim($url, '?');

        // Force SSL publishing as CLI will default to http
        $forceSSL = $this->getForceSSL();
        if ($forceSSL) {
            $url = str_replace('http://', 'https://', $url);
        }

        // Check if this URL is already represented.
        if (array_key_exists($url, $this->urls)) {
            // Don't need to add it again if it is.
            return;
        }

        $this->urls[$url] = $this->pointer;
        $this->pointer += 1;
    }

    /**
     * @param array $urls
     */
    public function addURLs(array $urls): void
    {
        foreach ($urls as $url) {
            $this->addURL($url);
        }
    }

    /**
     * @return array
     */
    public function getURLs($formatted = true): array
    {
        if (!$formatted) {
            return array_keys($this->urls);
        }

        return $this->urls;
    }

    /**
     * Override this function if runtime change is needed (CMS setting or Environment variable)
     *
     * @return bool
     */
    protected function getForceSSL()
    {
        return (bool) $this->config()->get('force_ssl');
    }
}