StaticPublishingTriggerPage::objectsToDelete() - Code Metrics - Inspection of "SS4 Compatability" - silverstripe/silverstripe-staticpublishqueue - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#70)

by Andrew

created 2018-01-16 16:46 UTC

StaticPublishingTriggerPage::objectsToDelete() A

↳ Parent: StaticPublishingTriggerPage

Complexity

Conditions	3
Paths	3

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	3
eloc	5
nc	3
nop	1
dl	0
loc	7
rs	9.4285
c	2
b	0
f	0

<?php

namespace SilverStripe\StaticPublishQueue\Test\SiteTreePublishingEngineTest\Model;

use SilverStripe\CMS\Model\SiteTree;
use SilverStripe\Dev\TestOnly;
use SilverStripe\ORM\ArrayList;
use SilverStripe\StaticPublishQueue\Contract\StaticPublishingTrigger;

class StaticPublishingTriggerPage extends SiteTree implements TestOnly, StaticPublishingTrigger
{
    private static $table_name = 'SPQ_StaticPublishingTriggerPage';


    public function generatePublishable($url, $prio)
    {
        $obj = StaticallyPublishablePage::create();
        $obj->url = $url;
        $obj->prio = $prio;

        return $obj;
    }

    public function objectsToUpdate($context)
    {
        switch ($context['action']) {
            case 'publish':
                return new ArrayList(array($this->generatePublishable('/updateOnPublish', 10)));
            case 'unpublish':
                return new ArrayList(array($this->generatePublishable('/updateOnUnpublish', 10)));
        }
    }

    /**
     * Remove the object on unpublishing (the parent will get updated via objectsToUpdate).
     */
    public function objectsToDelete($context)
    {
        switch ($context['action']) {
            case 'publish':
                return new ArrayList(array($this->generatePublishable('/deleteOnPublish', 10)));
            case 'unpublish':
                return new ArrayList(array($this->generatePublishable('/deleteOnUnpublish', 10)));
        }
    }
}


1			<?php
2
3			namespace SilverStripe\StaticPublishQueue\Test\SiteTreePublishingEngineTest\Model;
4
5			use SilverStripe\CMS\Model\SiteTree;
6			use SilverStripe\Dev\TestOnly;
7			use SilverStripe\ORM\ArrayList;
8			use SilverStripe\StaticPublishQueue\Contract\StaticPublishingTrigger;
9
10			class StaticPublishingTriggerPage extends SiteTree implements TestOnly, StaticPublishingTrigger
11			{
12			private static $table_name = 'SPQ_StaticPublishingTriggerPage';
			0 ignored issues – show introduced 2018-01-16 16:52 UTC by Report Bug Copy Issue Report The private property `$table_name` is not used, and could be removed. Loading history...
13
14			public function generatePublishable($url, $prio)
15			{
16			$obj = StaticallyPublishablePage::create();
17			$obj->url = $url;
18			$obj->prio = $prio;
19
20			return $obj;
21			}
22
23			public function objectsToUpdate($context)
24			{
25			switch ($context['action']) {
26			case 'publish':
27			return new ArrayList(array($this->generatePublishable('/updateOnPublish', 10)));
28			case 'unpublish':
29			return new ArrayList(array($this->generatePublishable('/updateOnUnpublish', 10)));
30			}
31			}
32
33			/**
34			* Remove the object on unpublishing (the parent will get updated via objectsToUpdate).
35			*/
36			public function objectsToDelete($context)
37			{
38			switch ($context['action']) {
39			case 'publish':
40			return new ArrayList(array($this->generatePublishable('/deleteOnPublish', 10)));
41			case 'unpublish':
42			return new ArrayList(array($this->generatePublishable('/deleteOnUnpublish', 10)));
43			}
44			}
45			}
46

silverstripe / silverstripe-staticpublishqueue

Pull Request — master (#70)

StaticPublishingTriggerPage::objectsToDelete() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like