SilverStripe\StaticPublishQueue\Job

Complexity

Total Complexity

2

Size/Duplication

Total Lines	20
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	setup()	0	4	1
A	getSignature()	0	3	1

<?php

namespace SilverStripe\StaticPublishQueue;

use SilverStripe\Core\Config\Configurable;
use SilverStripe\Core\Extensible;
use SilverStripe\ORM\DataObject;
use SilverStripe\StaticPublishQueue\Contract\StaticallyPublishable;
use SilverStripe\StaticPublishQueue\Extension\Publishable\PublishableSiteTree;
use Symbiote\QueuedJobs\Services\AbstractQueuedJob;

abstract class Job extends AbstractQueuedJob
{
    use Configurable;
    use Extensible;

    /**
     * @var int
     * @config
     */
    private static $chunk_size = 200;

The private property $chunk_size is not used, and could be removed.

    public function setup()
    {
        parent::setup();
        $this->totalSteps = ceil(count($this->URLsToProcess) / self::config()->get('chunk_size'));

The property URLsToProcess does not exist on SilverStripe\StaticPublishQueue\Job. Since you implemented __get, consider adding a @property annotation.

    }

    public function getSignature()
    {
        return md5(implode('-', [static::class, implode('-', array_keys($this->URLsToProcess))]));

The property URLsToProcess does not exist on SilverStripe\StaticPublishQueue\Job. Since you implemented __get, consider adding a @property annotation.

It seems like $this->URLsToProcess can also be of type null; however, parameter $input of array_keys() does only seem to accept array, maybe add an additional type check?

    }
}