URLArrayObjectTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	59
Duplicated Lines	44.07 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	testExcludeFromCacheExcludesPageURLs()	13	13	1
A	testExcludeFromCacheExcludesPageURLsWithQueryStrings()	13	13	1
A	testExcludeFromCachePrefersObjectAnnotationOverUrls()	0	15	1
A	getProtectedOrPrivateMethod()	0	6	1

<?php

/**
 * @mixin PHPUnit_Framework_Assert
 */
class URLArrayObjectTest extends SapphireTest {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

	protected static $fixture_file = 'URLArrayObjectTestFixture.yml';
	protected $extraDataObjects = array('URLArrayObjectTestPage');
	protected $requiredExtensions = array(
		'SiteTree' => array('SiteTreePublishingEngine')
	);

	public function testExcludeFromCacheExcludesPageURLs() {

This method seems to be duplicated in your project.

		/** @var URLArrayObject $urlArrayObject */
		$urlArrayObject = singleton('SiteTree')->urlArrayObject;
		$method = $this->getProtectedOrPrivateMethod('excludeFromCache');

		/** @var SiteTree $excluded */
		$excluded = $this->objFromFixture('URLArrayObjectTestPage', 'excluded');
		/** @var SiteTree $included */
		$included = $this->objFromFixture('URLArrayObjectTestPage', 'included');

		$this->assertEquals(true, $method->invoke($urlArrayObject, $excluded->Link()));
		$this->assertEquals(false, $method->invoke($urlArrayObject, $included->Link()));
	}

	public function testExcludeFromCacheExcludesPageURLsWithQueryStrings() {

This method seems to be duplicated in your project.

		/** @var URLArrayObject $urlArrayObject */
		$urlArrayObject = singleton('SiteTree')->urlArrayObject;
		$method = $this->getProtectedOrPrivateMethod('excludeFromCache');

		/** @var SiteTree $excluded */
		$excluded = $this->objFromFixture('URLArrayObjectTestPage', 'excluded');
		/** @var SiteTree $included */
		$included = $this->objFromFixture('URLArrayObjectTestPage', 'included');

		$this->assertEquals(true, $method->invoke($urlArrayObject, $excluded->Link() . '?query=string'));
		$this->assertEquals(false, $method->invoke($urlArrayObject, $included->Link() . '?query=string'));
	}

	public function testExcludeFromCachePrefersObjectAnnotationOverUrls() {
		/** @var URLArrayObject $urlArrayObject */
		$urlArrayObject = singleton('SiteTree')->urlArrayObject;
		$method = $this->getProtectedOrPrivateMethod('excludeFromCache');

		/** @var SiteTree $excluded */
		$excluded = $this->objFromFixture('URLArrayObjectTestPage', 'excluded');
		/** @var SiteTree $included */
		$included = $this->objFromFixture('URLArrayObjectTestPage', 'included');

		$actuallyExcludedUrl = $included->RelativeLink . "?_ID=$excluded->ID&_ClassName=$excluded->ClassName";
		$actuallyIncludedUrl = $excluded->RelativeLink . "?_ID=$included->ID&_ClassName=$included->ClassName";
		$this->assertEquals(true, $method->invoke($urlArrayObject, $actuallyExcludedUrl));
		$this->assertEquals(false, $method->invoke($urlArrayObject, $actuallyIncludedUrl));
	}

	private function getProtectedOrPrivateMethod($name) {
		$method = new ReflectionMethod('URLArrayObject', $name);
		$method->setAccessible(true);

		return $method;
	}
}

class URLArrayObjectTestPage extends SiteTree implements TestOnly

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
	private static $db = array(

The property $db is not used and could be removed.

		'excludeFromCache' => 'Boolean'
	);
}