FormSpamProtectionExtensionTest::testEnableSpamProtectionCustomProtector() - Code Metrics - Inspection of "Configurable fieldname" - silverstripe/silverstripe-spamprotection - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#56)

unknown

created 2017-08-23 00:53 UTC

testEnableSpamProtectionCustomProtector() A

↳ Parent: FormSpamProtectionExtensionTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	0

<?php

/**
 * @package spamprotection
 */
class FormSpamProtectionExtensionTest extends SapphireTest
namespace YourVendor;

class YourClass { }
{
    protected $usesDatabase = false;

    /**
     * @var Form
     */
    protected $form = null;
    
    public function setUp()
    {
        parent::setUp();

        $this->form = new Form($this, 'Form', new FieldList(
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            new TextField('Title'),
            new TextField('Comment'),
            new TextField('URL')
        ), new FieldList()
        );
        $this->form->disableSecurityToken();
        
        //for the tests, ignore any field_name value set in config
        Config::inst()->remove('FormSpamProtectionExtension', 'field_name');
    }

    public function testEnableSpamProtection()
    {
        Config::inst()->update(
            'FormSpamProtectionExtension', 'default_spam_protector',
            'FormSpamProtectionExtensionTest_FooProtector'
        );

        $form = $this->form->enableSpamProtection();

        $this->assertEquals('Foo', $form->Fields()->fieldByName('Captcha')->Title());

    }

    public function testEnableSpamProtectionCustomProtector()
    {
        $form = $this->form->enableSpamProtection(array(
            'protector' => 'FormSpamProtectionExtensionTest_BarProtector'
        ));

        $this->assertEquals('Bar', $form->Fields()->fieldByName('Captcha')->Title());

    }

    public function testEnableSpamProtectionCustomTitle()

    {
        $form = $this->form->enableSpamProtection(array(
            'protector' => 'FormSpamProtectionExtensionTest_BarProtector',
            'title' => 'Baz',
        ));
        
        $this->assertEquals('Baz', $form->Fields()->fieldByName('Captcha')->Title());

    }

    public function testCustomOptions()

    {
        $form = $this->form->enableSpamProtection(array(
            'protector' => 'FormSpamProtectionExtensionTest_BazProtector',
            'title' => 'Qux',
            'name' => 'Borris'
        ));

        $this->assertEquals('Qux', $form->Fields()->fieldByName('Borris')->Title());

    }
    
    public function testConfigurableName()
    {
        $field_name = "test_configurable_name";
        Config::inst()->update(
            'FormSpamProtectionExtension', 'default_spam_protector',
            'FormSpamProtectionExtensionTest_FooProtector'
        );
        Config::inst()->update(
            'FormSpamProtectionExtension', 'field_name',
            $field_name
        );
        $form = $this->form->enableSpamProtection();
        // remove for subsequent tests
        Config::inst()->remove('FormSpamProtectionExtension', 'field_name');
        // field should take up configured name
        $this->assertEquals('Foo', $form->Fields()->fieldByName($field_name)->Title());

    }
    
    public function testInsertBefore()

    {
        $form = $this->form->enableSpamProtection(array(
            'protector' => 'FormSpamProtectionExtensionTest_FooProtector',
            'insertBefore' => 'URL'
        ));
        
        $fields = $form->Fields();
        $this->assertEquals('Title', $fields[0]->Title());

        $this->assertEquals('Comment', $fields[1]->Title());

        $this->assertEquals('Foo', $fields[2]->Title());

        $this->assertEquals('URL', $fields[3]->Title());

    }
    
    public function testInsertBeforeMissing()

    {
        $form = $this->form->enableSpamProtection(array(
            'protector' => 'FormSpamProtectionExtensionTest_FooProtector',
            'insertBefore' => 'NotAField'
        ));
        
        // field should default to the end instead
        $fields = $form->Fields();
        $this->assertEquals('Title', $fields[0]->Title());

        $this->assertEquals('Comment', $fields[1]->Title());

        $this->assertEquals('URL', $fields[2]->Title());

        $this->assertEquals('Foo', $fields[3]->Title());

    }
}

/**
 * @package spamprotection
 */
class FormSpamProtectionExtensionTest_BazProtector implements SpamProtector, TestOnly
namespace YourVendor;

class YourClass { }
{
    public function getFormField($name = null, $title = null, $value = null)
    {
        return new TextField($name, $title, $value);
    }

    public function setFieldMapping($fieldMapping)
    {
    }
}

/**
 * @package spamprotection
 */
class FormSpamProtectionExtensionTest_BarProtector implements SpamProtector, TestOnly
namespace YourVendor;

class YourClass { }
{
    public function getFormField($name = null, $title = null, $value = null)
    {
        $title = $title ?: 'Bar';
        return new TextField($name, $title, $value);
    }

    public function setFieldMapping($fieldMapping)
    {
    }
}

/**
 * @package spamprotection
 */
class FormSpamProtectionExtensionTest_FooProtector implements SpamProtector, TestOnly
namespace YourVendor;

class YourClass { }
{
    public function getFormField($name = null, $title = null, $value = null)
    {
        return new TextField($name, 'Foo', $value);
    }

    public function setFieldMapping($fieldMapping)
    {
    }
}


1		<?php
2
3		/**
4		* @package spamprotection
5		*/
6		class FormSpamProtectionExtensionTest extends SapphireTest
		0 ignored issues – show Coding Style Compatibility introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7		{
8		protected $usesDatabase = false;
9
10		/**
11		* @var Form
12		*/
13		protected $form = null;
14
15		public function setUp()
16		{
17		parent::setUp();
18
19		$this->form = new Form($this, 'Form', new FieldList(
		0 ignored issues – show Documentation introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report `$this` is of type `this<FormSpamProtectionExtensionTest>`, but the function expects a `object<Controller>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
20		new TextField('Title'),
21		new TextField('Comment'),
22		new TextField('URL')
23		), new FieldList()
24		);
25		$this->form->disableSecurityToken();
26
27		//for the tests, ignore any field_name value set in config
28		Config::inst()->remove('FormSpamProtectionExtension', 'field_name');
29		}
30
31		public function testEnableSpamProtection()
32		{
33		Config::inst()->update(
34		'FormSpamProtectionExtension', 'default_spam_protector',
35		'FormSpamProtectionExtensionTest_FooProtector'
36		);
37
38		$form = $this->form->enableSpamProtection();
39
40		$this->assertEquals('Foo', $form->Fields()->fieldByName('Captcha')->Title());
		0 ignored issues – show Bug introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<FormSpamProtectionExtensionTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
41		}
42
43		public function testEnableSpamProtectionCustomProtector()
44		{
45		$form = $this->form->enableSpamProtection(array(
46		'protector' => 'FormSpamProtectionExtensionTest_BarProtector'
47		));
48
49		$this->assertEquals('Bar', $form->Fields()->fieldByName('Captcha')->Title());
		0 ignored issues – show Bug introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<FormSpamProtectionExtensionTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
50		}
51
52	View Code Duplication	public function testEnableSpamProtectionCustomTitle()
		0 ignored issues – show Duplication introduced 2017-08-23 00:55 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
53		{
54		$form = $this->form->enableSpamProtection(array(
55		'protector' => 'FormSpamProtectionExtensionTest_BarProtector',
56		'title' => 'Baz',
57		));
58
59		$this->assertEquals('Baz', $form->Fields()->fieldByName('Captcha')->Title());
		0 ignored issues – show Bug introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<FormSpamProtectionExtensionTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
60		}
61
62	View Code Duplication	public function testCustomOptions()
		0 ignored issues – show Duplication introduced 2017-08-23 00:55 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
63		{
64		$form = $this->form->enableSpamProtection(array(
65		'protector' => 'FormSpamProtectionExtensionTest_BazProtector',
66		'title' => 'Qux',
67		'name' => 'Borris'
68		));
69
70		$this->assertEquals('Qux', $form->Fields()->fieldByName('Borris')->Title());
		0 ignored issues – show Bug introduced 2017-06-14 23:39 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<FormSpamProtectionExtensionTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
71		}
72
73		public function testConfigurableName()
74		{
75		$field_name = "test_configurable_name";
76		Config::inst()->update(
77		'FormSpamProtectionExtension', 'default_spam_protector',
78		'FormSpamProtectionExtensionTest_FooProtector'
79		);
80		Config::inst()->update(
81		'FormSpamProtectionExtension', 'field_name',
82		$field_name
83		);
84		$form = $this->form->enableSpamProtection();
85		// remove for subsequent tests
86		Config::inst()->remove('FormSpamProtectionExtension', 'field_name');
87		// field should take up configured name
88		$this->assertEquals('Foo', $form->Fields()->fieldByName($field_name)->Title());
		0 ignored issues – show Bug introduced 2017-08-23 00:55 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<FormSpamProtectionExtensionTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
89		}
90
91	View Code Duplication	public function testInsertBefore()
		0 ignored issues – show Duplication introduced 2017-08-23 00:55 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
92		{
93		$form = $this->form->enableSpamProtection(array(
94		'protector' => 'FormSpamProtectionExtensionTest_FooProtector',
95		'insertBefore' => 'URL'
96		));
97
98		$fields = $form->Fields();
99		$this->assertEquals('Title', $fields[0]->Title());
		0 ignored issues – show Bug introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<FormSpamProtectionExtensionTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
100		$this->assertEquals('Comment', $fields[1]->Title());
		0 ignored issues – show Bug introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<FormSpamProtectionExtensionTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
101		$this->assertEquals('Foo', $fields[2]->Title());
		0 ignored issues – show Bug introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<FormSpamProtectionExtensionTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
102		$this->assertEquals('URL', $fields[3]->Title());
		0 ignored issues – show Bug introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<FormSpamProtectionExtensionTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
103		}
104
105	View Code Duplication	public function testInsertBeforeMissing()
		0 ignored issues – show Duplication introduced 2017-08-23 00:55 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
106		{
107		$form = $this->form->enableSpamProtection(array(
108		'protector' => 'FormSpamProtectionExtensionTest_FooProtector',
109		'insertBefore' => 'NotAField'
110		));
111
112		// field should default to the end instead
113		$fields = $form->Fields();
114		$this->assertEquals('Title', $fields[0]->Title());
		0 ignored issues – show Bug introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<FormSpamProtectionExtensionTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
115		$this->assertEquals('Comment', $fields[1]->Title());
		0 ignored issues – show Bug introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<FormSpamProtectionExtensionTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
116		$this->assertEquals('URL', $fields[2]->Title());
		0 ignored issues – show Bug introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<FormSpamProtectionExtensionTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
117		$this->assertEquals('Foo', $fields[3]->Title());
		0 ignored issues – show Bug introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<FormSpamProtectionExtensionTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
118		}
119		}
120
121		/**
122		* @package spamprotection
123		*/
124	View Code Duplication	class FormSpamProtectionExtensionTest_BazProtector implements SpamProtector, TestOnly
		0 ignored issues – show Duplication introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style Compatibility introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history... Coding Style Compatibility introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
125		{
126		public function getFormField($name = null, $title = null, $value = null)
127		{
128		return new TextField($name, $title, $value);
129		}
130
131		public function setFieldMapping($fieldMapping)
132		{
133		}
134		}
135
136		/**
137		* @package spamprotection
138		*/
139	View Code Duplication	class FormSpamProtectionExtensionTest_BarProtector implements SpamProtector, TestOnly
		0 ignored issues – show Duplication introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style Compatibility introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history... Coding Style Compatibility introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
140		{
141		public function getFormField($name = null, $title = null, $value = null)
142		{
143		$title = $title ?: 'Bar';
144		return new TextField($name, $title, $value);
145		}
146
147		public function setFieldMapping($fieldMapping)
148		{
149		}
150		}
151
152		/**
153		* @package spamprotection
154		*/
155	View Code Duplication	class FormSpamProtectionExtensionTest_FooProtector implements SpamProtector, TestOnly
		0 ignored issues – show Duplication introduced 2016-01-08 03:40 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style Compatibility introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history... Coding Style Compatibility introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
156		{
157		public function getFormField($name = null, $title = null, $value = null)
158		{
159		return new TextField($name, 'Foo', $value);
160		}
161
162		public function setFieldMapping($fieldMapping)
163		{
164		}
165		}
166

silverstripe / silverstripe-spamprotection

Pull Request — master (#56)

testEnableSpamProtectionCustomProtector() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like