FormSpamProtectionExtensionTest_BazProtector::__construct() - Code Metrics - Inspection of "API Enable spam protectors to receive usercode con..." - silverstripe/silverstripe-spamprotection - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#42)

by Damian

created 2015-12-11 01:35 UTC

__construct() A

↳ Parent: FormSpamProtectionExtensionTest_BazProtector

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php

/**
 * @package spamprotection
 */
class FormSpamProtectionExtensionTest extends SapphireTest
namespace YourVendor;

class YourClass { }
{
    protected $usesDatabase = false;

    /**
     * @var Form
     */
    protected $form = null;
    
    public function setUp()
    {
        parent::setUp();

        $this->form = new Form($this, 'Form', new FieldList(
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            new TextField('Title'),
            new TextField('Comment'),
            new TextField('URL')
        ), new FieldList()
        );
        $this->form->disableSecurityToken();
    }

    public function testEnableSpamProtection()
    {
        Config::inst()->update(
            'FormSpamProtectionExtension', 'default_spam_protector',
            'FormSpamProtectionExtensionTest_FooProtector'
        );

        $form = $this->form->enableSpamProtection();

        $this->assertEquals('Foo', $form->Fields()->fieldByName('Captcha')->Title());

    }

    public function testEnableSpamProtectionCustomProtector()
    {
        $form = $this->form->enableSpamProtection(array(
            'protector' => 'FormSpamProtectionExtensionTest_BarProtector'
        ));

        $this->assertEquals('Bar', $form->Fields()->fieldByName('Captcha')->Title());

    }

    public function testEnableSpamProtectionCustomTitle()
    {
        $form = $this->form->enableSpamProtection(array(
            'protector' => 'FormSpamProtectionExtensionTest_BarProtector',
            'title' => 'Baz',
        ));
        
        $this->assertEquals('Baz', $form->Fields()->fieldByName('Captcha')->Title());

    }

    public function testCustomOptions()
    {
        $form = $this->form->enableSpamProtection(array(
            'protector' => 'FormSpamProtectionExtensionTest_BazProtector',
            'title' => 'Qux',
            'name' => 'Borris',
            'righttitle' => 'Lipsum'
        ));

        $formfield = $form->Fields()->fieldByName('Borris');
        $this->assertEquals('Qux', $formfield->Title());

        $this->assertEquals('Lipsum', $formfield->RightTitle());

    }
    
    public function testInsertBefore()

    {
        $form = $this->form->enableSpamProtection(array(
            'protector' => 'FormSpamProtectionExtensionTest_FooProtector',
            'insertBefore' => 'URL'
        ));
        
        $fields = $form->Fields();
        $this->assertEquals('Title', $fields[0]->Title());

        $this->assertEquals('Comment', $fields[1]->Title());

        $this->assertEquals('Foo', $fields[2]->Title());

        $this->assertEquals('URL', $fields[3]->Title());

    }
    
    public function testInsertBeforeMissing()

    {
        $form = $this->form->enableSpamProtection(array(
            'protector' => 'FormSpamProtectionExtensionTest_FooProtector',
            'insertBefore' => 'NotAField'
        ));
        
        // field should default to the end instead
        $fields = $form->Fields();
        $this->assertEquals('Title', $fields[0]->Title());

        $this->assertEquals('Comment', $fields[1]->Title());

        $this->assertEquals('URL', $fields[2]->Title());

        $this->assertEquals('Foo', $fields[3]->Title());

    }
}

/**
 * @package spamprotection
 */
class FormSpamProtectionExtensionTest_BazProtector implements SpamProtector, TestOnly
namespace YourVendor;

class YourClass { }
{
    protected $options = array();

    public function __construct($options = array())
    {
        $this->options = $options;
    }

    public function getFormField($name = null, $title = null, $value = null)
    {
        $field = new TextField($name, $title, $value);
        if(isset($this->options['righttitle'])) {
            $field->setRightTitle($this->options['righttitle']);
        }
        return $field;
    }

    public function setFieldMapping($fieldMapping)
    {
    }
}

/**
 * @package spamprotection
 */
class FormSpamProtectionExtensionTest_BarProtector implements SpamProtector, TestOnly
namespace YourVendor;

class YourClass { }
{
    public function __construct($options = array())
    {
    }

    public function getFormField($name = null, $title = null, $value = null)
    {
        $title = $title ?: 'Bar';
        return new TextField($name, $title, $value);
    }

    public function setFieldMapping($fieldMapping)
    {
    }
}

/**
 * @package spamprotection
 */
class FormSpamProtectionExtensionTest_FooProtector implements SpamProtector, TestOnly
namespace YourVendor;

class YourClass { }
{
    public function __construct($options = array())
    {
    }

    public function getFormField($name = null, $title = null, $value = null)
    {
        return new TextField($name, 'Foo', $value);
    }

    public function setFieldMapping($fieldMapping)
    {
    }
}


1		<?php
2
3		/**
4		* @package spamprotection
5		*/
6		class FormSpamProtectionExtensionTest extends SapphireTest
		0 ignored issues – show Coding Style Compatibility introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7		{
8		protected $usesDatabase = false;
9
10		/**
11		* @var Form
12		*/
13		protected $form = null;
14
15		public function setUp()
16		{
17		parent::setUp();
18
19		$this->form = new Form($this, 'Form', new FieldList(
		0 ignored issues – show Documentation introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report `$this` is of type `this<FormSpamProtectionExtensionTest>`, but the function expects a `object<Controller>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
20		new TextField('Title'),
21		new TextField('Comment'),
22		new TextField('URL')
23		), new FieldList()
24		);
25		$this->form->disableSecurityToken();
26		}
27
28		public function testEnableSpamProtection()
29		{
30		Config::inst()->update(
31		'FormSpamProtectionExtension', 'default_spam_protector',
32		'FormSpamProtectionExtensionTest_FooProtector'
33		);
34
35		$form = $this->form->enableSpamProtection();
36
37		$this->assertEquals('Foo', $form->Fields()->fieldByName('Captcha')->Title());
		0 ignored issues – show Bug introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<FormSpamProtectionExtensionTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
38		}
39
40		public function testEnableSpamProtectionCustomProtector()
41		{
42		$form = $this->form->enableSpamProtection(array(
43		'protector' => 'FormSpamProtectionExtensionTest_BarProtector'
44		));
45
46		$this->assertEquals('Bar', $form->Fields()->fieldByName('Captcha')->Title());
		0 ignored issues – show Bug introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<FormSpamProtectionExtensionTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
47		}
48
49		public function testEnableSpamProtectionCustomTitle()
50		{
51		$form = $this->form->enableSpamProtection(array(
52		'protector' => 'FormSpamProtectionExtensionTest_BarProtector',
53		'title' => 'Baz',
54		));
55
56		$this->assertEquals('Baz', $form->Fields()->fieldByName('Captcha')->Title());
		0 ignored issues – show Bug introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<FormSpamProtectionExtensionTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
57		}
58
59		public function testCustomOptions()
60		{
61		$form = $this->form->enableSpamProtection(array(
62		'protector' => 'FormSpamProtectionExtensionTest_BazProtector',
63		'title' => 'Qux',
64		'name' => 'Borris',
65		'righttitle' => 'Lipsum'
66		));
67
68		$formfield = $form->Fields()->fieldByName('Borris');
69		$this->assertEquals('Qux', $formfield->Title());
		0 ignored issues – show Bug introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<FormSpamProtectionExtensionTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
70		$this->assertEquals('Lipsum', $formfield->RightTitle());
		0 ignored issues – show Bug introduced 2015-12-11 01:37 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<FormSpamProtectionExtensionTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
71		}
72
73	View Code Duplication	public function testInsertBefore()
		0 ignored issues – show Duplication introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
74		{
75		$form = $this->form->enableSpamProtection(array(
76		'protector' => 'FormSpamProtectionExtensionTest_FooProtector',
77		'insertBefore' => 'URL'
78		));
79
80		$fields = $form->Fields();
81		$this->assertEquals('Title', $fields[0]->Title());
		0 ignored issues – show Bug introduced 2015-11-25 15:41 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<FormSpamProtectionExtensionTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
82		$this->assertEquals('Comment', $fields[1]->Title());
		0 ignored issues – show Bug introduced 2015-11-25 15:41 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<FormSpamProtectionExtensionTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
83		$this->assertEquals('Foo', $fields[2]->Title());
		0 ignored issues – show Bug introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<FormSpamProtectionExtensionTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
84		$this->assertEquals('URL', $fields[3]->Title());
		0 ignored issues – show Bug introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<FormSpamProtectionExtensionTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
85		}
86
87	View Code Duplication	public function testInsertBeforeMissing()
		0 ignored issues – show Duplication introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
88		{
89		$form = $this->form->enableSpamProtection(array(
90		'protector' => 'FormSpamProtectionExtensionTest_FooProtector',
91		'insertBefore' => 'NotAField'
92		));
93
94		// field should default to the end instead
95		$fields = $form->Fields();
96		$this->assertEquals('Title', $fields[0]->Title());
		0 ignored issues – show Bug introduced 2015-11-25 15:41 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<FormSpamProtectionExtensionTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
97		$this->assertEquals('Comment', $fields[1]->Title());
		0 ignored issues – show Bug introduced 2015-11-25 15:41 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<FormSpamProtectionExtensionTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
98		$this->assertEquals('URL', $fields[2]->Title());
		0 ignored issues – show Bug introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<FormSpamProtectionExtensionTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
99		$this->assertEquals('Foo', $fields[3]->Title());
		0 ignored issues – show Bug introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<FormSpamProtectionExtensionTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
100		}
101		}
102
103		/**
104		* @package spamprotection
105		*/
106		class FormSpamProtectionExtensionTest_BazProtector implements SpamProtector, TestOnly
		0 ignored issues – show Coding Style Compatibility introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history... Coding Style Compatibility introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
107		{
108		protected $options = array();
109
110		public function __construct($options = array())
111		{
112		$this->options = $options;
113		}
114
115		public function getFormField($name = null, $title = null, $value = null)
116		{
117		$field = new TextField($name, $title, $value);
118		if(isset($this->options['righttitle'])) {
119		$field->setRightTitle($this->options['righttitle']);
120		}
121		return $field;
122		}
123
124		public function setFieldMapping($fieldMapping)
125		{
126		}
127		}
128
129		/**
130		* @package spamprotection
131		*/
132		class FormSpamProtectionExtensionTest_BarProtector implements SpamProtector, TestOnly
		0 ignored issues – show Coding Style Compatibility introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history... Coding Style Compatibility introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
133		{
134		public function __construct($options = array())
135		{
136		}
137
138		public function getFormField($name = null, $title = null, $value = null)
139		{
140		$title = $title ?: 'Bar';
141		return new TextField($name, $title, $value);
142		}
143
144		public function setFieldMapping($fieldMapping)
145		{
146		}
147		}
148
149		/**
150		* @package spamprotection
151		*/
152		class FormSpamProtectionExtensionTest_FooProtector implements SpamProtector, TestOnly
		0 ignored issues – show Coding Style Compatibility introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history... Coding Style Compatibility introduced 2015-11-21 06:29 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
153		{
154		public function __construct($options = array())
155		{
156		}
157
158		public function getFormField($name = null, $title = null, $value = null)
159		{
160		return new TextField($name, 'Foo', $value);
161		}
162
163		public function setFieldMapping($fieldMapping)
164		{
165		}
166		}
167

silverstripe / silverstripe-spamprotection

Pull Request — master (#42)

__construct() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like