SitewideContentReportTest::testReportFields() - Code Metrics - Inspection of "Merge branch '3.0'" - silverstripe/silverstripe-sitewidecontent-report - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( bb09e8...93e365 )

by Robbie

created 2019-03-07 20:52 UTC

SitewideContentReportTest::testReportFields() B

↳ Parent: SitewideContentReportTest

Complexity

Conditions	5
Paths	16

Size

Total Lines	70
Code Lines	43

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
eloc	43
nc	16
nop	0
dl	0
loc	70
rs	8.9208
c	0
b	0
f	0

How to fix Long Method

<?php

namespace SilverStripe\SiteWideContentReport\Tests;

use Page;
filter:
    dependency_paths: ["lib/*"]
use SilverStripe\CMS\Model\SiteTree;
use SilverStripe\ContentReview\Extensions\SiteTreeContentReview;
filter:
    dependency_paths: ["lib/*"]
use SilverStripe\Core\Config\Config;
use SilverStripe\Dev\SapphireTest;
use SilverStripe\Forms\DropdownField;
use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\GridField\GridFieldDataColumns;
use SilverStripe\Forms\GridField\GridFieldExportButton;
use SilverStripe\ORM\DataList;
use SilverStripe\SiteWideContentReport\Model\SitewideContentTaxonomy;
use SilverStripe\SiteWideContentReport\SitewideContentReport;
use SilverStripe\Subsites\Model\Subsite;
filter:
    dependency_paths: ["lib/*"]

class SitewideContentReportTest extends SapphireTest
{
    /**
     * @var string
     */
    protected static $fixture_file = 'SitewideContentReportTest.yml';

    public function setUp()
    {
        // Stop default page creation from occuring - just use fixtures
        Config::modify()->set(SiteTree::class, 'create_default_pages', false);

        // This module is made to work with subsites, but will still operate without it (although presumably being of
        // far less value). The fixture includes subsite definitions, which is a problem if the module isn't installed.
        // So we'll use the same fixture without the subsites definitions if this is the case.
        if (!class_exists(Subsite::class)) {
            static::$fixture_file = 'SitewideContentReportNoSubsitesTest.yml';
        }

        parent::setUp();

        foreach (range(1, 5) as $i) {
            /** @var SiteTree $page */
            $page = $this->objFromFixture(Page::class, "page{$i}");

            if ($i <= 3) {
                $page->publishRecursive();
            }
        }
    }

    public function testSourceRecords()
    {
        $report = SitewideContentReport::create();
        $records = $report->sourceRecords([]);

        $this->assertCount(2, $records, 'Returns an array with 2 items, one for pages and one for files');
        $this->assertArrayHasKey('Pages', $records);
        $this->assertArrayHasKey('Pages', /** @scrutinizer ignore-type */ $records);
        $this->assertArrayHasKey('Files', $records);

        /** @var DataList $pages */
        $pages = $records['Pages'];

        /** @var DataList $files */
        $files = $records['Files'];

        $this->assertCount(5, $pages, 'Total number of pages');
        $this->assertCount(1, $files, 'Total number of files');
    }

    public function testParameterFields()
    {
        $report = SitewideContentReport::create();
        /** @var FieldList $fields */
        $fields = $report->parameterFields();

        if (class_exists(Subsite::class)) {
            /** @var DropdownField $field */
            $field = $fields->fieldByName('AllSubsites');
            $keys = array_filter(array_keys($field->getSource()));
            $keys = array_filter(array_keys(/** @scrutinizer ignore-type */ $field->getSource()));

            $this->assertCount(4, $keys, '2 subsites plus 2 added options to filter by subsite');
        } else {
            $this->assertNull($fields->fieldByName('AllSubsites'));
        }
    }

    public function testReportFields()
    {
        $report = SitewideContentReport::create();

        // Test pages view
        $gridField = $report->getReportField('Pages');

        /* @var $columns GridFieldDataColumns */
        $columns = $gridField->getConfig()->getComponentByType(GridFieldDataColumns::class);
        $displayed = $columns->getDisplayFields($gridField);

        $this->assertArrayHasKey('Title', $displayed);
        $this->assertArrayHasKey('Created', $displayed);
        $this->assertArrayHasKey('LastEdited', $displayed);
        $this->assertArrayHasKey('i18n_singular_name', $displayed);
        $this->assertArrayHasKey('StageState', $displayed);

        // Use correct link
        $this->assertArrayHasKey('RelativeLink', $displayed);
        $this->assertArrayNotHasKey('AbsoluteLink', $displayed);

        if (class_exists(Subsite::class)) {
            $this->assertArrayHasKey('SubsiteName', $displayed);
        } else {
            $this->assertArrayNotHasKey('SubsiteName', $displayed);
        }

        // Export-only fields are not in display list
        $this->assertArrayNotHasKey('Terms', $displayed);
        $this->assertArrayNotHasKey('OwnerNames', $displayed);
        $this->assertArrayNotHasKey('ReviewDate', $displayed);
        $this->assertArrayNotHasKey('MetaDescription', $displayed);

        // Tests print / export field
        /* @var $export GridFieldExportButton */
        $export = $gridField->getConfig()->getComponentByType(GridFieldExportButton::class);
        $exported = $export->getExportColumns();

        // Make sure all shared columns are in this report
        $this->assertArrayHasKey('Title', $exported);
        $this->assertArrayHasKey('Created', $exported);
        $this->assertArrayHasKey('LastEdited', $exported);
        $this->assertArrayHasKey('i18n_singular_name', $exported);
        $this->assertArrayHasKey('StageState', $exported);

        // Export-only fields
        $this->assertArrayHasKey('MetaDescription', $exported);

        // Use correct link
        $this->assertArrayHasKey('AbsoluteLink', $exported);
        $this->assertArrayNotHasKey('RelativeLink', $exported);

        if (class_exists(Subsite::class)) {
            $this->assertArrayHasKey('SubsiteName', $exported);
        } else {
            $this->assertArrayNotHasKey('SubsiteName', $exported);
        }

        if (SitewideContentTaxonomy::enabled()) {
            $this->assertArrayHasKey('Terms', $exported);
        } else {
            $this->assertArrayNotHasKey('Terms', $exported);
        }

        if (class_exists(SiteTreeContentReview::class)) {
            $this->assertArrayHasKey('OwnerNames', $exported);
            $this->assertArrayHasKey('ReviewDate', $exported);
        } else {
            $this->assertArrayNotHasKey('OwnerNames', $exported);
            $this->assertArrayNotHasKey('ReviewDate', $exported);
        }
    }
}


silverstripe / silverstripe-sitewidecontent-report

Push — master ( bb09e8...93e365 )

SitewideContentReportTest::testReportFields() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like