Issues in SiteConfigLeftAndMain.php (master) - Issues in master - silverstripe/silverstripe-siteconfig - Measure and Improve Code Quality continuously with Scrutinizer

Issues (41)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/SiteConfigLeftAndMain.php (4 issues)

Labels

Severity

Minor 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace SilverStripe\SiteConfig;

use SilverStripe\Admin\LeftAndMain;
use SilverStripe\CMS\Model\SiteTree;
use SilverStripe\Control\Director;
use SilverStripe\Forms\Form;
use SilverStripe\Forms\FormAction;
use SilverStripe\Forms\HiddenField;
use SilverStripe\Forms\LiteralField;
use SilverStripe\ORM\ArrayList;
use SilverStripe\ORM\DataObject;
use SilverStripe\ORM\ValidationResult;
use SilverStripe\View\ArrayData;
use SilverStripe\View\Requirements;

class SiteConfigLeftAndMain extends LeftAndMain
{
    /**
     * @var string
     */
    private static $url_segment = 'settings';

    /**
     * @var string
     */
    private static $url_rule = '/$Action/$ID/$OtherID';

    /**
     * @var int
     */
    private static $menu_priority = -1;

    /**
     * @var string
     */
    private static $menu_title = 'Settings';

    /**
     * @var string
     */
    private static $menu_icon_class = 'font-icon-cog';

    /**
     * @var string
     */
    private static $tree_class = SiteConfig::class;

    /**
     * @var array
     */
    private static $required_permission_codes = array('EDIT_SITECONFIG');

    /**
     * Initialises the {@link SiteConfig} controller.
     */
    public function init()
    {
        parent::init();
        if (class_exists(SiteTree::class)) {
            Requirements::javascript('silverstripe/cms: client/dist/js/bundle.js');
        }
    }

    /**
     * @param null $id Not used.
     * @param null $fields Not used.
     *
     * @return Form
     */
    public function getEditForm($id = null, $fields = null)
    {
        $siteConfig = SiteConfig::current_site_config();
        $fields = $siteConfig->getCMSFields();

        // Tell the CMS what URL the preview should show
        $home = Director::absoluteBaseURL();
        $fields->push(new HiddenField('PreviewURL', 'Preview URL', $home));

        // Added in-line to the form, but plucked into different view by LeftAndMain.Preview.js upon load
        /** @skipUpgrade */
        $fields->push($navField = new LiteralField('SilverStripeNavigator', $this->getSilverStripeNavigator()));
        $navField->setAllowHTML(true);

        // Retrieve validator, if one has been setup (e.g. via data extensions).
        if ($siteConfig->hasMethod("getCMSValidator")) {
            $validator = $siteConfig->getCMSValidator();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        } else {
            $validator = null;
        }

        $actions = $siteConfig->getCMSActions();
        $negotiator = $this->getResponseNegotiator();
        /** @var Form $form */
        $form = Form::create(
            $this,
            'EditForm',
            $fields,
            $actions,
            $validator
        )->setHTMLID('Form_EditForm');
        $form->setValidationResponseCallback(function (ValidationResult $errors) use ($negotiator, $form) {
            $request = $this->getRequest();
            if ($request->isAjax() && $negotiator) {
                $result = $form->forTemplate();
                return $negotiator->respond($request, array(
                    'CurrentForm' => function () use ($result) {
                        return $result;
                    }
                ));
            }
        });
        $form->addExtraClass('flexbox-area-grow fill-height cms-content cms-edit-form');
        $form->setAttribute('data-pjax-fragment', 'CurrentForm');

        if ($form->Fields()->hasTabSet()) {
            $form->Fields()->findOrMakeTab('Root')->setTemplate('SilverStripe\\Forms\\CMSTabSet');
        }
        $form->setHTMLID('Form_EditForm');
        $form->loadDataFrom($siteConfig);
        $form->setTemplate($this->getTemplatesWithSuffix('_EditForm'));


        // Use <button> to allow full jQuery UI styling
        $actions = $actions->dataFields();
        if ($actions) {

            /** @var FormAction $action */
            foreach ($actions as $action) {
                $action->setUseButtonTag(true);
            }
        }

        $this->extend('updateEditForm', $form);

        return $form;
    }

    /**
     * Save the current sites {@link SiteConfig} into the database.
     *
     * @param array $data
     * @param Form $form
     * @return String
     */
    public function save_siteconfig($data, $form)
    {
        $data = $form->getData();
        $siteConfig = DataObject::get_one(SiteConfig::class, ['ID' => $data['ID']]);
        $form->saveInto($siteConfig);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
        $siteConfig->write();
        $this->response->addHeader('X-Status', rawurlencode(_t(LeftAndMain::class . '.SAVEDUP', 'Saved.')));
        return $form->forTemplate();
    }


    public function Breadcrumbs($unlinked = false)
    {
        return new ArrayList(array(
            new ArrayData(array(
                'Title' => static::menu_title(),
                'Link' => $this->Link()
            ))
        ));
    }
}


1			<?php
2
3			namespace SilverStripe\SiteConfig;
4
5			use SilverStripe\Admin\LeftAndMain;
6			use SilverStripe\CMS\Model\SiteTree;
7			use SilverStripe\Control\Director;
8			use SilverStripe\Forms\Form;
9			use SilverStripe\Forms\FormAction;
10			use SilverStripe\Forms\HiddenField;
11			use SilverStripe\Forms\LiteralField;
12			use SilverStripe\ORM\ArrayList;
13			use SilverStripe\ORM\DataObject;
14			use SilverStripe\ORM\ValidationResult;
15			use SilverStripe\View\ArrayData;
16			use SilverStripe\View\Requirements;
17
18			class SiteConfigLeftAndMain extends LeftAndMain
19			{
20			/**
21			* @var string
22			*/
23			private static $url_segment = 'settings';
24
25			/**
26			* @var string
27			*/
28			private static $url_rule = '/$Action/$ID/$OtherID';
29
30			/**
31			* @var int
32			*/
33			private static $menu_priority = -1;
34
35			/**
36			* @var string
37			*/
38			private static $menu_title = 'Settings';
39
40			/**
41			* @var string
42			*/
43			private static $menu_icon_class = 'font-icon-cog';
44
45			/**
46			* @var string
47			*/
48			private static $tree_class = SiteConfig::class;
49
50			/**
51			* @var array
52			*/
53			private static $required_permission_codes = array('EDIT_SITECONFIG');
54
55			/**
56			* Initialises the {@link SiteConfig} controller.
57			*/
58			public function init()
59			{
60			parent::init();
61			if (class_exists(SiteTree::class)) {
62			Requirements::javascript('silverstripe/cms: client/dist/js/bundle.js');
63			}
64			}
65
66			/**
67			* @param null $id Not used.
68			* @param null $fields Not used.
69			*
70			* @return Form
71			*/
72			public function getEditForm($id = null, $fields = null)
73			{
74			$siteConfig = SiteConfig::current_site_config();
75			$fields = $siteConfig->getCMSFields();
76
77			// Tell the CMS what URL the preview should show
78			$home = Director::absoluteBaseURL();
79			$fields->push(new HiddenField('PreviewURL', 'Preview URL', $home));
80
81			// Added in-line to the form, but plucked into different view by LeftAndMain.Preview.js upon load
82			/** @skipUpgrade */
83			$fields->push($navField = new LiteralField('SilverStripeNavigator', $this->getSilverStripeNavigator()));
84			$navField->setAllowHTML(true);
85
86			// Retrieve validator, if one has been setup (e.g. via data extensions).
87			if ($siteConfig->hasMethod("getCMSValidator")) {
88			$validator = $siteConfig->getCMSValidator();
			0 ignored issues – show Documentation Bug introduced 2017-02-26 22:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getCMSValidator` does not exist on `object<SilverStripe\SiteConfig\SiteConfig>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
89			} else {
90			$validator = null;
91			}
92
93			$actions = $siteConfig->getCMSActions();
94			$negotiator = $this->getResponseNegotiator();
95			/** @var Form $form */
96			$form = Form::create(
97			$this,
98			'EditForm',
99			$fields,
100			$actions,
101			$validator
102			)->setHTMLID('Form_EditForm');
103			$form->setValidationResponseCallback(function (ValidationResult $errors) use ($negotiator, $form) {
104			$request = $this->getRequest();
105			if ($request->isAjax() && $negotiator) {
106			$result = $form->forTemplate();
107			return $negotiator->respond($request, array(
108			'CurrentForm' => function () use ($result) {
109			return $result;
110			}
111			));
112			}
113			});
114			$form->addExtraClass('flexbox-area-grow fill-height cms-content cms-edit-form');
115			$form->setAttribute('data-pjax-fragment', 'CurrentForm');
116
117			if ($form->Fields()->hasTabSet()) {
118			$form->Fields()->findOrMakeTab('Root')->setTemplate('SilverStripe\\Forms\\CMSTabSet');
119			}
120			$form->setHTMLID('Form_EditForm');
121			$form->loadDataFrom($siteConfig);
122			$form->setTemplate($this->getTemplatesWithSuffix('_EditForm'));
			0 ignored issues – show Bug introduced 2017-07-26 09:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->getTemplatesWithSuffix('_EditForm')` targeting `SilverStripe\Admin\LeftA...etTemplatesWithSuffix()` can also be of type `array`; however, `SilverStripe\Forms\Form::setTemplate()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
123
124			// Use <button> to allow full jQuery UI styling
125			$actions = $actions->dataFields();
126			if ($actions) {
			0 ignored issues – show Bug Best Practice introduced 2017-02-26 22:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$actions` of type `SilverStripe\Forms\FormField[]` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
127			/** @var FormAction $action */
128			foreach ($actions as $action) {
129			$action->setUseButtonTag(true);
130			}
131			}
132
133			$this->extend('updateEditForm', $form);
134
135			return $form;
136			}
137
138			/**
139			* Save the current sites {@link SiteConfig} into the database.
140			*
141			* @param array $data
142			* @param Form $form
143			* @return String
144			*/
145			public function save_siteconfig($data, $form)
146			{
147			$data = $form->getData();
148			$siteConfig = DataObject::get_one(SiteConfig::class, ['ID' => $data['ID']]);
149			$form->saveInto($siteConfig);
			0 ignored issues – show Bug introduced 2017-09-28 16:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$siteConfig` defined by `\SilverStripe\ORM\DataOb...y('ID' => $data['ID']))` on line `148` can be `null`; however, `SilverStripe\Forms\Form::saveInto()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
150			$siteConfig->write();
151			$this->response->addHeader('X-Status', rawurlencode(_t(LeftAndMain::class . '.SAVEDUP', 'Saved.')));
152			return $form->forTemplate();
153			}
154
155
156			public function Breadcrumbs($unlinked = false)
157			{
158			return new ArrayList(array(
159			new ArrayData(array(
160			'Title' => static::menu_title(),
161			'Link' => $this->Link()
162			))
163			));
164			}
165			}
166

silverstripe / silverstripe-siteconfig

Issues (41)

Security Analysis not enabled

code/SiteConfigLeftAndMain.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like