silverstripe / silverstripe-siteconfig

tests/behat/features/bootstrap/SilverStripe/SiteConfig/Test/Behaviour/ThemeContext.php

Doc Comments +6 added lines

@@ -54,6 +54,9 @@ 
         $this->requireFile(BASE_PATH . '/themes/' . $theme . '/templates/' . $template, $content);
     }
 
+    /**
+     * @param string $filename
+     */
     protected function requireFile($filename, $content)
     {
         // Already exists
@@ -71,6 +74,9 @@ 
         }
     }
 
+    /**
+     * @param string $dirname
+     */
     protected function requireDir($dirname)
     {
         // Directory doesn't exist, create it and mark it for deletion

Spacing +4 added lines, -4 removed lines

@@ -31,9 +31,9 @@ 
             throw new \InvalidArgumentException("Bad theme '$theme'");
         }
 
-        $this->requireDir(BASE_PATH . '/themes');
-        $this->requireDir(BASE_PATH . '/themes/' . $theme);
-        $this->requireDir(BASE_PATH . '/themes/' . $theme . '/templates');
+        $this->requireDir(BASE_PATH.'/themes');
+        $this->requireDir(BASE_PATH.'/themes/'.$theme);
+        $this->requireDir(BASE_PATH.'/themes/'.$theme.'/templates');
     }
 
     /**
@@ -51,7 +51,7 @@ 
         }
 
         $this->stepCreateTheme($theme);
-        $this->requireFile(BASE_PATH . '/themes/' . $theme . '/templates/' . $template, $content);
+        $this->requireFile(BASE_PATH.'/themes/'.$theme.'/templates/'.$template, $content);
     }
 
     protected function requireFile($filename, $content)

code/SiteConfig.php

Doc Comments +1 added lines, -1 removed lines

@@ -242,7 +242,7 @@
      * Can a user view this SiteConfig instance?
      *
      * @param Member $member
-     * @return boolean
+     * @return boolean|string
      */
     public function canView($member = null)
     {

Spacing +2 added lines, -2 removed lines

@@ -148,9 +148,9 @@
             $fields->makeFieldReadonly($titleField);
         }
 
-        if (file_exists(BASE_PATH . '/install.php')) {
+        if (file_exists(BASE_PATH.'/install.php')) {
             $fields->addFieldToTab("Root.Main", new LiteralField("InstallWarningHeader",
-                "<p class=\"message warning\">" . _t("SiteTree.REMOVE_INSTALL_WARNING",
+                "<p class=\"message warning\">"._t("SiteTree.REMOVE_INSTALL_WARNING",
                 "Warning: You should remove install.php from this SilverStripe install for security reasons.")
                 . "</p>"), "Title");
         }

code/SiteConfigLeftAndMain.php

Doc Comments +1 added lines, -1 removed lines

@@ -134,7 +134,7 @@
 	 *
 	 * @param array $data
 	 * @param Form $form
-	 * @return String
+	 * @return \SilverStripe\ORM\FieldType\DBHTMLText
 	 */
     public function save_siteconfig($data, $form)
     {

Spacing +2 added lines, -2 removed lines

@@ -57,7 +57,7 @@ 
 	public function init() {
 		parent::init();
         if (defined('CMS_DIR')) {
-            Requirements::javascript(CMS_DIR . '/client/dist/js/bundle.js');
+            Requirements::javascript(CMS_DIR.'/client/dist/js/bundle.js');
         }
 	}
 
@@ -96,7 +96,7 @@ 
 		)->setHTMLID('Form_EditForm');
 		$form->setValidationResponseCallback(function(ValidationResult $errors) use ($negotiator, $form) {
 			$request = $this->getRequest();
-			if($request->isAjax() && $negotiator) {
+			if ($request->isAjax() && $negotiator) {
 				$result = $form->forTemplate();
 				return $negotiator->respond($request, array(
 					'CurrentForm' => function() use($result) {

tests/behat/features/bootstrap/Context/FeatureContext.php

Spacing +2 added lines, -2 removed lines

@@ -36,7 +36,7 @@ 
 
         // Add extra contexts with more steps
         $this->useContext('ThemeContext', new \SilverStripe\Siteconfig\Test\Behaviour\ThemeContext($parameters));
-        if(!class_exists('SilverStripe\\CMS\\Model\\SiteTree')) {
+        if (!class_exists('SilverStripe\\CMS\\Model\\SiteTree')) {
             return;
         }
 
@@ -44,7 +44,7 @@ 
         $factory = $fixtureContext->getFixtureFactory();
         foreach (ClassInfo::subclassesFor('SilverStripe\\CMS\\Model\\SiteTree') as $id => $class) {
             $blueprint = Injector::inst()->create('SilverStripe\\Dev\\FixtureBlueprint', $class);
-            $blueprint->addCallback('afterCreate', function ($obj, $identifier, &$data, &$fixtures) {
+            $blueprint->addCallback('afterCreate', function($obj, $identifier, &$data, &$fixtures) {
                 $obj->publish('Stage', 'Live');
             });
             $factory->define($class, $blueprint);