SiteConfigTest

Complexity

Total Complexity

6

Size/Duplication

Total Lines	65
Duplicated Lines	40 %

Coupling/Cohesion

Components	2
Dependencies	2

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	testCanCreateRootPages()	13	13	1
A	testCanViewPages()	0	5	1
A	testCanEdit()	0	12	1
A	testCanEditPages()	13	13	1
A	setUpAfterClass()	0	9	2

<?php

use SilverStripe\SiteConfig\SiteConfig;
use SilverStripe\Dev\SapphireTest;

/**
 * @package siteconfig
 * @subpackage tests
 */
class SiteConfigTest extends SapphireTest

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    protected static $fixture_file = 'SiteConfigTest.yml';

    protected static $illegal_extensions = array(
        'SilverStripe\\CMS\\Model\\SiteTree' => array('SiteTreeSubsites'),
    );

    public static function setUpAfterClass()
    {
        // Fix issue with tests failing without CMS module
        if (!class_exists('SilverStripe\\CMS\\Model\\SiteTree')) {
            unset(static::$illegal_extensions['SilverStripe\\CMS\\Model\\SiteTree']);
        }

        static::setUpAfterClass(); // TODO: Change the autogenerated stub
    }

    public function testCanCreateRootPages()

This method seems to be duplicated in your project.

    {
        $config = $this->objFromFixture('SilverStripe\\SiteConfig\\SiteConfig', 'default');

        // Log in without pages admin access
        $this->logInWithPermission('CMS_ACCESS_AssetAdmin');
        $this->assertFalse($config->canCreateTopLevel());

        // Login with necessary edit permission
        $perms = SiteConfig::config()->required_permission;
        $this->logInWithPermission(reset($perms));
        $this->assertTrue($config->canCreateTopLevel());
    }

    public function testCanViewPages()
    {
        $config = $this->objFromFixture('SilverStripe\\SiteConfig\\SiteConfig', 'default');
        $this->assertTrue($config->canViewPages());
    }

    public function testCanEdit()
    {
        $config = $this->objFromFixture('SilverStripe\\SiteConfig\\SiteConfig', 'default');

        // Unrelated permissions don't allow siteconfig
        $this->logInWithPermission('CMS_ACCESS_AssetAdmin');
        $this->assertFalse($config->canEdit());

        // Only those with edit permission can do this
        $this->logInWithPermission('EDIT_SITECONFIG');
        $this->assertTrue($config->canEdit());
    }

    public function testCanEditPages()

This method seems to be duplicated in your project.

    {
        $config = $this->objFromFixture('SilverStripe\\SiteConfig\\SiteConfig', 'default');

        // Log in without pages admin access
        $this->logInWithPermission('CMS_ACCESS_AssetAdmin');
        $this->assertFalse($config->canEditPages());

        // Login with necessary edit permission
        $perms = SiteConfig::config()->required_permission;
        $this->logInWithPermission(reset($perms));
        $this->assertTrue($config->canEditPages());
    }
}