Completed
Branch 3 (14518c)
by Christopher
06:12
created
code/controller/SiteConfigLeftAndMain.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -69,14 +69,14 @@  discard block
 block discarded – undo
69 69
 		$form->addExtraClass('cms-content center cms-edit-form');
70 70
 		$form->setAttribute('data-pjax-fragment', 'CurrentForm');
71 71
 
72
-		if($form->Fields()->hasTabset()) $form->Fields()->findOrMakeTab('Root')->setTemplate('CMSTabSet');
72
+		if ($form->Fields()->hasTabset()) $form->Fields()->findOrMakeTab('Root')->setTemplate('CMSTabSet');
73 73
 		$form->setHTMLID('Form_EditForm');
74 74
 		$form->loadDataFrom($siteConfig);
75 75
 		$form->setTemplate($this->getTemplatesWithSuffix('_EditForm'));
76 76
 
77 77
 		// Use <button> to allow full jQuery UI styling
78 78
 		$actions = $actions->dataFields();
79
-		if($actions) foreach($actions as $action) $action->setUseButtonTag(true);
79
+		if ($actions) foreach ($actions as $action) $action->setUseButtonTag(true);
80 80
 
81 81
 		$this->extend('updateEditForm', $form);
82 82
 
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
 		
106 106
 		try {
107 107
 			$siteConfig->write();
108
-		} catch(ValidationException $ex) {
108
+		} catch (ValidationException $ex) {
109 109
 			$form->sessionMessage($ex->getResult()->message(), 'bad');
110 110
 			return $this->getResponseNegotiator()->respond($this->request);
111 111
 		}
Please login to merge, or discard this patch.
code/model/SiteConfig.php 1 patch
Spacing   +29 added lines, -29 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 	public function getCMSFields() {
74 74
 		$groupsMap = array();
75 75
 
76
-		foreach(Group::get() as $group) {
76
+		foreach (Group::get() as $group) {
77 77
 			// Listboxfield values are escaped, use ASCII char instead of &raquo;
78 78
 			$groupsMap[$group->ID] = $group->getBreadcrumbs(' > ');
79 79
 		}
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
 			$fields->makeFieldReadonly($titleField);
143 143
 		}
144 144
 
145
-		if(file_exists(BASE_PATH . '/install.php')) {
145
+		if (file_exists(BASE_PATH . '/install.php')) {
146 146
 			$fields->addFieldToTab("Root.Main", new LiteralField("InstallWarningHeader", 
147 147
 				"<p class=\"message warning\">" . _t("SiteTree.REMOVE_INSTALL_WARNING", 
148 148
 				"Warning: You should remove install.php from this SilverStripe install for security reasons.")
@@ -165,10 +165,10 @@  discard block
 block discarded – undo
165 165
 	 */
166 166
 	public function getAvailableThemes($baseDir = null) {
167 167
 		$themes = SSViewer::get_themes($baseDir);
168
-		$disabled = (array)$this->config()->disabled_themes;
168
+		$disabled = (array) $this->config()->disabled_themes;
169 169
 	
170
-		foreach($disabled as $theme) {
171
-			if(isset($themes[$theme])) unset($themes[$theme]);
170
+		foreach ($disabled as $theme) {
171
+			if (isset($themes[$theme])) unset($themes[$theme]);
172 172
 		}
173 173
 	
174 174
 		return $themes;
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
 	public function getCMSActions() {
185 185
 		if (Permission::check('ADMIN') || Permission::check('EDIT_SITECONFIG')) {
186 186
 			$actions = new FieldList(
187
-				FormAction::create('save_siteconfig', _t('CMSMain.SAVE','Save'))
187
+				FormAction::create('save_siteconfig', _t('CMSMain.SAVE', 'Save'))
188 188
 					->addExtraClass('ss-ui-action-constructive')->setAttribute('data-icon', 'accept')
189 189
 			);
190 190
 		} else {
@@ -223,10 +223,10 @@  discard block
 block discarded – undo
223 223
 
224 224
 		$config = DataObject::get_one('SiteConfig');
225 225
 		
226
-		if(!$config) {
226
+		if (!$config) {
227 227
 			self::make_site_config();
228 228
 
229
-			DB::alteration_message("Added default site config","created");
229
+			DB::alteration_message("Added default site config", "created");
230 230
 		}
231 231
 	}
232 232
 	
@@ -249,11 +249,11 @@  discard block
 block discarded – undo
249 249
 	 * @return boolean
250 250
 	 */
251 251
 	public function canView($member = null) {
252
-		if(!$member) $member = Member::currentUserID();
253
- 		if($member && is_numeric($member)) $member = DataObject::get_by_id('Member', $member);
252
+		if (!$member) $member = Member::currentUserID();
253
+ 		if ($member && is_numeric($member)) $member = DataObject::get_by_id('Member', $member);
254 254
 
255 255
 		$extended = $this->extendedCan('canView', $member);
256
-		if($extended !== null) return $extended;
256
+		if ($extended !== null) return $extended;
257 257
 
258 258
 		// Assuming all that can edit this object can also view it
259 259
 		return $this->canEdit($member);
@@ -268,21 +268,21 @@  discard block
 block discarded – undo
268 268
 	 * @return boolean
269 269
 	 */
270 270
 	public function canViewPages($member = null) {
271
-		if(!$member) $member = Member::currentUserID();
272
-		if($member && is_numeric($member)) $member = DataObject::get_by_id('Member', $member);
271
+		if (!$member) $member = Member::currentUserID();
272
+		if ($member && is_numeric($member)) $member = DataObject::get_by_id('Member', $member);
273 273
 
274 274
 		if ($member && Permission::checkMember($member, "ADMIN")) return true;
275 275
 
276 276
 		$extended = $this->extendedCan('canViewPages', $member);
277
-		if($extended !== null) return $extended;
277
+		if ($extended !== null) return $extended;
278 278
 
279 279
 		if (!$this->CanViewType || $this->CanViewType == 'Anyone') return true;
280 280
 
281 281
 		// check for any logged-in users
282
-		if($this->CanViewType === 'LoggedInUsers' && $member) return true;
282
+		if ($this->CanViewType === 'LoggedInUsers' && $member) return true;
283 283
 
284 284
 		// check for specific groups
285
-		if($this->CanViewType === 'OnlyTheseUsers' && $member && $member->inGroups($this->ViewerGroups())) return true;
285
+		if ($this->CanViewType === 'OnlyTheseUsers' && $member && $member->inGroups($this->ViewerGroups())) return true;
286 286
 
287 287
 		return false;
288 288
 	}
@@ -296,23 +296,23 @@  discard block
 block discarded – undo
296 296
 	 * @return boolean
297 297
 	 */
298 298
 	public function canEditPages($member = null) {
299
-		if(!$member) $member = Member::currentUserID();
300
-		if($member && is_numeric($member)) $member = DataObject::get_by_id('Member', $member);
299
+		if (!$member) $member = Member::currentUserID();
300
+		if ($member && is_numeric($member)) $member = DataObject::get_by_id('Member', $member);
301 301
 
302 302
 		if ($member && Permission::checkMember($member, "ADMIN")) return true;
303 303
 
304 304
 		$extended = $this->extendedCan('canEditPages', $member);
305
-		if($extended !== null) return $extended;
305
+		if ($extended !== null) return $extended;
306 306
 
307 307
 		// check for any logged-in users with CMS access
308
-		if( $this->CanEditType === 'LoggedInUsers'
308
+		if ($this->CanEditType === 'LoggedInUsers'
309 309
 			&& Permission::checkMember($member, $this->config()->required_permission)
310 310
 		) {
311 311
 			return true;
312 312
 		}
313 313
 
314 314
 		// check for specific groups
315
-		if($this->CanEditType === 'OnlyTheseUsers' && $member && $member->inGroups($this->EditorGroups())) {
315
+		if ($this->CanEditType === 'OnlyTheseUsers' && $member && $member->inGroups($this->EditorGroups())) {
316 316
 			return true;
317 317
 		}
318 318
 
@@ -320,11 +320,11 @@  discard block
 block discarded – undo
320 320
 	}
321 321
 
322 322
 	public function canEdit($member = null) {
323
-		if(!$member) $member = Member::currentUserID();
324
-		if($member && is_numeric($member)) $member = DataObject::get_by_id('Member', $member);
323
+		if (!$member) $member = Member::currentUserID();
324
+		if ($member && is_numeric($member)) $member = DataObject::get_by_id('Member', $member);
325 325
 
326 326
 		$extended = $this->extendedCan('canEdit', $member);
327
-		if($extended !== null) return $extended;
327
+		if ($extended !== null) return $extended;
328 328
 
329 329
 		return Permission::checkMember($member, "EDIT_SITECONFIG");
330 330
 	}
@@ -350,23 +350,23 @@  discard block
 block discarded – undo
350 350
 	 * @return boolean
351 351
 	 */
352 352
 	public function canCreateTopLevel($member = null) {
353
-		if(!$member) $member = Member::currentUserID();
354
-		if($member && is_numeric($member)) $member = DataObject::get_by_id('Member', $member);
353
+		if (!$member) $member = Member::currentUserID();
354
+		if ($member && is_numeric($member)) $member = DataObject::get_by_id('Member', $member);
355 355
 
356 356
 		if ($member && Permission::checkMember($member, "ADMIN")) return true;
357 357
 
358 358
 		$extended = $this->extendedCan('canCreateTopLevel', $member);
359
-		if($extended !== null) return $extended;
359
+		if ($extended !== null) return $extended;
360 360
 
361 361
 		// check for any logged-in users with CMS permission
362
-		if( $this->CanCreateTopLevelType === 'LoggedInUsers'
362
+		if ($this->CanCreateTopLevelType === 'LoggedInUsers'
363 363
 			&& Permission::checkMember($member, $this->config()->required_permission)
364 364
 		) {
365 365
 			return true;
366 366
 		}
367 367
 
368 368
 		// check for specific groups
369
-		if( $this->CanCreateTopLevelType === 'OnlyTheseUsers'
369
+		if ($this->CanCreateTopLevelType === 'OnlyTheseUsers'
370 370
 			&& $member
371 371
 			&& $member->inGroups($this->CreateTopLevelGroups())
372 372
 		) {
Please login to merge, or discard this patch.