SilverStripe\SecurityExtensions\Extension\MemberExtension

Complexity

Total Complexity

12

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getRequiresPasswordChangeOnNextLogin()	0	3	1
A	updateCMSFields()	0	18	4
B	saveRequiresPasswordChangeOnNextLogin()	0	20	7

<?php

declare(strict_types=1);

namespace SilverStripe\SecurityExtensions\Extension;

use SilverStripe\Forms\CheckboxField;
use SilverStripe\Forms\FieldList;
use SilverStripe\ORM\DataExtension;
use SilverStripe\ORM\FieldType\DBDatetime;
use SilverStripe\Security\Member;
use SilverStripe\Security\Security;

/**
 * Extend Member to add relationship to registered methods and track some specific preferences
 *
 * @property Member|MemberExtension owner
 */
class MemberExtension extends DataExtension
{
    public function updateCMSFields(FieldList $fields)
    {
        $currentUser = Security::getCurrentUser();

        // We can allow an admin to require a user to change their password however. But:
        // - Don't show a read only field if the user cannot edit this record
        // - Don't show if a user views their own profile (just let them reset their own password)
        if ($currentUser && ($currentUser->ID !== $this->owner->ID) && $this->owner->canEdit()) {

The property ID does not exist on SilverStripe\SecurityExtensions\Extension\MemberExtension. Did you maybe forget to declare it?

The call to SilverStripe\ORM\DataExtension::canEdit() has too few arguments starting with member.

            $requireNewPassword = CheckboxField::create(
                'RequiresPasswordChangeOnNextLogin',
                _t(__CLASS__ . '.RequiresPasswordChangeOnNextLogin', 'Requires password change on next log in')
            );
            $fields->insertAfter('Password', $requireNewPassword);

            $fields->dataFieldByName('Password')->addExtraClass('form-field--no-divider mb-0 pb-0');
        }

        return $fields;
    }

    public function getRequiresPasswordChangeOnNextLogin()
    {
        return $this->owner->isPasswordExpired();

The method isPasswordExpired() does not exist on SilverStripe\SecurityExtensions\Extension\MemberExtension.

    }

    /**
     * Set password expiry to now to enforce a change of password next log in
     *
     * @param int|null $dataValue boolean representation checked/not checked {@see CheckboxField::dataValue}
     * @return Member
     */
    public function saveRequiresPasswordChangeOnNextLogin($dataValue)
    {
        $member = $this->owner;

        if (!$member->canEdit()) {

The expression $member->canEdit() of type boolean|null is loosely compared to false; this is ambiguous if the boolean can be false. You might want to explicitly use !== null instead.

The call to SilverStripe\ORM\DataExtension::canEdit() has too few arguments starting with member.

            return $member;

The expression return $member also could return the type SilverStripe\SecurityExtensions\Extension\MemberExtension which is incompatible with the documented return type SilverStripe\Security\Member.

        }

        $currentValue = $member->PasswordExpiry;
        $currentDate = $member->dbObject('PasswordExpiry');

The method dbObject() does not exist on SilverStripe\SecurityExtensions\Extension\MemberExtension.

        if ($dataValue && (!$currentValue || $currentDate->inFuture())) {

The expression $dataValue of type integer|null is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== null instead.

            // Only alter future expiries - this way an admin could see how long ago a password expired still
            $member->PasswordExpiry = DBDatetime::now()->Rfc2822();

The property PasswordExpiry does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        } elseif (!$dataValue && $member->isPasswordExpired()) {

The expression $dataValue of type integer|null is loosely compared to false; this is ambiguous if the integer can be 0. You might want to explicitly use === null instead.

            // Only unset if the expiry date is in the past
            $member->PasswordExpiry = null;
        }

        return $member;

The expression return $member also could return the type SilverStripe\SecurityExtensions\Extension\MemberExtension which is incompatible with the documented return type SilverStripe\Security\Member.

    }
}