SAMLController::acs() - Code Metrics - Inspection of "Add Azure AD capability to module" - silverstripe/silverstripe-saml - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#16)

by Matt

created 2019-05-16 11:56 UTC

SAMLController::acs() D

↳ Parent: SAMLController

Complexity

Conditions	19
Paths	72

Size

Total Lines	139
Code Lines	72

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	19
eloc	72
nc	72
nop	0
dl	0
loc	139
rs	4.5166
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

namespace SilverStripe\SAML\Control;

use Exception;
use function gmmktime;
use OneLogin\Saml2\Auth;
use OneLogin\Saml2\Constants;
use OneLogin\Saml2\Utils;
use OneLogin\Saml2\Error;
use Psr\Log\LoggerInterface;
use SilverStripe\Core\Config\Config;
use SilverStripe\ORM\ValidationResult;
use SilverStripe\SAML\Authenticators\SAMLAuthenticator;
use SilverStripe\SAML\Authenticators\SAMLLoginForm;
use SilverStripe\SAML\Helpers\SAMLHelper;
use SilverStripe\Control\Controller;
use SilverStripe\Control\Director;
use SilverStripe\Control\HTTPResponse;
use SilverStripe\Core\Injector\Injector;
use SilverStripe\SAML\Model\SAMLResponse;
use SilverStripe\SAML\Services\SAMLConfiguration;
use SilverStripe\Security\IdentityStore;
use SilverStripe\Security\Member;
use SilverStripe\Security\Security;
use function uniqid;

/**
 * Class SAMLController
 *
 * This controller handles serving metadata requests for the identity provider (IdP), as well as handling the creation
 * of new users and logging them into SilverStripe after being authenticated at the IdP.
 */
class SAMLController extends Controller
{
    /**
     * @var array
     */
    private static $allowed_actions = [
        'index',
        'acs',
        'metadata'
    ];

    public function index()
    {
        return $this->redirect('/');
    }

    /**
     * Assertion Consumer Service
     *
     * The user gets sent back here after authenticating with the IdP, off-site.
     * The earlier redirection to the IdP can be found in the SAMLAuthenticator::authenticate.
     *
     * After this handler completes, we end up with a rudimentary Member record (which will be created on-the-fly
     * if not existent), with the user already logged in. Login triggers memberLoggedIn hooks, which allows
     * LDAP side of this module to finish off loading Member data.
     *
     * @throws Error
     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function acs()
    {
        /** @var Auth $auth */
        $auth = Injector::inst()->get(SAMLHelper::class)->getSAMLAuth();
        $caughtException = null;

        // Log both errors (reported by php-saml and thrown as exception) with a common ID for later tracking
        $uniqueErrorId = uniqid('SAML-');

        // Force php-saml module to use the current absolute base URL (e.g. https://www.example.com/saml). This avoids
        // errors that we otherwise get when having a multi-directory ACS URL like /saml/acs).
        // See https://github.com/onelogin/php-saml/issues/249
        Utils::setBaseURL(Controller::join_links($auth->getSettings()->getSPData()['entityId'], 'saml'));

        // Attempt to process the SAML response. If there are errors during this, log them and redirect to the generic
        // error page. Note: This does not necessarily include all SAML errors (e.g. we still need to confirm if the
        // user is authenticated after this block
        try {
            $auth->processResponse();
            $error = $auth->getLastErrorReason();
        } catch (Exception $e) {
            $caughtException = $e;
        }

        // If there was an issue with the SAML response, if it was missing or if the SAML response indicates that they
        // aren't authorised, then log the issue and provide a traceable error back to the user via the login form
        if (
            $caughtException ||
            !empty($error) ||
            !$auth->isAuthenticated() ||
            $this->checkForReplayAttack($auth, $uniqueErrorId)
        ) {
            if ($caughtException instanceof Exception) {
                $this->getLogger()->error(sprintf(
                    '[%s] [code: %s] %s (%s:%s)',
                    $uniqueErrorId,
                    $e->getCode(),

                    $e->getMessage(),
                    $e->getFile(),
                    $e->getLine()
                ));
            }

            if (!empty($error)) {
                $this->getLogger()->error(sprintf('[%s] %s', $uniqueErrorId, $error));
            }

            $this->getForm()->sessionMessage(
                _t(
                    'SilverStripe\\SAML\\Control\\SAMLController.ERR_SAML_ACS_FAILURE',
                    'Unfortunately we couldn\'t log you in. If this continues, please contact your I.T. department'
                    . ' with the following reference: {ref}',
                    ['ref' => $uniqueErrorId]
                ),
                ValidationResult::TYPE_ERROR
            );

            // Redirect the user back to the login form to display the generic error message and reference
            $this->getRequest()->getSession()->save($this->getRequest());
            return $this->redirect('Security/login');
        }

        /**
         * If processing reaches here, then the user is authenticated - the rest of this method is just processing their
         * legitimate information and configuring their account.
         */

        // If we expect the NameID to be a binary version of the GUID (ADFS), check that it actually is
        // If we are configured not to expect a binary NameID, then we assume it is a direct GUID (Azure AD)
        if (Config::inst()->get(SAMLConfiguration::class, 'expect_binary_nameid')) {
            $decodedNameId = base64_decode($auth->getNameId());
            if (ctype_print($decodedNameId)) {
                $this->getForm()->sessionMessage('NameID from IdP is not a binary GUID.', ValidationResult::TYPE_ERROR);
                $this->getRequest()->getSession()->save($this->getRequest());
                return $this->getRedirect();
            }

            // transform the NameId to guid
            $helper = SAMLHelper::singleton();
            $guid = $helper->binToStrGuid($decodedNameId);
            if (!$helper->validGuid($guid)) {
                $errorMessage = "Not a valid GUID '{$guid}' recieved from server.";
                $this->getLogger()->error($errorMessage);
                $this->getForm()->sessionMessage($errorMessage, ValidationResult::TYPE_ERROR);
                $this->getRequest()->getSession()->save($this->getRequest());
                return $this->getRedirect();
            }
        } else {
            $guid = $auth->getNameId();
        }

        $attributes = $auth->getAttributes();

        $fieldToClaimMap = array_flip(Member::config()->claims_field_mappings);

        // Write a rudimentary member with basic fields on every login, so that we at least have something
        // if there is no further sync (e.g. via LDAP)
        $member = Member::get()->filter('GUID', $guid)->limit(1)->first();
        if (!($member && $member->exists()) && Config::inst()->get(SAMLConfiguration::class, 'allow_insecure_email_linking') && isset($fieldToClaimMap['Email'])) {
            // If there is no member found via GUID and we allow linking via email, search by email
            $member = Member::get()->filter('Email', $attributes[$fieldToClaimMap['Email']])->limit(1)->first();

            if (!($member && $member->exists())) {
                $member = new Member();
            }

            $member->GUID = $guid;
        }

        foreach ($member->config()->claims_field_mappings as $claim => $field) {
            if (!isset($attributes[$claim][0])) {
                $this->getLogger()->warning(
                    sprintf(
                        'Claim rule \'%s\' configured in SAMLMemberExtension.claims_field_mappings, ' .
                                'but wasn\'t passed through. Please check IdP claim rules.',
                        $claim
                    )
                );

                continue;
            }

            $member->$field = $attributes[$claim][0];
        }

        $member->SAMLSessionIndex = $auth->getSessionIndex();

        // This will trigger LDAP update through LDAPMemberExtension::memberLoggedIn, if the LDAP module is installed.
        // The LDAP update will also write the Member record a second time, but the member *must* be written before
        // IdentityStore->logIn() is called, otherwise the identity store throws an exception.
        // Both SAML and LDAP identify Members by the same GUID field.
        $member->write();

        /** @var IdentityStore $identityStore */
        $identityStore = Injector::inst()->get(IdentityStore::class);
        $persistent = Security::config()->get('autologin_enabled');
        $identityStore->logIn($member, $persistent, $this->getRequest());

        return $this->getRedirect();
    }

    /**
     * Generate this SP's metadata. This is needed for intialising the SP-IdP relationship.
     * IdP is instructed to call us back here to establish the relationship. IdP may also be configured
     * to hit this endpoint periodically during normal operation, to check the SP availability.
     */
    public function metadata()
    {
        try {
            /** @var Auth $auth */
            $auth = Injector::inst()->get(SAMLHelper::class)->getSAMLAuth();
            $settings = $auth->getSettings();
            $metadata = $settings->getSPMetadata();
            $errors = $settings->validateMetadata($metadata);
            if (empty($errors)) {
                header('Content-Type: text/xml');
                echo $metadata;
            } else {
                throw new Error(
                    'Invalid SP metadata: ' . implode(', ', $errors),
                    Error::METADATA_SP_INVALID
                );
            }
        } catch (Exception $e) {
            $this->getLogger()->error($e->getMessage());
            echo $e->getMessage();
        }
    }

    /**
     * @return HTTPResponse
     */
    protected function getRedirect()
    {
        // Absolute redirection URLs may cause spoofing
        if ($this->getRequest()->getSession()->get('BackURL')
            && Director::is_site_url($this->getRequest()->getSession()->get('BackURL'))) {
            return $this->redirect($this->getRequest()->getSession()->get('BackURL'));
        }

        // Spoofing attack, redirect to homepage instead of spoofing url
        if ($this->getRequest()->getSession()->get('BackURL')
            && !Director::is_site_url($this->getRequest()->getSession()->get('BackURL'))) {
            return $this->redirect(Director::absoluteBaseURL());
        }

        // If a default login dest has been set, redirect to that.
        if (Security::config()->default_login_dest) {
            return $this->redirect(Director::absoluteBaseURL() . Security::config()->default_login_dest);
        }

        // fallback to redirect back to home page
        return $this->redirect(Director::absoluteBaseURL());
    }

    /**
     * If processing reaches here, then the user is authenticated but potentially not valid. We first need to confirm
     * that they are not an attacker performing a SAML replay attack (capturing the raw traffic from a compromised
     * device and then re-submitting the same SAML response).
     *
     * To combat this, we store SAML response IDs for the amount of time they're valid for (plus a configurable offset
     * to account for potential time skew), and if the ID has been seen before we log an error message and return true
     * (which indicates that this specific request is a replay attack).
     *
     * If no replay attack is detected, then the SAML response is logged so that future requests can be blocked.
     *
     * @param Auth $auth The Auth object that includes the processed response
     * @param string $uniqueErrorId The error code to use when logging error messages for this given error
     * @return bool true if this response is a replay attack, false if it's the first time we've seen the ID
     */
    protected function checkForReplayAttack(Auth $auth, $uniqueErrorId = '')
    {
        $responseId = $auth->getLastMessageId();
        $expiry = $auth->getLastAssertionNotOnOrAfter(); // Note: Expiry will always be stored and returned in UTC

        // Search for any SAMLResponse objects where the response ID is the same and the expiry is within the range
        $count = SAMLResponse::get()->filter(['ResponseID' => $responseId])->count();

        if ($count > 0) {
            // Response found, therefore this is a replay attack - log the error and return false so the user is denied
            $this->getLogger()->error(sprintf(
                '[%s] SAML replay attack detected! Response ID "%s", expires "%s", client IP "%s"',
                $uniqueErrorId,
                $responseId,
                $expiry,
                $this->getRequest()->getIP()
            ));

            return true;
        } else {
            // No attack detected, log the SAML response
            $response = new SAMLResponse([
                'ResponseID' => $responseId,
                'Expiry' => $expiry
            ]);

            $response->write();
            return false;
        }
    }

    /**
     * Get a logger
     *
     * @return LoggerInterface
     */
    public function getLogger()
    {
        return Injector::inst()->get(LoggerInterface::class);
    }

    /**
     * Gets the login form
     *
     * @return SAMLLoginForm
     */
    public function getForm()
    {
        return Injector::inst()->get(SAMLLoginForm::class, true, [$this, SAMLAuthenticator::class, 'LoginForm']);
    }
}


1			<?php
2
3			namespace SilverStripe\SAML\Control;
4
5			use Exception;
6			use function gmmktime;
7			use OneLogin\Saml2\Auth;
8			use OneLogin\Saml2\Constants;
9			use OneLogin\Saml2\Utils;
10			use OneLogin\Saml2\Error;
11			use Psr\Log\LoggerInterface;
12			use SilverStripe\Core\Config\Config;
13			use SilverStripe\ORM\ValidationResult;
14			use SilverStripe\SAML\Authenticators\SAMLAuthenticator;
15			use SilverStripe\SAML\Authenticators\SAMLLoginForm;
16			use SilverStripe\SAML\Helpers\SAMLHelper;
17			use SilverStripe\Control\Controller;
18			use SilverStripe\Control\Director;
19			use SilverStripe\Control\HTTPResponse;
20			use SilverStripe\Core\Injector\Injector;
21			use SilverStripe\SAML\Model\SAMLResponse;
22			use SilverStripe\SAML\Services\SAMLConfiguration;
23			use SilverStripe\Security\IdentityStore;
24			use SilverStripe\Security\Member;
25			use SilverStripe\Security\Security;
26			use function uniqid;
27
28			/**
29			* Class SAMLController
30			*
31			* This controller handles serving metadata requests for the identity provider (IdP), as well as handling the creation
32			* of new users and logging them into SilverStripe after being authenticated at the IdP.
33			*/
34			class SAMLController extends Controller
35			{
36			/**
37			* @var array
38			*/
39			private static $allowed_actions = [
40			'index',
41			'acs',
42			'metadata'
43			];
44
45			public function index()
46			{
47			return $this->redirect('/');
48			}
49
50			/**
51			* Assertion Consumer Service
52			*
53			* The user gets sent back here after authenticating with the IdP, off-site.
54			* The earlier redirection to the IdP can be found in the SAMLAuthenticator::authenticate.
55			*
56			* After this handler completes, we end up with a rudimentary Member record (which will be created on-the-fly
57			* if not existent), with the user already logged in. Login triggers memberLoggedIn hooks, which allows
58			* LDAP side of this module to finish off loading Member data.
59			*
60			* @throws Error
61			* @throws \Psr\Container\NotFoundExceptionInterface
62			*/
63			public function acs()
64			{
65			/** @var Auth $auth */
66			$auth = Injector::inst()->get(SAMLHelper::class)->getSAMLAuth();
67			$caughtException = null;
68
69			// Log both errors (reported by php-saml and thrown as exception) with a common ID for later tracking
70			$uniqueErrorId = uniqid('SAML-');
71
72			// Force php-saml module to use the current absolute base URL (e.g. https://www.example.com/saml). This avoids
73			// errors that we otherwise get when having a multi-directory ACS URL like /saml/acs).
74			// See https://github.com/onelogin/php-saml/issues/249
75			Utils::setBaseURL(Controller::join_links($auth->getSettings()->getSPData()['entityId'], 'saml'));
76
77			// Attempt to process the SAML response. If there are errors during this, log them and redirect to the generic
78			// error page. Note: This does not necessarily include all SAML errors (e.g. we still need to confirm if the
79			// user is authenticated after this block
80			try {
81			$auth->processResponse();
82			$error = $auth->getLastErrorReason();
83			} catch (Exception $e) {
84			$caughtException = $e;
85			}
86
87			// If there was an issue with the SAML response, if it was missing or if the SAML response indicates that they
88			// aren't authorised, then log the issue and provide a traceable error back to the user via the login form
89			if (
90			$caughtException \|\|
91			!empty($error) \|\|
92			!$auth->isAuthenticated() \|\|
93			$this->checkForReplayAttack($auth, $uniqueErrorId)
94			) {
95			if ($caughtException instanceof Exception) {
96			$this->getLogger()->error(sprintf(
97			'[%s] [code: %s] %s (%s:%s)',
98			$uniqueErrorId,
99			$e->getCode(),
			0 ignored issues – show Comprehensibility Best Practice introduced 2018-09-20 10:16 UTC by Report Bug Copy Issue Report The variable `$e` does not seem to be defined for all execution paths leading up to this point. Loading history...
100			$e->getMessage(),
101			$e->getFile(),
102			$e->getLine()
103			));
104			}
105
106			if (!empty($error)) {
107			$this->getLogger()->error(sprintf('[%s] %s', $uniqueErrorId, $error));
108			}
109
110			$this->getForm()->sessionMessage(
111			_t(
112			'SilverStripe\\SAML\\Control\\SAMLController.ERR_SAML_ACS_FAILURE',
113			'Unfortunately we couldn\'t log you in. If this continues, please contact your I.T. department'
114			. ' with the following reference: {ref}',
115			['ref' => $uniqueErrorId]
116			),
117			ValidationResult::TYPE_ERROR
118			);
119
120			// Redirect the user back to the login form to display the generic error message and reference
121			$this->getRequest()->getSession()->save($this->getRequest());
122			return $this->redirect('Security/login');
123			}
124
125			/**
126			* If processing reaches here, then the user is authenticated - the rest of this method is just processing their
127			* legitimate information and configuring their account.
128			*/
129
130			// If we expect the NameID to be a binary version of the GUID (ADFS), check that it actually is
131			// If we are configured not to expect a binary NameID, then we assume it is a direct GUID (Azure AD)
132			if (Config::inst()->get(SAMLConfiguration::class, 'expect_binary_nameid')) {
133			$decodedNameId = base64_decode($auth->getNameId());
134			if (ctype_print($decodedNameId)) {
135			$this->getForm()->sessionMessage('NameID from IdP is not a binary GUID.', ValidationResult::TYPE_ERROR);
136			$this->getRequest()->getSession()->save($this->getRequest());
137			return $this->getRedirect();
138			}
139
140			// transform the NameId to guid
141			$helper = SAMLHelper::singleton();
142			$guid = $helper->binToStrGuid($decodedNameId);
143			if (!$helper->validGuid($guid)) {
144			$errorMessage = "Not a valid GUID '{$guid}' recieved from server.";
145			$this->getLogger()->error($errorMessage);
146			$this->getForm()->sessionMessage($errorMessage, ValidationResult::TYPE_ERROR);
147			$this->getRequest()->getSession()->save($this->getRequest());
148			return $this->getRedirect();
149			}
150			} else {
151			$guid = $auth->getNameId();
152			}
153
154			$attributes = $auth->getAttributes();
155
156			$fieldToClaimMap = array_flip(Member::config()->claims_field_mappings);
157
158			// Write a rudimentary member with basic fields on every login, so that we at least have something
159			// if there is no further sync (e.g. via LDAP)
160			$member = Member::get()->filter('GUID', $guid)->limit(1)->first();
161			if (!($member && $member->exists()) && Config::inst()->get(SAMLConfiguration::class, 'allow_insecure_email_linking') && isset($fieldToClaimMap['Email'])) {
162			// If there is no member found via GUID and we allow linking via email, search by email
163			$member = Member::get()->filter('Email', $attributes[$fieldToClaimMap['Email']])->limit(1)->first();
164
165			if (!($member && $member->exists())) {
166			$member = new Member();
167			}
168
169			$member->GUID = $guid;
170			}
171
172			foreach ($member->config()->claims_field_mappings as $claim => $field) {
173			if (!isset($attributes[$claim][0])) {
174			$this->getLogger()->warning(
175			sprintf(
176			'Claim rule \'%s\' configured in SAMLMemberExtension.claims_field_mappings, ' .
177			'but wasn\'t passed through. Please check IdP claim rules.',
178			$claim
179			)
180			);
181
182			continue;
183			}
184
185			$member->$field = $attributes[$claim][0];
186			}
187
188			$member->SAMLSessionIndex = $auth->getSessionIndex();
189
190			// This will trigger LDAP update through LDAPMemberExtension::memberLoggedIn, if the LDAP module is installed.
191			// The LDAP update will also write the Member record a second time, but the member must be written before
192			// IdentityStore->logIn() is called, otherwise the identity store throws an exception.
193			// Both SAML and LDAP identify Members by the same GUID field.
194			$member->write();
195
196			/** @var IdentityStore $identityStore */
197			$identityStore = Injector::inst()->get(IdentityStore::class);
198			$persistent = Security::config()->get('autologin_enabled');
199			$identityStore->logIn($member, $persistent, $this->getRequest());
200
201			return $this->getRedirect();
202			}
203
204			/**
205			* Generate this SP's metadata. This is needed for intialising the SP-IdP relationship.
206			* IdP is instructed to call us back here to establish the relationship. IdP may also be configured
207			* to hit this endpoint periodically during normal operation, to check the SP availability.
208			*/
209			public function metadata()
210			{
211			try {
212			/** @var Auth $auth */
213			$auth = Injector::inst()->get(SAMLHelper::class)->getSAMLAuth();
214			$settings = $auth->getSettings();
215			$metadata = $settings->getSPMetadata();
216			$errors = $settings->validateMetadata($metadata);
217			if (empty($errors)) {
218			header('Content-Type: text/xml');
219			echo $metadata;
220			} else {
221			throw new Error(
222			'Invalid SP metadata: ' . implode(', ', $errors),
223			Error::METADATA_SP_INVALID
224			);
225			}
226			} catch (Exception $e) {
227			$this->getLogger()->error($e->getMessage());
228			echo $e->getMessage();
229			}
230			}
231
232			/**
233			* @return HTTPResponse
234			*/
235			protected function getRedirect()
236			{
237			// Absolute redirection URLs may cause spoofing
238			if ($this->getRequest()->getSession()->get('BackURL')
239			&& Director::is_site_url($this->getRequest()->getSession()->get('BackURL'))) {
240			return $this->redirect($this->getRequest()->getSession()->get('BackURL'));
241			}
242
243			// Spoofing attack, redirect to homepage instead of spoofing url
244			if ($this->getRequest()->getSession()->get('BackURL')
245			&& !Director::is_site_url($this->getRequest()->getSession()->get('BackURL'))) {
246			return $this->redirect(Director::absoluteBaseURL());
247			}
248
249			// If a default login dest has been set, redirect to that.
250			if (Security::config()->default_login_dest) {
251			return $this->redirect(Director::absoluteBaseURL() . Security::config()->default_login_dest);
252			}
253
254			// fallback to redirect back to home page
255			return $this->redirect(Director::absoluteBaseURL());
256			}
257
258			/**
259			* If processing reaches here, then the user is authenticated but potentially not valid. We first need to confirm
260			* that they are not an attacker performing a SAML replay attack (capturing the raw traffic from a compromised
261			* device and then re-submitting the same SAML response).
262			*
263			* To combat this, we store SAML response IDs for the amount of time they're valid for (plus a configurable offset
264			* to account for potential time skew), and if the ID has been seen before we log an error message and return true
265			* (which indicates that this specific request is a replay attack).
266			*
267			* If no replay attack is detected, then the SAML response is logged so that future requests can be blocked.
268			*
269			* @param Auth $auth The Auth object that includes the processed response
270			* @param string $uniqueErrorId The error code to use when logging error messages for this given error
271			* @return bool true if this response is a replay attack, false if it's the first time we've seen the ID
272			*/
273			protected function checkForReplayAttack(Auth $auth, $uniqueErrorId = '')
274			{
275			$responseId = $auth->getLastMessageId();
276			$expiry = $auth->getLastAssertionNotOnOrAfter(); // Note: Expiry will always be stored and returned in UTC
277
278			// Search for any SAMLResponse objects where the response ID is the same and the expiry is within the range
279			$count = SAMLResponse::get()->filter(['ResponseID' => $responseId])->count();
280
281			if ($count > 0) {
282			// Response found, therefore this is a replay attack - log the error and return false so the user is denied
283			$this->getLogger()->error(sprintf(
284			'[%s] SAML replay attack detected! Response ID "%s", expires "%s", client IP "%s"',
285			$uniqueErrorId,
286			$responseId,
287			$expiry,
288			$this->getRequest()->getIP()
289			));
290
291			return true;
292			} else {
293			// No attack detected, log the SAML response
294			$response = new SAMLResponse([
295			'ResponseID' => $responseId,
296			'Expiry' => $expiry
297			]);
298
299			$response->write();
300			return false;
301			}
302			}
303
304			/**
305			* Get a logger
306			*
307			* @return LoggerInterface
308			*/
309			public function getLogger()
310			{
311			return Injector::inst()->get(LoggerInterface::class);
312			}
313
314			/**
315			* Gets the login form
316			*
317			* @return SAMLLoginForm
318			*/
319			public function getForm()
320			{
321			return Injector::inst()->get(SAMLLoginForm::class, true, [$this, SAMLAuthenticator::class, 'LoginForm']);
322			}
323			}
324

silverstripe / silverstripe-saml

Pull Request — master (#16)

SAMLController::acs() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like