silverstripe /
silverstripe-restfulserver
| Total Complexity | 94 |
| Total Lines | 684 |
| Duplicated Lines | 2.05 % |
| Changes | 0 | ||
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like RestfulServer often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use RestfulServer, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 40 | class RestfulServer extends Controller |
||
| 41 | { |
||
| 42 | private static $url_handlers = array( |
||
| 43 | '$ClassName!/$ID/$Relation' => 'handleAction', |
||
| 44 | '' => 'notFound' |
||
| 45 | ); |
||
| 46 | |||
| 47 | /** |
||
| 48 | * @config |
||
| 49 | * @var string root of the api route, MUST have a trailing slash |
||
| 50 | */ |
||
| 51 | private static $api_base = "api/v1/"; |
||
| 52 | |||
| 53 | /** |
||
| 54 | * @config |
||
| 55 | * @var string Class name for an authenticator to use on API access |
||
| 56 | */ |
||
| 57 | private static $authenticator = BasicRestfulAuthenticator::class; |
||
| 58 | |||
| 59 | /** |
||
| 60 | * If no extension is given in the request, resolve to this extension |
||
| 61 | * (and subsequently the {@link self::$default_mimetype}. |
||
| 62 | * |
||
| 63 | * @var string |
||
| 64 | */ |
||
| 65 | private static $default_extension = "xml"; |
||
| 66 | |||
| 67 | /** |
||
| 68 | * If no extension is given, resolve the request to this mimetype. |
||
| 69 | * |
||
| 70 | * @var string |
||
| 71 | */ |
||
| 72 | protected static $default_mimetype = "text/xml"; |
||
| 73 | |||
| 74 | /** |
||
| 75 | * @uses authenticate() |
||
| 76 | * @var Member |
||
| 77 | */ |
||
| 78 | protected $member; |
||
| 79 | |||
| 80 | private static $allowed_actions = array( |
||
| 81 | 'index', |
||
| 82 | 'notFound' |
||
| 83 | ); |
||
| 84 | |||
| 85 | public function init() |
||
| 86 | { |
||
| 87 | /* This sets up SiteTree the same as when viewing a page through the frontend. Versioned defaults |
||
| 88 | * to Stage, and then when viewing the front-end Versioned::choose_site_stage changes it to Live. |
||
| 89 | * TODO: In 3.2 we should make the default Live, then change to Stage in the admin area (with a nicer API) |
||
| 90 | */ |
||
| 91 | if (class_exists(SiteTree::class)) { |
||
| 92 | singleton(SiteTree::class)->extend('modelascontrollerInit', $this); |
||
| 93 | } |
||
| 94 | parent::init(); |
||
| 95 | } |
||
| 96 | |||
| 97 | /** |
||
| 98 | * Backslashes in fully qualified class names (e.g. NameSpaced\ClassName) |
||
| 99 | * kills both requests (i.e. URIs) and XML (invalid character in a tag name) |
||
| 100 | * So we'll replace them with a hyphen (-), as it's also unambiguious |
||
| 101 | * in both cases (invalid in a php class name, and safe in an xml tag name) |
||
| 102 | * |
||
| 103 | * @param string $classname |
||
| 104 | * @return string 'escaped' class name |
||
| 105 | */ |
||
| 106 | protected function sanitiseClassName($className) |
||
| 107 | { |
||
| 108 | return str_replace('\\', '-', $className); |
||
| 109 | } |
||
| 110 | |||
| 111 | /** |
||
| 112 | * Convert hyphen escaped class names back into fully qualified |
||
| 113 | * PHP safe variant. |
||
| 114 | * |
||
| 115 | * @param string $classname |
||
| 116 | * @return string syntactically valid classname |
||
| 117 | */ |
||
| 118 | protected function unsanitiseClassName($className) |
||
| 119 | { |
||
| 120 | return str_replace('-', '\\', $className); |
||
| 121 | } |
||
| 122 | |||
| 123 | /** |
||
| 124 | * This handler acts as the switchboard for the controller. |
||
| 125 | * Since no $Action url-param is set, all requests are sent here. |
||
| 126 | */ |
||
| 127 | public function index(HTTPRequest $request) |
||
| 128 | { |
||
| 129 | $className = $this->unsanitiseClassName($request->param('ClassName')); |
||
| 130 | $id = $request->param('ID') ?: null; |
||
| 131 | $relation = $request->param('Relation') ?: null; |
||
| 132 | |||
| 133 | // Check input formats |
||
| 134 | if (!class_exists($className)) { |
||
| 135 | return $this->notFound(); |
||
| 136 | } |
||
| 137 | if ($id && !is_numeric($id)) { |
||
| 138 | return $this->notFound(); |
||
| 139 | } |
||
| 140 | if ($relation |
||
| 141 | && !preg_match('/^[a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*$/', $relation) |
||
| 142 | ) { |
||
| 143 | return $this->notFound(); |
||
| 144 | } |
||
| 145 | |||
| 146 | // if api access is disabled, don't proceed |
||
| 147 | $apiAccess = Config::inst()->get($className, 'api_access'); |
||
| 148 | if (!$apiAccess) { |
||
| 149 | return $this->permissionFailure(); |
||
| 150 | } |
||
| 151 | |||
| 152 | // authenticate through HTTP BasicAuth |
||
| 153 | $this->member = $this->authenticate(); |
||
| 154 | |||
| 155 | // handle different HTTP verbs |
||
| 156 | if ($this->request->isGET() || $this->request->isHEAD()) { |
||
| 157 | return $this->getHandler($className, $id, $relation); |
||
| 158 | } |
||
| 159 | |||
| 160 | if ($this->request->isPOST()) { |
||
| 161 | return $this->postHandler($className, $id, $relation); |
||
| 162 | } |
||
| 163 | |||
| 164 | if ($this->request->isPUT()) { |
||
| 165 | return $this->putHandler($className, $id, $relation); |
||
| 166 | } |
||
| 167 | |||
| 168 | if ($this->request->isDELETE()) { |
||
| 169 | return $this->deleteHandler($className, $id, $relation); |
||
| 170 | } |
||
| 171 | |||
| 172 | // if no HTTP verb matches, return error |
||
| 173 | return $this->methodNotAllowed(); |
||
| 174 | } |
||
| 175 | |||
| 176 | /** |
||
| 177 | * Handler for object read. |
||
| 178 | * |
||
| 179 | * The data object will be returned in the following format: |
||
| 180 | * |
||
| 181 | * <ClassName> |
||
| 182 | * <FieldName>Value</FieldName> |
||
| 183 | * ... |
||
| 184 | * <HasOneRelName id="ForeignID" href="LinkToForeignRecordInAPI" /> |
||
| 185 | * ... |
||
| 186 | * <HasManyRelName> |
||
| 187 | * <ForeignClass id="ForeignID" href="LinkToForeignRecordInAPI" /> |
||
| 188 | * <ForeignClass id="ForeignID" href="LinkToForeignRecordInAPI" /> |
||
| 189 | * </HasManyRelName> |
||
| 190 | * ... |
||
| 191 | * <ManyManyRelName> |
||
| 192 | * <ForeignClass id="ForeignID" href="LinkToForeignRecordInAPI" /> |
||
| 193 | * <ForeignClass id="ForeignID" href="LinkToForeignRecordInAPI" /> |
||
| 194 | * </ManyManyRelName> |
||
| 195 | * </ClassName> |
||
| 196 | * |
||
| 197 | * Access is controlled by two variables: |
||
| 198 | * |
||
| 199 | * - static $api_access must be set. This enables the API on a class by class basis |
||
| 200 | * - $obj->canView() must return true. This lets you implement record-level security |
||
| 201 | * |
||
| 202 | * @todo Access checking |
||
| 203 | * |
||
| 204 | * @param string $className |
||
| 205 | * @param Int $id |
||
| 206 | * @param string $relation |
||
| 207 | * @return string The serialized representation of the requested object(s) - usually XML or JSON. |
||
| 208 | */ |
||
| 209 | protected function getHandler($className, $id, $relationName) |
||
| 210 | { |
||
| 211 | $sort = ''; |
||
| 212 | |||
| 213 | if ($this->request->getVar('sort')) { |
||
| 214 | $dir = $this->request->getVar('dir'); |
||
| 215 | $sort = array($this->request->getVar('sort') => ($dir ? $dir : 'ASC')); |
||
| 216 | } |
||
| 217 | |||
| 218 | $limit = array( |
||
| 219 | 'start' => $this->request->getVar('start'), |
||
| 220 | 'limit' => $this->request->getVar('limit') |
||
| 221 | ); |
||
| 222 | |||
| 223 | $params = $this->request->getVars(); |
||
| 224 | |||
| 225 | $responseFormatter = $this->getResponseDataFormatter($className); |
||
| 226 | if (!$responseFormatter) { |
||
| 227 | return $this->unsupportedMediaType(); |
||
| 228 | } |
||
| 229 | |||
| 230 | // $obj can be either a DataObject or a SS_List, |
||
| 231 | // depending on the request |
||
| 232 | if ($id) { |
||
| 233 | // Format: /api/v1/<MyClass>/<ID> |
||
| 234 | $obj = $this->getObjectQuery($className, $id, $params)->First(); |
||
| 235 | if (!$obj) { |
||
| 236 | return $this->notFound(); |
||
| 237 | } |
||
| 238 | if (!$obj->canView($this->getMember())) { |
||
| 239 | return $this->permissionFailure(); |
||
| 240 | } |
||
| 241 | |||
| 242 | // Format: /api/v1/<MyClass>/<ID>/<Relation> |
||
| 243 | if ($relationName) { |
||
| 244 | $obj = $this->getObjectRelationQuery($obj, $params, $sort, $limit, $relationName); |
||
| 245 | if (!$obj) { |
||
| 246 | return $this->notFound(); |
||
| 247 | } |
||
| 248 | |||
| 249 | // TODO Avoid creating data formatter again for relation class (see above) |
||
| 250 | $responseFormatter = $this->getResponseDataFormatter($obj->dataClass()); |
||
| 251 | } |
||
| 252 | } else { |
||
| 253 | // Format: /api/v1/<MyClass> |
||
| 254 | $obj = $this->getObjectsQuery($className, $params, $sort, $limit); |
||
| 255 | } |
||
| 256 | |||
| 257 | $this->getResponse()->addHeader('Content-Type', $responseFormatter->getOutputContentType()); |
||
| 258 | |||
| 259 | $rawFields = $this->request->getVar('fields'); |
||
| 260 | $fields = $rawFields ? explode(',', $rawFields) : null; |
||
| 261 | |||
| 262 | if ($obj instanceof SS_List) { |
||
| 263 | $objs = ArrayList::create($obj->toArray()); |
||
| 264 | foreach ($objs as $obj) { |
||
| 265 | if (!$obj->canView($this->getMember())) { |
||
| 266 | $objs->remove($obj); |
||
| 267 | } |
||
| 268 | } |
||
| 269 | $responseFormatter->setTotalSize($objs->count()); |
||
| 270 | return $responseFormatter->convertDataObjectSet($objs, $fields); |
||
| 271 | } |
||
| 272 | |||
| 273 | if (!$obj) { |
||
| 274 | $responseFormatter->setTotalSize(0); |
||
| 275 | return $responseFormatter->convertDataObjectSet(new ArrayList(), $fields); |
||
| 276 | } |
||
| 277 | |||
| 278 | return $responseFormatter->convertDataObject($obj, $fields); |
||
| 279 | } |
||
| 280 | |||
| 281 | /** |
||
| 282 | * Uses the default {@link SearchContext} specified through |
||
| 283 | * {@link DataObject::getDefaultSearchContext()} to augument |
||
| 284 | * an existing query object (mostly a component query from {@link DataObject}) |
||
| 285 | * with search clauses. |
||
| 286 | * |
||
| 287 | * @todo Allow specifying of different searchcontext getters on model-by-model basis |
||
| 288 | * |
||
| 289 | * @param string $className |
||
| 290 | * @param array $params |
||
| 291 | * @return SS_List |
||
| 292 | */ |
||
| 293 | protected function getSearchQuery( |
||
| 294 | $className, |
||
| 295 | $params = null, |
||
| 296 | $sort = null, |
||
| 297 | $limit = null, |
||
| 298 | $existingQuery = null |
||
| 299 | ) { |
||
| 300 | if (singleton($className)->hasMethod('getRestfulSearchContext')) { |
||
| 301 | $searchContext = singleton($className)->{'getRestfulSearchContext'}(); |
||
| 302 | } else { |
||
| 303 | $searchContext = singleton($className)->getDefaultSearchContext(); |
||
| 304 | } |
||
| 305 | return $searchContext->getQuery($params, $sort, $limit, $existingQuery); |
||
| 306 | } |
||
| 307 | |||
| 308 | /** |
||
| 309 | * Returns a dataformatter instance based on the request |
||
| 310 | * extension or mimetype. Falls back to {@link self::$default_extension}. |
||
| 311 | * |
||
| 312 | * @param boolean $includeAcceptHeader Determines wether to inspect and prioritize any HTTP Accept headers |
||
| 313 | * @param string Classname of a DataObject |
||
| 314 | * @return DataFormatter |
||
| 315 | */ |
||
| 316 | protected function getDataFormatter($includeAcceptHeader = false, $className = null) |
||
| 317 | { |
||
| 318 | $extension = $this->request->getExtension(); |
||
| 319 | $contentTypeWithEncoding = $this->request->getHeader('Content-Type'); |
||
| 320 | preg_match('/([^;]*)/', $contentTypeWithEncoding, $contentTypeMatches); |
||
| 321 | $contentType = $contentTypeMatches[0]; |
||
| 322 | $accept = $this->request->getHeader('Accept'); |
||
| 323 | $mimetypes = $this->request->getAcceptMimetypes(); |
||
| 324 | if (!$className) { |
||
| 325 | $className = $this->unsanitiseClassName($this->request->param('ClassName')); |
||
| 326 | } |
||
| 327 | |||
| 328 | // get formatter |
||
| 329 | if (!empty($extension)) { |
||
| 330 | $formatter = DataFormatter::for_extension($extension); |
||
| 331 | } elseif ($includeAcceptHeader && !empty($accept) && $accept != '*/*') { |
||
| 332 | $formatter = DataFormatter::for_mimetypes($mimetypes); |
||
| 333 | if (!$formatter) { |
||
| 334 | $formatter = DataFormatter::for_extension(self::$default_extension); |
||
| 335 | } |
||
| 336 | } elseif (!empty($contentType)) { |
||
| 337 | $formatter = DataFormatter::for_mimetype($contentType); |
||
| 338 | } else { |
||
| 339 | $formatter = DataFormatter::for_extension(self::$default_extension); |
||
| 340 | } |
||
| 341 | |||
| 342 | if (!$formatter) { |
||
| 343 | return false; |
||
| 344 | } |
||
| 345 | |||
| 346 | // set custom fields |
||
| 347 | if ($customAddFields = $this->request->getVar('add_fields')) { |
||
| 348 | $formatter->setCustomAddFields(explode(',', $customAddFields)); |
||
| 349 | } |
||
| 350 | if ($customFields = $this->request->getVar('fields')) { |
||
| 351 | $formatter->setCustomFields(explode(',', $customFields)); |
||
| 352 | } |
||
| 353 | $formatter->setCustomRelations($this->getAllowedRelations($className)); |
||
| 354 | |||
| 355 | $apiAccess = Config::inst()->get($className, 'api_access'); |
||
| 356 | if (is_array($apiAccess)) { |
||
| 357 | $formatter->setCustomAddFields( |
||
| 358 | array_intersect((array)$formatter->getCustomAddFields(), (array)$apiAccess['view']) |
||
| 359 | ); |
||
| 360 | View Code Duplication | if ($formatter->getCustomFields()) { |
|
| 361 | $formatter->setCustomFields( |
||
| 362 | array_intersect((array)$formatter->getCustomFields(), (array)$apiAccess['view']) |
||
| 363 | ); |
||
| 364 | } else { |
||
| 365 | $formatter->setCustomFields((array)$apiAccess['view']); |
||
| 366 | } |
||
| 367 | View Code Duplication | if ($formatter->getCustomRelations()) { |
|
| 368 | $formatter->setCustomRelations( |
||
| 369 | array_intersect((array)$formatter->getCustomRelations(), (array)$apiAccess['view']) |
||
| 370 | ); |
||
| 371 | } else { |
||
| 372 | $formatter->setCustomRelations((array)$apiAccess['view']); |
||
| 373 | } |
||
| 374 | } |
||
| 375 | |||
| 376 | // set relation depth |
||
| 377 | $relationDepth = $this->request->getVar('relationdepth'); |
||
| 378 | if (is_numeric($relationDepth)) { |
||
| 379 | $formatter->relationDepth = (int)$relationDepth; |
||
| 380 | } |
||
| 381 | |||
| 382 | return $formatter; |
||
| 383 | } |
||
| 384 | |||
| 385 | /** |
||
| 386 | * @param string Classname of a DataObject |
||
| 387 | * @return DataFormatter |
||
| 388 | */ |
||
| 389 | protected function getRequestDataFormatter($className = null) |
||
| 390 | { |
||
| 391 | return $this->getDataFormatter(false, $className); |
||
| 392 | } |
||
| 393 | |||
| 394 | /** |
||
| 395 | * @param string Classname of a DataObject |
||
| 396 | * @return DataFormatter |
||
| 397 | */ |
||
| 398 | protected function getResponseDataFormatter($className = null) |
||
| 399 | { |
||
| 400 | return $this->getDataFormatter(true, $className); |
||
| 401 | } |
||
| 402 | |||
| 403 | /** |
||
| 404 | * Handler for object delete |
||
| 405 | */ |
||
| 406 | protected function deleteHandler($className, $id) |
||
| 407 | { |
||
| 408 | $obj = DataObject::get_by_id($className, $id); |
||
| 409 | if (!$obj) { |
||
| 410 | return $this->notFound(); |
||
| 411 | } |
||
| 412 | if (!$obj->canDelete($this->getMember())) { |
||
| 413 | return $this->permissionFailure(); |
||
| 414 | } |
||
| 415 | |||
| 416 | $obj->delete(); |
||
| 417 | |||
| 418 | $this->getResponse()->setStatusCode(204); // No Content |
||
| 419 | return true; |
||
| 420 | } |
||
| 421 | |||
| 422 | /** |
||
| 423 | * Handler for object write |
||
| 424 | */ |
||
| 425 | protected function putHandler($className, $id) |
||
| 426 | { |
||
| 427 | $obj = DataObject::get_by_id($className, $id); |
||
| 428 | if (!$obj) { |
||
| 429 | return $this->notFound(); |
||
| 430 | } |
||
| 431 | |||
| 432 | if (!$obj->canEdit($this->getMember())) { |
||
| 433 | return $this->permissionFailure(); |
||
| 434 | } |
||
| 435 | |||
| 436 | $reqFormatter = $this->getRequestDataFormatter($className); |
||
| 437 | if (!$reqFormatter) { |
||
| 438 | return $this->unsupportedMediaType(); |
||
| 439 | } |
||
| 440 | |||
| 441 | $responseFormatter = $this->getResponseDataFormatter($className); |
||
| 442 | if (!$responseFormatter) { |
||
| 443 | return $this->unsupportedMediaType(); |
||
| 444 | } |
||
| 445 | |||
| 446 | /** @var DataObject|string */ |
||
| 447 | $obj = $this->updateDataObject($obj, $reqFormatter); |
||
| 448 | if (is_string($obj)) { |
||
| 449 | return $obj; |
||
| 450 | } |
||
| 451 | |||
| 452 | $this->getResponse()->setStatusCode(200); // Success |
||
| 453 | $this->getResponse()->addHeader('Content-Type', $responseFormatter->getOutputContentType()); |
||
| 454 | |||
| 455 | // Append the default extension for the output format to the Location header |
||
| 456 | // or else we'll use the default (XML) |
||
| 457 | $types = $responseFormatter->supportedExtensions(); |
||
| 458 | $type = ''; |
||
| 459 | if (count($types)) { |
||
| 460 | $type = ".{$types[0]}"; |
||
| 461 | } |
||
| 462 | |||
| 463 | $urlSafeClassName = $this->sanitiseClassName(get_class($obj)); |
||
| 464 | $apiBase = $this->config()->api_base; |
||
| 465 | $objHref = Director::absoluteURL($apiBase . "$urlSafeClassName/$obj->ID" . $type); |
||
| 466 | $this->getResponse()->addHeader('Location', $objHref); |
||
| 467 | |||
| 468 | return $responseFormatter->convertDataObject($obj); |
||
| 469 | } |
||
| 470 | |||
| 471 | /** |
||
| 472 | * Handler for object append / method call. |
||
| 473 | * |
||
| 474 | * @todo Posting to an existing URL (without a relation) |
||
| 475 | * current resolves in creatig a new element, |
||
| 476 | * rather than a "Conflict" message. |
||
| 477 | */ |
||
| 478 | protected function postHandler($className, $id, $relation) |
||
| 479 | { |
||
| 480 | if ($id) { |
||
| 481 | if (!$relation) { |
||
| 482 | $this->response->setStatusCode(409); |
||
| 483 | return 'Conflict'; |
||
| 484 | } |
||
| 485 | |||
| 486 | $obj = DataObject::get_by_id($className, $id); |
||
| 487 | if (!$obj) { |
||
| 488 | return $this->notFound(); |
||
| 489 | } |
||
| 490 | |||
| 491 | if (!$obj->hasMethod($relation)) { |
||
| 492 | return $this->notFound(); |
||
| 493 | } |
||
| 494 | |||
| 495 | if (!Config::inst()->get($className, 'allowed_actions') || |
||
| 496 | !in_array($relation, Config::inst()->get($className, 'allowed_actions'))) { |
||
| 497 | return $this->permissionFailure(); |
||
| 498 | } |
||
| 499 | |||
| 500 | $obj->$relation(); |
||
| 501 | |||
| 502 | $this->getResponse()->setStatusCode(204); // No Content |
||
| 503 | return true; |
||
| 504 | } |
||
| 505 | |||
| 506 | if (!singleton($className)->canCreate($this->getMember())) { |
||
| 507 | return $this->permissionFailure(); |
||
| 508 | } |
||
| 509 | $obj = new $className(); |
||
| 510 | |||
| 511 | $reqFormatter = $this->getRequestDataFormatter($className); |
||
| 512 | if (!$reqFormatter) { |
||
| 513 | return $this->unsupportedMediaType(); |
||
| 514 | } |
||
| 515 | |||
| 516 | $responseFormatter = $this->getResponseDataFormatter($className); |
||
| 517 | |||
| 518 | /** @var DataObject|string $obj */ |
||
| 519 | $obj = $this->updateDataObject($obj, $reqFormatter); |
||
| 520 | if (is_string($obj)) { |
||
| 521 | return $obj; |
||
| 522 | } |
||
| 523 | |||
| 524 | $this->getResponse()->setStatusCode(201); // Created |
||
| 525 | $this->getResponse()->addHeader('Content-Type', $responseFormatter->getOutputContentType()); |
||
| 526 | |||
| 527 | // Append the default extension for the output format to the Location header |
||
| 528 | // or else we'll use the default (XML) |
||
| 529 | $types = $responseFormatter->supportedExtensions(); |
||
| 530 | $type = ''; |
||
| 531 | if (count($types)) { |
||
| 532 | $type = ".{$types[0]}"; |
||
| 533 | } |
||
| 534 | |||
| 535 | $urlSafeClassName = $this->sanitiseClassName(get_class($obj)); |
||
| 536 | $apiBase = $this->config()->api_base; |
||
| 537 | $objHref = Director::absoluteURL($apiBase . "$urlSafeClassName/$obj->ID" . $type); |
||
| 538 | $this->getResponse()->addHeader('Location', $objHref); |
||
| 539 | |||
| 540 | return $responseFormatter->convertDataObject($obj); |
||
| 541 | } |
||
| 542 | |||
| 543 | /** |
||
| 544 | * Converts either the given HTTP Body into an array |
||
| 545 | * (based on the DataFormatter instance), or returns |
||
| 546 | * the POST variables. |
||
| 547 | * Automatically filters out certain critical fields |
||
| 548 | * that shouldn't be set by the client (e.g. ID). |
||
| 549 | * |
||
| 550 | * @param DataObject $obj |
||
| 551 | * @param DataFormatter $formatter |
||
| 552 | * @return DataObject|string The passed object, or "No Content" if incomplete input data is provided |
||
| 553 | */ |
||
| 554 | protected function updateDataObject($obj, $formatter) |
||
| 555 | { |
||
| 556 | // if neither an http body nor POST data is present, return error |
||
| 557 | $body = $this->request->getBody(); |
||
| 558 | if (!$body && !$this->request->postVars()) { |
||
| 559 | $this->getResponse()->setStatusCode(204); // No Content |
||
| 560 | return 'No Content'; |
||
| 561 | } |
||
| 562 | |||
| 563 | if (!empty($body)) { |
||
| 564 | $data = $formatter->convertStringToArray($body); |
||
| 565 | } else { |
||
| 566 | // assume application/x-www-form-urlencoded which is automatically parsed by PHP |
||
| 567 | $data = $this->request->postVars(); |
||
| 568 | } |
||
| 569 | |||
| 570 | // @todo Disallow editing of certain keys in database |
||
| 571 | $data = array_diff_key($data, ['ID', 'Created']); |
||
| 572 | |||
| 573 | $className = $this->unsanitiseClassName($this->request->param('ClassName')); |
||
| 574 | $apiAccess = singleton($className)->config()->api_access; |
||
| 575 | if (is_array($apiAccess) && isset($apiAccess['edit'])) { |
||
| 576 | $data = array_intersect_key($data, array_combine($apiAccess['edit'], $apiAccess['edit'])); |
||
| 577 | } |
||
| 578 | |||
| 579 | $obj->update($data); |
||
| 580 | $obj->write(); |
||
| 581 | |||
| 582 | return $obj; |
||
| 583 | } |
||
| 584 | |||
| 585 | /** |
||
| 586 | * Gets a single DataObject by ID, |
||
| 587 | * through a request like /api/v1/<MyClass>/<MyID> |
||
| 588 | * |
||
| 589 | * @param string $className |
||
| 590 | * @param int $id |
||
| 591 | * @param array $params |
||
| 592 | * @return DataList |
||
| 593 | */ |
||
| 594 | protected function getObjectQuery($className, $id, $params) |
||
| 597 | } |
||
| 598 | |||
| 599 | /** |
||
| 600 | * @param DataObject $obj |
||
| 601 | * @param array $params |
||
| 602 | * @param int|array $sort |
||
| 603 | * @param int|array $limit |
||
| 604 | * @return SQLQuery |
||
| 605 | */ |
||
| 606 | protected function getObjectsQuery($className, $params, $sort, $limit) |
||
| 609 | } |
||
| 610 | |||
| 611 | |||
| 612 | /** |
||
| 613 | * @param DataObject $obj |
||
| 614 | * @param array $params |
||
| 615 | * @param int|array $sort |
||
| 616 | * @param int|array $limit |
||
| 617 | * @param string $relationName |
||
| 618 | * @return SQLQuery|boolean |
||
| 619 | */ |
||
| 620 | protected function getObjectRelationQuery($obj, $params, $sort, $limit, $relationName) |
||
| 621 | { |
||
| 622 | // The relation method will return a DataList, that getSearchQuery subsequently manipulates |
||
| 623 | if ($obj->hasMethod($relationName)) { |
||
| 624 | // $this->HasOneName() will return a dataobject or null, neither |
||
| 625 | // of which helps us get the classname in a consistent fashion. |
||
| 626 | // So we must use a way that is reliable. |
||
| 627 | if ($relationClass = DataObject::getSchema()->hasOneComponent(get_class($obj), $relationName)) { |
||
| 628 | $joinField = $relationName . 'ID'; |
||
| 629 | // Again `byID` will return the wrong type for our purposes. So use `byIDs` |
||
| 630 | $list = DataList::create($relationClass)->byIDs([$obj->$joinField]); |
||
| 631 | } else { |
||
| 632 | $list = $obj->$relationName(); |
||
| 633 | } |
||
| 634 | |||
| 635 | $apiAccess = Config::inst()->get($list->dataClass(), 'api_access'); |
||
| 636 | |||
| 637 | |||
| 638 | if (!$apiAccess) { |
||
| 639 | return false; |
||
| 640 | } |
||
| 641 | |||
| 642 | return $this->getSearchQuery($list->dataClass(), $params, $sort, $limit, $list); |
||
| 643 | } |
||
| 644 | } |
||
| 645 | |||
| 646 | protected function permissionFailure() |
||
| 647 | { |
||
| 648 | // return a 401 |
||
| 649 | $this->getResponse()->setStatusCode(401); |
||
| 650 | $this->getResponse()->addHeader('WWW-Authenticate', 'Basic realm="API Access"'); |
||
| 651 | $this->getResponse()->addHeader('Content-Type', 'text/plain'); |
||
| 652 | return "You don't have access to this item through the API."; |
||
| 653 | } |
||
| 654 | |||
| 655 | protected function notFound() |
||
| 656 | { |
||
| 657 | // return a 404 |
||
| 658 | $this->getResponse()->setStatusCode(404); |
||
| 659 | $this->getResponse()->addHeader('Content-Type', 'text/plain'); |
||
| 660 | return "That object wasn't found"; |
||
| 661 | } |
||
| 662 | |||
| 663 | protected function methodNotAllowed() |
||
| 664 | { |
||
| 665 | $this->getResponse()->setStatusCode(405); |
||
| 666 | $this->getResponse()->addHeader('Content-Type', 'text/plain'); |
||
| 667 | return "Method Not Allowed"; |
||
| 668 | } |
||
| 669 | |||
| 670 | protected function unsupportedMediaType() |
||
| 671 | { |
||
| 672 | $this->response->setStatusCode(415); // Unsupported Media Type |
||
| 673 | $this->getResponse()->addHeader('Content-Type', 'text/plain'); |
||
| 674 | return "Unsupported Media Type"; |
||
| 675 | } |
||
| 676 | |||
| 677 | /** |
||
| 678 | * A function to authenticate a user |
||
| 679 | * |
||
| 680 | * @return Member|false the logged in member |
||
| 681 | */ |
||
| 682 | protected function authenticate() |
||
| 688 | } |
||
| 689 | |||
| 690 | /** |
||
| 691 | * Return only relations which have $api_access enabled. |
||
| 692 | * @todo Respect field level permissions once they are available in core |
||
| 693 | * |
||
| 694 | * @param string $class |
||
| 695 | * @param Member $member |
||
| 696 | * @return array |
||
| 697 | */ |
||
| 698 | protected function getAllowedRelations($class, $member = null) |
||
| 699 | { |
||
| 700 | $allowedRelations = []; |
||
| 701 | $obj = singleton($class); |
||
| 702 | $relations = (array)$obj->hasOne() + (array)$obj->hasMany() + (array)$obj->manyMany(); |
||
| 703 | if ($relations) { |
||
| 704 | foreach ($relations as $relName => $relClass) { |
||
| 705 | //remove dot notation from relation names |
||
| 706 | $parts = explode('.', $relClass); |
||
| 707 | $relClass = array_shift($parts); |
||
| 708 | if (Config::inst()->get($relClass, 'api_access')) { |
||
| 709 | $allowedRelations[] = $relName; |
||
| 710 | } |
||
| 711 | } |
||
| 712 | } |
||
| 713 | return $allowedRelations; |
||
| 714 | } |
||
| 715 | |||
| 716 | /** |
||
| 717 | * Get the current Member, if available |
||
| 718 | * |
||
| 719 | * @return Member|null |
||
| 720 | */ |
||
| 721 | protected function getMember() |
||
| 724 | } |
||
| 725 | } |
||
| 726 |
Loading history...
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths