View GitHub Repository silverstripe-restfulserver

Schedule Inspection
Subscribe

Code Duplication    Length = 5-5 lines in 2 locations

src/DataFormatter/JSONDataFormatter.php 1 location

@@ 95-99 (lines=5) @@
92 
                }
93 

                                

                                                            

                                    94
                                    
                                    
                $fieldName = $relName . 'ID';

                                

                                                            

                                    95
                                    
                                    
                if ($obj->$fieldName) {

                                

                                                            

                                    96
                                    
                                    
                    $href = Director::absoluteURL($this->config()->api_base . "$relClass/" . $obj->$fieldName);

                                

                                                            

                                    97
                                    
                                    
                } else {

                                

                                                            

                                    98
                                    
                                    
                    $href = Director::absoluteURL($this->config()->api_base . "$className/$id/$relName");

                                

                                                            

                                    99
                                    
                                    
                }

                                

                                                            

                                    100
                                    
                                    
                $serobj->$relName = ArrayData::array_to_object(array(

                                

                                                            

                                    101
                                    
                                    
                    "className" => $relClass,

                                

                                                            

                                    102
                                    
                                    
                    "href" => "$href.json",

                                

                                                                        

                

                                                            

                    
src/DataFormatter/XMLDataFormatter.php 1 location

                

                

                    

                                                
                                                    

                                
                                
                                    @@ 104-108 (lines=5) @@
                                
                            


                                                            

                                    101
                                    
                                    
                }

                                

                                                            

                                    102
                                    
                                    

                                

                                                            

                                    103
                                    
                                    
                $fieldName = $relName . 'ID';

                                

                                                            

                                    104
                                    
                                    
                if ($obj->$fieldName) {

                                

                                                            

                                    105
                                    
                                    
                    $href = Director::absoluteURL($this->config()->api_base . "$relClass/" . $obj->$fieldName);

                                

                                                            

                                    106
                                    
                                    
                } else {

                                

                                                            

                                    107
                                    
                                    
                    $href = Director::absoluteURL($this->config()->api_base . "$className/$id/$relName");

                                

                                                            

                                    108
                                    
                                    
                }

                                

                                                            

                                    109
                                    
                                    
                $xml .= "<$relName linktype=\"has_one\" href=\"$href.xml\" id=\"" . $obj->$fieldName

                                

                                                            

                                    110
                                    
                                    
                    . "\"></$relName>\n";

                                

                                                            

                                    111
                                    
                                    
            }