RegistryPageTestContact::getSearchFields() - Code Metrics - Inspection of "Merge pull request #11 from helpfulrobot/add-stand..." - silverstripe/silverstripe-registry - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e3c734...8f98ed )

by Daniel

created 2015-11-23 17:50 UTC

RegistryPageTestContact::getSearchFields() A

↳ Parent: RegistryPageTestContact

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	6
rs	9.4286
cc	1
eloc	4
nc	1
nop	0

<?php
class RegistryPageTestContact extends DataObject implements RegistryDataInterface {
namespace YourVendor;

class YourClass { }

	private static $db = array(

		'FirstName' => 'Varchar(50)',
		'Surname' => 'Varchar(50)'
	);

	private static $summary_fields = array(

		'FirstName' => 'First name',
		'Surname' => 'Surname'
	);

	public function getSearchFields() {
		return new FieldList(
			new TextField('FirstName', 'First name'),
			new TextField('Surname', 'Surname')
		);
	}

}
// Incorrect placement according to PSR2
class MyClass
{
    public function foo()
    {

    }
    // This blank line is not allowed.

}

// Correct
class MyClass
{
    public function foo()
    {

    } // No blank lines after this line.
}


1			<?php
2			class RegistryPageTestContact extends DataObject implements RegistryDataInterface {
			0 ignored issues – show Coding Style Compatibility introduced 2015-11-21 06:33 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history... Coding Style introduced 2015-11-21 06:33 UTC by Report Bug Copy Issue Report As per PSR2, the opening brace for this class should be on a new line. Loading history...
3
4			private static $db = array(
			0 ignored issues – show Comprehensibility introduced 2015-11-21 06:33 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2015-11-21 06:33 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
5			'FirstName' => 'Varchar(50)',
6			'Surname' => 'Varchar(50)'
7			);
8
9			private static $summary_fields = array(
			0 ignored issues – show Comprehensibility introduced 2015-11-21 06:33 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2015-11-21 06:33 UTC by Report Bug Copy Issue Report The property `$summary_fields` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
10			'FirstName' => 'First name',
11			'Surname' => 'Surname'
12			);
13
14			public function getSearchFields() {
15			return new FieldList(
16			new TextField('FirstName', 'First name'),
17			new TextField('Surname', 'Surname')
18			);
19			}
20
21			}
			0 ignored issues – show Coding Style introduced 2015-11-21 06:33 UTC by Report Bug Copy Issue Report According to PSR2, the closing brace of classes should be placed on the next line directly after the body. Below you find some examples: // Incorrect placement according to PSR2 class MyClass { public function foo() { } // This blank line is not allowed. } // Correct class MyClass { public function foo() { } // No blank lines after this line. } Loading history...
22

silverstripe / silverstripe-registry

Push — master ( e3c734...8f98ed )

RegistryPageTestContact::getSearchFields() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like