+global\PostgreSQLDatabaseTest::testReadOnlyTransaction()

Complexity

Conditions	6
Paths	4

Size

Total Lines	38
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
B		0	35	6

<?php

namespace SilverStripe\PostgreSQL\Tests;

use SilverStripe\Dev\SapphireTest;
use SilverStripe\ORM\DataObject;
use SilverStripe\ORM\DB;
use SilverStripe\PostgreSQL\PostgreSQLDatabase;

/**
 * @package postgresql
 * @subpackage tests
 */
class PostgreSQLDatabaseTest extends SapphireTest
{
    protected $usesDatabase = true;

    public function testReadOnlyTransaction()
    {
        if (DB::get_conn()->supportsTransactions() == true

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            && DB::get_conn() instanceof PostgreSQLDatabase
        ) {
            $page=new Page();

The type SilverStripe\PostgreSQL\Tests\Page was not found. Maybe you did not declare it correctly or list all dependencies?

            $page->Title='Read only success';
            $page->write();

            DB::get_conn()->transactionStart('READ ONLY');

            try {
                $page=new Page();
                $page->Title='Read only page failed';
                $page->write();
            } catch (Exception $e) {

The type SilverStripe\PostgreSQL\Tests\Exception was not found. Did you mean Exception? If so, make sure to prefix the type with \.

                //could not write this record
                //We need to do a rollback or a commit otherwise we'll get error messages
                DB::get_conn()->transactionRollback();
            }

            DB::get_conn()->transactionEnd();

            DataObject::flush_and_destroy_cache();

            $success=DataObject::get('Page', "\"Title\"='Read only success'");
            $fail=DataObject::get('Page', "\"Title\"='Read only page failed'");

            //This page should be in the system
            $this->assertTrue(is_object($success) && $success->exists());

            //This page should NOT exist, we had 'read only' permissions
            $this->assertFalse(is_object($fail) && $fail->exists());
        } else {
            $this->markTestSkipped('Current database is not PostgreSQL');
        }
    }
}