MultiFormObjectDecoratorTest

Complexity

Total Complexity

2

Size/Duplication

Total Lines	35
Duplicated Lines	57.14 %

Coupling/Cohesion

Components	1
Dependencies	4

2 Methods

Rating	Name	Duplication	Size	Complexity
A	testTemporaryDataFilteredQuery()	10	10	1
A	testTemporaryDataQuery()	10	10	1

<?php
class MultiFormObjectDecoratorTest extends SapphireTest {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

	protected static $fixture_file = 'MultiFormObjectDecoratorTest.yml';

	protected $requiredExtensions = array(
		'MultiFormObjectDecorator_DataObject' => array('MultiFormObjectDecorator')
	);

	protected $extraDataObjects = array(
		'MultiFormObjectDecorator_DataObject'
	);

	public function testTemporaryDataFilteredQuery() {

This method seems to be duplicated in your project.

		$records = MultiFormObjectDecorator_DataObject::get()
			->map('Name')
			->toArray();

		$this->assertContains('Test 1', $records);
		$this->assertContains('Test 2', $records);
		$this->assertNotContains('Test 3', $records);

	}

	public function testTemporaryDataQuery() {

This method seems to be duplicated in your project.

		$records = MultiFormObjectDecorator_DataObject::get()
			->filter(array('MultiFormIsTemporary' => 1))
			->map('Name')
			->toArray();

		$this->assertNotContains('Test 1', $records);
		$this->assertNotContains('Test 2', $records);
		$this->assertContains('Test 3', $records);
	}

}

class MultiFormObjectDecorator_DataObject extends DataObject {

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

	private static $db = array(

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

		'Name' => 'Varchar'
	);

}