silverstripe / silverstripe-mfa

tests/php/Service/MethodRegistryTest.php

<?php

namespace SilverStripe\MFA\Tests\Service;

use SilverStripe\Core\Config\Config;
use SilverStripe\Dev\SapphireTest;
use SilverStripe\MFA\Service\MethodRegistry;
use SilverStripe\MFA\Tests\Stub\BasicMath\Method;
use SilverStripe\MFA\Tests\Stub\DuplicatedBasicMath;
use SilverStripe\Security\Member;
use UnexpectedValueException;

class MethodRegistryTest extends SapphireTest
{
    public function testGetAllMethodsReturnsRegisteredMethods()
    {
        Config::modify()->set(MethodRegistry::class, 'methods', [Method::class]);
        $registry = MethodRegistry::singleton();
        $methods = $registry->getMethods();

        $this->assertCount(1, $methods);
        $this->assertInstanceOf(Method::class, reset($methods));

It seems like $methods can also be of type Countable and Traversable; however, parameter $array of reset() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @expectedException UnexpectedValueException
     * phpcs:disable
     * @expectedExceptionMessage Given method "SilverStripe\Security\Member" does not implement SilverStripe\MFA\Method\MethodInterface
     * phpcs:enable
     */
    public function testInvalidMethodsThrowExceptions()
    {
        Config::modify()->set(MethodRegistry::class, 'methods', [Member::class]);
        $registry = MethodRegistry::singleton();
        $registry->getMethods();
    }

    /**
     * @expectedException UnexpectedValueException
     * phpcs:disable
     * @expectedExceptionMessage Cannot register MFA methods more than once. Check your config: SilverStripe\MFA\Tests\Stub\BasicMath\Method
     * phpcs:enable
     */
    public function testRegisteringMethodMultipleTimesThrowsException()
    {
        Config::modify()->set(MethodRegistry::class, 'methods', [
            Method::class,
            Method::class,
            Method::class,
        ]);

        MethodRegistry::singleton()->getMethods();
    }

    /**
     * @expectedException UnexpectedValueException
     * @expectedExceptionMessage Cannot register multiple MFA methods with the same URL segment: basic-math
     */
    public function testRegisteringMethodsWithSameURLSegmentThrowsException()
    {
        Config::modify()->set(MethodRegistry::class, 'methods', [
            Method::class,
            DuplicatedBasicMath\Method::class,
        ]);

        MethodRegistry::singleton()->getMethods();
    }
}