Issues (102)

src/Extension/AccountReset/MFAResetExtension.php (1 issue)

Labels
Severity
1
<?php
2
3
declare(strict_types=1);
4
5
namespace SilverStripe\MFA\Extension\AccountReset;
6
7
use SilverStripe\Core\Extension;
8
use SilverStripe\MFA\Extension\MemberExtension as MemberExtension;
0 ignored issues
show
This use statement conflicts with another class in this namespace, SilverStripe\MFA\Extensi...ntReset\MemberExtension. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
9
use SilverStripe\Security\Member;
10
11
/**
12
 * Handles removing a member's registered MFA methods during Account Reset. Also
13
 * resets the 'MFA Skipped' flag on the member so that they are prompted to
14
 * set up MFA again when they next log in.
15
 *
16
 * @package SilverStripe\MFA\Extension\AccountReset
17
 */
18
class MFAResetExtension extends Extension
19
{
20
    /**
21
     * @param Member&MemberExtension $member
22
     */
23
    public function handleAccountReset(Member $member)
24
    {
25
        foreach ($member->RegisteredMFAMethods() as $method) {
26
            $method->delete();
27
        }
28
29
        $member->HasSkippedMFARegistration = false;
30
        $member->write();
31
    }
32
}
33