Passed
Pull Request — master (#165)
by Garion
02:31
created

MFAResetExtension::handleAccountReset()   A

Complexity

Conditions 2
Paths 2

Size

Total Lines 8
Code Lines 4

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
cc 2
eloc 4
nc 2
nop 1
dl 0
loc 8
rs 10
c 0
b 0
f 0
1
<?php declare(strict_types=1);
2
3
namespace SilverStripe\MFA\Extension\AccountReset;
4
5
use SilverStripe\Core\Extension;
6
use SilverStripe\MFA\Extension\MemberExtension as MemberExtension;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, SilverStripe\MFA\Extensi...ntReset\MemberExtension. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
7
use SilverStripe\Security\Member;
8
9
/**
10
 * Handles removing a member's registered MFA methods during Account Reset. Also
11
 * resets the 'MFA Skipped' flag on the member so that they are prompted to
12
 * set up MFA again when they next log in.
13
 *
14
 * @package SilverStripe\MFA\Extension\AccountReset
15
 */
16
class MFAResetExtension extends Extension
17
{
18
    /**
19
     * @param Member&MemberExtension $member
20
     */
21
    public function handleAccountReset(Member $member)
22
    {
23
        foreach ($member->RegisteredMFAMethods() as $method) {
24
            $method->delete();
25
        }
26
27
        $member->HasSkippedMFARegistration = false;
28
        $member->write();
29
    }
30
}
31