silverstripe / silverstripe-ldap

src/Model/LDAPGroupMapping.php

<?php

namespace SilverStripe\LDAP\Model;

use SilverStripe\Forms\DropdownField;
use SilverStripe\Forms\FieldList;
use SilverStripe\LDAP\Services\LDAPService;
use SilverStripe\ORM\DataObject;
use SilverStripe\Security\Group;

/**
 * Class LDAPGroupMapping
 *
 * An individual mapping of an LDAP group to a SilverStripe {@link Group}
 */
class LDAPGroupMapping extends DataObject
{
    /**
     * {@inheritDoc}
     * @var string
     */
    private static $table_name = 'LDAPGroupMapping';

The private property $table_name is not used, and could be removed.

    /**
     * @var array
     */
    private static $db = [

The private property $db is not used, and could be removed.

        'DN' => 'Text', // the DN value of the LDAP object in AD, e.g. CN=Users,DN=playpen,DN=local
        'Scope' => 'Enum("Subtree,OneLevel","Subtree")' // the scope of the mapping
    ];

    /**
     * @var array
     */
    private static $has_one = [

The private property $has_one is not used, and could be removed.

        'Group' => Group::class
    ];

    /**
     * @var array
     */
    private static $summary_fields = [

The private property $summary_fields is not used, and could be removed.

        'DN'
    ];

    /**
     * @var array
     */
    private static $dependencies = [

The private property $dependencies is not used, and could be removed.

        'ldapService' => '%$' . LDAPService::class,
    ];

    private static $singular_name = 'LDAP Group Mapping';

The private property $singular_name is not used, and could be removed.

    private static $plural_name = 'LDAP Group Mappings';

The private property $plural_name is not used, and could be removed.

    /**
     * {@inheritDoc}
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $fields->removeByName('DN');

        $field = DropdownField::create('DN', _t(__CLASS__ . '.LDAPGROUP', 'LDAP Group'));
        $field->setEmptyString(_t(__CLASS__ . '.SELECTONE', 'Select one'));
        $groups = $this->ldapService->getGroups(true, ['dn', 'name']);

The property ldapService does not exist on SilverStripe\LDAP\Model\LDAPGroupMapping. Since you implemented __get, consider adding a @property annotation.

The method getGroups() does not exist on null.

        $source = [];
        if ($groups) {
            foreach ($groups as $dn => $record) {
                $source[$dn] = sprintf('%s (%s)', $record['name'], $dn);
            }
        }
        asort($source);
        $field->setSource($source);
        $fields->addFieldToTab('Root.Main', $field);

        $fields->removeByName('Scope');
        $fields->addFieldToTab(
            'Root.Main',
            DropdownField::create('Scope', _t(__CLASS__ . '.SCOPE', 'Scope'), [
                'Subtree' => _t(
                    __CLASS__ . '.SUBTREE_DESCRIPTION',
                    'Users within this group and all nested groups within'
                ),
                'OneLevel' => _t(__CLASS__ . '.ONELEVEL_DESCRIPTION', 'Only users within this group'),
            ])
        );

        return $fields;
    }
}