LDAPCreateGroupTask

Complexity

Total Complexity

4

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
B	run()	0	32	4

<?php

use SilverStripe\Core\Config\Config;
use SilverStripe\Dev\BuildTask;
use SilverStripe\LDAP\Services\LDAPService;
use SilverStripe\ORM\DataObject;

class LDAPCreateGroupTask extends BuildTask
{
    private static $segment = 'LDAPCreateGroupTask';

The property $segment is not used and could be removed.

    private static $dependencies = [

The property $dependencies is not used and could be removed.

        'ldapService' => '%$' . LDAPService::class,
    ];

    public function run($request)
    {
        $logFn = function ($message) {
            echo $message, PHP_EOL;
        };

        $group = \SilverStripe\Security\Group::get()->byID($request->getVar('id'));
        $groupCode = $request->getVar('code');

        $dn = LDAPService::config()->get('new_groups_dn');

        $dn = sprintf('CN=%s,%s', $groupCode, $dn);
        $data = $this->ldapService->getGroupByDN($dn);

The property ldapService does not exist on LDAPCreateGroupTask. Did you maybe forget to declare it?

        if (!empty($data['objectguid'])) {
            if (is_callable($logFn)) {
                $logFn(sprintf('* Using existing LDAP group "%s"', $groupCode));
            }
            $group->GUID = $data['objectguid'];
        } else {
            if (is_callable($logFn)) {
                $logFn(sprintf('* Creating new LDAP group "%s"', $groupCode));
            }
            $group->Title = $groupCode;
            $this->ldapService->createLDAPGroup($group);
        }

        // Config::nest();
        // Config::modify()->set(DataObject::class, 'validation_enabled', false);
        $group->write();
        // Config::unnest();

        echo 'Done', PHP_EOL;
    }
}