SilverStripe\LDAP\Tasks\LDAPMemberSyncOneTask

Complexity

Total Complexity

7

Size/Duplication

Total Lines	88
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	run()	0	44	5
A	setLDAPService()	0	4	1
A	getTitle()	0	3	1

<?php

namespace SilverStripe\LDAP\Tasks;

use Exception;
use SilverStripe\Control\HTTPRequest;
use SilverStripe\LDAP\Services\LDAPService;

/**
 * Class LDAPMemberSyncOneTask
 * @package SilverStripe\LDAP\Tasks
 *
 * Debug build task that can be used to sync a single member by providing their email address registered in LDAP.
 *
 * Usage: /dev/tasks/LDAPMemberSyncOneTask?mail=john.smith@example.com
 */
class LDAPMemberSyncOneTask extends LDAPMemberSyncTask
{
    /**
     * {@inheritDoc}
     * @var string
     */
    private static $segment = 'LDAPMemberSyncOneTask';

The private property $segment is not used, and could be removed.

    /**
     * @var array
     */
    private static $dependencies = [

The private property $dependencies is not used, and could be removed.

        'LDAPService' => '%$' . LDAPService::class,
    ];

    /**
     * @var LDAPService
     */
    protected $ldapService;

    /**
     * @return string
     */
    public function getTitle()
    {
        return _t(__CLASS__ . '.SYNCONETITLE', 'Sync single user from LDAP');
    }

    /**
     * Syncs a single user based on the email address passed in the URL
     *
     * @param HTTPRequest $request
     */
    public function run($request)
    {
        $email = $request->getVar('email');

        if (!$email) {
            echo 'You must supply an email parameter to this method.', PHP_EOL;
            exit;

Using exit here is not recommended.

        }

        $user = $this->ldapService->getUserByEmail($email);

        if (!$user) {

The expression $user of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            echo sprintf('No user found in LDAP for email %s', $email), PHP_EOL;
            exit;

Using exit here is not recommended.

        }

        $member = $this->findOrCreateMember($user);

        // If member exists already, we're updating - otherwise we're creating
        if ($member->exists()) {
            $this->log(sprintf(
                'Updating existing Member %s: "%s" (ID: %s, SAM Account Name: %s)',
                $user['objectguid'],
                $member->getName(),
                $member->ID,
                $user['samaccountname']
            ));
        } else {
            $this->log(sprintf(
                'Creating new Member %s: "%s" (SAM Account Name: %s)',
                $user['objectguid'],
                $user['cn'],
                $user['samaccountname']
            ));
        }

        $this->log('User data returned from LDAP follows:');
        $this->log(var_export($user));

Are you sure the usage of var_export($user) is correct as it seems to always return null.

        try {
            $this->ldapService->updateMemberFromLDAP($member, $user);
            $this->log('Done!');
        } catch (Exception $e) {
            $this->log($e->getMessage());
        }
    }

    /**
     * @param LDAPService $service
     * @return $this
     */
    public function setLDAPService(LDAPService $service)
    {
        $this->ldapService = $service;
        return $this;
    }
}