silverstripe / silverstripe-hybridsessions

tests/Store/TestCookieStore.php

Indentation +15 added lines, -15 removed lines

@@ -7,21 +7,21 @@
 
 class TestCookieStore extends CookieStore implements TestOnly
 {
-    /**
-     * Override value of 'headers_sent' but only if running tests.
-     *
-     * Set to true or false, or null to not override
-     *
-     * @var string
-     */
-    public static $override_headers_sent = null;
+	/**
+	 * Override value of 'headers_sent' but only if running tests.
+	 *
+	 * Set to true or false, or null to not override
+	 *
+	 * @var string
+	 */
+	public static $override_headers_sent = null;
 
-    protected function canWrite()
-    {
-        if (self::$override_headers_sent !== null) {
-            return !self::$override_headers_sent;
-        }
+	protected function canWrite()
+	{
+		if (self::$override_headers_sent !== null) {
+			return !self::$override_headers_sent;
+		}
 
-        parent::canWrite();
-    }
+		parent::canWrite();
+	}
 }

src/Crypto/McryptCrypto.php

Doc Comments +3 added lines, -3 removed lines

@@ -35,8 +35,8 @@ 
     }
 
     /**
-     * @param $key a per-site secret string which is used as the base encryption key.
-     * @param $salt a per-session random string which is used as a salt to generate a per-session key
+     * @param string $key a per-site secret string which is used as the base encryption key.
+     * @param string $salt a per-session random string which is used as a salt to generate a per-session key
      *
      * The base encryption key needs to stay secret. If an attacker ever gets it, they can read their session,
      * and even modify & re-sign it.
@@ -87,7 +87,7 @@ 
      *
      * @param $data - The encrypted-and-signed message as base64 ASCII
      *
-     * @return bool|string - The decrypted cleartext or false if signature failed
+     * @return string|false - The decrypted cleartext or false if signature failed
      */
     public function decrypt($data)
     {

Indentation +105 added lines, -105 removed lines

@@ -8,109 +8,109 @@
  */
 class McryptCrypto implements CryptoHandler
 {
-    protected $key;
-
-    protected $ivSize;
-
-    protected $keySize;
-
-    protected $salt;
-
-    protected $saltedKey;
-
-    /**
-     * @return string
-     */
-    public function getKey()
-    {
-        return $this->key;
-    }
-
-    /**
-     * @return string
-     */
-    public function getSalt()
-    {
-        return $this->salt;
-    }
-
-    /**
-     * @param $key a per-site secret string which is used as the base encryption key.
-     * @param $salt a per-session random string which is used as a salt to generate a per-session key
-     *
-     * The base encryption key needs to stay secret. If an attacker ever gets it, they can read their session,
-     * and even modify & re-sign it.
-     *
-     * The salt is a random per-session string that is used with the base encryption key to create a per-session key.
-     * This (amongst other things) makes sure an attacker can't use a known-plaintext attack to guess the key.
-     *
-     * Normally we could create a salt on encryption, send it to the client as part of the session (it doesn't
-     * need to remain secret), then use the returned salt to decrypt. But we already have the Session ID which makes
-     * a great salt, so no need to generate & handle another one.
-     */
-    public function __construct($key, $salt)
-    {
-        $this->ivSize = mcrypt_get_iv_size(MCRYPT_RIJNDAEL_256, MCRYPT_MODE_CBC);
-        $this->keySize = mcrypt_get_key_size(MCRYPT_RIJNDAEL_256, MCRYPT_MODE_CBC);
-
-        $this->key = $key;
-        $this->salt = $salt;
-        $this->saltedKey = hash_pbkdf2('sha256', $this->key, $this->salt, 1000, $this->keySize, true);
-    }
-
-    /**
-     * Encrypt and then sign some cleartext
-     *
-     * @param $cleartext - The cleartext to encrypt and sign
-     * @return string - The encrypted-and-signed message as base64 ASCII.
-     */
-    public function encrypt($cleartext)
-    {
-        $iv = mcrypt_create_iv($this->ivSize, MCRYPT_DEV_URANDOM);
-
-        $enc = mcrypt_encrypt(
-            MCRYPT_RIJNDAEL_256,
-            $this->saltedKey,
-            $cleartext,
-            MCRYPT_MODE_CBC,
-            $iv
-        );
-
-        $hash = hash_hmac('sha256', $enc, $this->saltedKey);
-
-        return base64_encode($iv . $hash . $enc);
-    }
-
-    /**
-     * Check the signature on an encrypted-and-signed message, and if valid
-     * decrypt the content
-     *
-     * @param $data - The encrypted-and-signed message as base64 ASCII
-     *
-     * @return bool|string - The decrypted cleartext or false if signature failed
-     */
-    public function decrypt($data)
-    {
-        $data = base64_decode($data);
-
-        $iv   = substr($data, 0, $this->ivSize);
-        $hash = substr($data, $this->ivSize, 64);
-        $enc  = substr($data, $this->ivSize + 64);
-
-        $cleartext = rtrim(mcrypt_decrypt(
-            MCRYPT_RIJNDAEL_256,
-            $this->saltedKey,
-            $enc,
-            MCRYPT_MODE_CBC,
-            $iv
-        ), "\x00");
-
-        // Needs to be after decrypt so it always runs, to avoid timing attack
-        $gen_hash = hash_hmac('sha256', $enc, $this->saltedKey);
-
-        if ($gen_hash == $hash) {
-            return $cleartext;
-        }
-        return false;
-    }
+	protected $key;
+
+	protected $ivSize;
+
+	protected $keySize;
+
+	protected $salt;
+
+	protected $saltedKey;
+
+	/**
+	 * @return string
+	 */
+	public function getKey()
+	{
+		return $this->key;
+	}
+
+	/**
+	 * @return string
+	 */
+	public function getSalt()
+	{
+		return $this->salt;
+	}
+
+	/**
+	 * @param $key a per-site secret string which is used as the base encryption key.
+	 * @param $salt a per-session random string which is used as a salt to generate a per-session key
+	 *
+	 * The base encryption key needs to stay secret. If an attacker ever gets it, they can read their session,
+	 * and even modify & re-sign it.
+	 *
+	 * The salt is a random per-session string that is used with the base encryption key to create a per-session key.
+	 * This (amongst other things) makes sure an attacker can't use a known-plaintext attack to guess the key.
+	 *
+	 * Normally we could create a salt on encryption, send it to the client as part of the session (it doesn't
+	 * need to remain secret), then use the returned salt to decrypt. But we already have the Session ID which makes
+	 * a great salt, so no need to generate & handle another one.
+	 */
+	public function __construct($key, $salt)
+	{
+		$this->ivSize = mcrypt_get_iv_size(MCRYPT_RIJNDAEL_256, MCRYPT_MODE_CBC);
+		$this->keySize = mcrypt_get_key_size(MCRYPT_RIJNDAEL_256, MCRYPT_MODE_CBC);
+
+		$this->key = $key;
+		$this->salt = $salt;
+		$this->saltedKey = hash_pbkdf2('sha256', $this->key, $this->salt, 1000, $this->keySize, true);
+	}
+
+	/**
+	 * Encrypt and then sign some cleartext
+	 *
+	 * @param $cleartext - The cleartext to encrypt and sign
+	 * @return string - The encrypted-and-signed message as base64 ASCII.
+	 */
+	public function encrypt($cleartext)
+	{
+		$iv = mcrypt_create_iv($this->ivSize, MCRYPT_DEV_URANDOM);
+
+		$enc = mcrypt_encrypt(
+			MCRYPT_RIJNDAEL_256,
+			$this->saltedKey,
+			$cleartext,
+			MCRYPT_MODE_CBC,
+			$iv
+		);
+
+		$hash = hash_hmac('sha256', $enc, $this->saltedKey);
+
+		return base64_encode($iv . $hash . $enc);
+	}
+
+	/**
+	 * Check the signature on an encrypted-and-signed message, and if valid
+	 * decrypt the content
+	 *
+	 * @param $data - The encrypted-and-signed message as base64 ASCII
+	 *
+	 * @return bool|string - The decrypted cleartext or false if signature failed
+	 */
+	public function decrypt($data)
+	{
+		$data = base64_decode($data);
+
+		$iv   = substr($data, 0, $this->ivSize);
+		$hash = substr($data, $this->ivSize, 64);
+		$enc  = substr($data, $this->ivSize + 64);
+
+		$cleartext = rtrim(mcrypt_decrypt(
+			MCRYPT_RIJNDAEL_256,
+			$this->saltedKey,
+			$enc,
+			MCRYPT_MODE_CBC,
+			$iv
+		), "\x00");
+
+		// Needs to be after decrypt so it always runs, to avoid timing attack
+		$gen_hash = hash_hmac('sha256', $enc, $this->saltedKey);
+
+		if ($gen_hash == $hash) {
+			return $cleartext;
+		}
+		return false;
+	}
 }

Spacing +1 added lines, -1 removed lines

@@ -78,7 +78,7 @@
 
         $hash = hash_hmac('sha256', $enc, $this->saltedKey);
 
-        return base64_encode($iv . $hash . $enc);
+        return base64_encode($iv.$hash.$enc);
     }
 
     /**

src/Store/DatabaseStore.php

Indentation +125 added lines, -125 removed lines

@@ -12,137 +12,137 @@
 class DatabaseStore extends BaseStore
 {
 
-    /**
-     * Determine if the DB is ready to use.
-     *
-     * @return bool
-     * @throws Exception
-     */
-    protected function isDatabaseReady()
-    {
-        // Such as during setup of testsession prior to DB connection.
-        if (!DB::is_active()) {
-            return false;
-        }
-
-        // If we have a DB of the wrong type then complain
-        if (!(DB::get_conn() instanceof MySQLDatabase)) {
-            throw new Exception('HybridSessions\Store\DatabaseStore currently only works with MySQL databases');
-        }
-
-        // Prevent freakout during dev/build
-        return ClassInfo::hasTable('HybridSessionDataObject');
-    }
-
-    public function open($save_path, $name)
-    {
-        // no-op
-    }
-
-    public function close()
-    {
-        // no-op
-    }
-
-    public function read($session_id)
-    {
-        if (!$this->isDatabaseReady()) {
-            return null;
-        }
-
-        $query = sprintf(
-            'SELECT "Data" FROM "HybridSessionDataObject"
+	/**
+	 * Determine if the DB is ready to use.
+	 *
+	 * @return bool
+	 * @throws Exception
+	 */
+	protected function isDatabaseReady()
+	{
+		// Such as during setup of testsession prior to DB connection.
+		if (!DB::is_active()) {
+			return false;
+		}
+
+		// If we have a DB of the wrong type then complain
+		if (!(DB::get_conn() instanceof MySQLDatabase)) {
+			throw new Exception('HybridSessions\Store\DatabaseStore currently only works with MySQL databases');
+		}
+
+		// Prevent freakout during dev/build
+		return ClassInfo::hasTable('HybridSessionDataObject');
+	}
+
+	public function open($save_path, $name)
+	{
+		// no-op
+	}
+
+	public function close()
+	{
+		// no-op
+	}
+
+	public function read($session_id)
+	{
+		if (!$this->isDatabaseReady()) {
+			return null;
+		}
+
+		$query = sprintf(
+			'SELECT "Data" FROM "HybridSessionDataObject"
             WHERE "SessionID" = \'%s\' AND "Expiry" >= %s',
-            Convert::raw2sql($session_id),
-            $this->getNow()
-        );
+			Convert::raw2sql($session_id),
+			$this->getNow()
+		);
 
-        $result = DB::query($query);
+		$result = DB::query($query);
 
-        if ($result && $result->numRecords()) {
-            $data = $result->first();
-            $decoded = static::binaryDataJsonDecode($data['Data']);
-            return is_null($decoded) ? $data['Data'] : $decoded;
-        }
-    }
+		if ($result && $result->numRecords()) {
+			$data = $result->first();
+			$decoded = static::binaryDataJsonDecode($data['Data']);
+			return is_null($decoded) ? $data['Data'] : $decoded;
+		}
+	}
 
-    public function write($session_id, $session_data)
-    {
-        if (!$this->isDatabaseReady()) {
-            return false;
-        }
+	public function write($session_id, $session_data)
+	{
+		if (!$this->isDatabaseReady()) {
+			return false;
+		}
 
-        $expiry = $this->getNow() + $this->getLifetime();
+		$expiry = $this->getNow() + $this->getLifetime();
 
-        DB::query($str = sprintf(
-            'INSERT INTO "HybridSessionDataObject" ("SessionID", "Expiry", "Data")
+		DB::query($str = sprintf(
+			'INSERT INTO "HybridSessionDataObject" ("SessionID", "Expiry", "Data")
             VALUES (\'%1$s\', %2$u, \'%3$s\')
             ON DUPLICATE KEY UPDATE "Expiry" = %2$u, "Data" = \'%3$s\'',
-            Convert::raw2sql($session_id),
-            $expiry,
-            Convert::raw2sql(static::binaryDataJsonEncode($session_data))
-        ));
-
-        return true;
-    }
-
-    public function destroy($session_id)
-    {
-        // NOP
-    }
-
-    public function gc($maxlifetime)
-    {
-        if (!$this->isDatabaseReady()) {
-            return;
-        }
-
-        DB::query(sprintf(
-            'DELETE FROM "HybridSessionDataObject" WHERE "Expiry" < %u',
-            $this->getNow()
-        ));
-    }
-
-    /**
-    * Encode binary data into ASCII string (a subset of UTF-8)
-    *
-    * Silverstripe <= 4.4 does not have a binary db field implementation, so we have to store
-    * binary data as text
-    *
-    * @param string $data This is a binary blob
-    *
-    * @return string
-    */
-    public static function binaryDataJsonEncode($data)
-    {
-        return json_encode([
-            self::class,
-            base64_encode($data)
-        ]);
-    }
-
-    /**
-     * Decode ASCII string into original binary data (a php string)
-     *
-     * Silverstripe <= 4.4 does not have a binary db field implementation, so we have to store
-     * binary data as text
-     *
-     * @param string $text
-     *
-     * @param null|string
-     */
-    public static function binaryDataJsonDecode($text)
-    {
-        $struct = json_decode($text, true, 2);
-
-        if (!is_array($struct) || count($struct) !== 2) {
-            return null;
-        }
-
-        if (!isset($struct[0]) || !isset($struct[1]) || $struct[0] !== self::class) {
-            return null;
-        }
-
-        return base64_decode($struct[1]);
-    }
+			Convert::raw2sql($session_id),
+			$expiry,
+			Convert::raw2sql(static::binaryDataJsonEncode($session_data))
+		));
+
+		return true;
+	}
+
+	public function destroy($session_id)
+	{
+		// NOP
+	}
+
+	public function gc($maxlifetime)
+	{
+		if (!$this->isDatabaseReady()) {
+			return;
+		}
+
+		DB::query(sprintf(
+			'DELETE FROM "HybridSessionDataObject" WHERE "Expiry" < %u',
+			$this->getNow()
+		));
+	}
+
+	/**
+	 * Encode binary data into ASCII string (a subset of UTF-8)
+	 *
+	 * Silverstripe <= 4.4 does not have a binary db field implementation, so we have to store
+	 * binary data as text
+	 *
+	 * @param string $data This is a binary blob
+	 *
+	 * @return string
+	 */
+	public static function binaryDataJsonEncode($data)
+	{
+		return json_encode([
+			self::class,
+			base64_encode($data)
+		]);
+	}
+
+	/**
+	 * Decode ASCII string into original binary data (a php string)
+	 *
+	 * Silverstripe <= 4.4 does not have a binary db field implementation, so we have to store
+	 * binary data as text
+	 *
+	 * @param string $text
+	 *
+	 * @param null|string
+	 */
+	public static function binaryDataJsonDecode($text)
+	{
+		$struct = json_decode($text, true, 2);
+
+		if (!is_array($struct) || count($struct) !== 2) {
+			return null;
+		}
+
+		if (!isset($struct[0]) || !isset($struct[1]) || $struct[0] !== self::class) {
+			return null;
+		}
+
+		return base64_decode($struct[1]);
+	}
 }

tests/CookieStoreTest.php

Indentation +55 added lines, -55 removed lines

@@ -9,69 +9,69 @@
 
 class CookieStoreTest extends AbstractTest
 {
-    protected function getStore()
-    {
-        $store = Injector::inst()->get(CookieStore::class);
-        $store->setKey(uniqid());
-        $store->open(TempFolder::getTempFolder(BASE_PATH) . '/' . __CLASS__, 'SESSIONCOOKIE');
+	protected function getStore()
+	{
+		$store = Injector::inst()->get(CookieStore::class);
+		$store->setKey(uniqid());
+		$store->open(TempFolder::getTempFolder(BASE_PATH) . '/' . __CLASS__, 'SESSIONCOOKIE');
 
-        return $store;
-    }
+		return $store;
+	}
 
-    public function testStoreLargeData()
-    {
-        $session = uniqid();
-        $store = $this->getStore();
+	public function testStoreLargeData()
+	{
+		$session = uniqid();
+		$store = $this->getStore();
 
-        // Test new session is blank
-        $result = $store->read($session);
-        $this->assertEmpty($result);
+		// Test new session is blank
+		$result = $store->read($session);
+		$this->assertEmpty($result);
 
-        // Save data against session
-        $data1 = array(
-            'Large' => str_repeat('A', 600),
-            'Content' => str_repeat('B', 600)
-        );
-        $store->write($session, serialize($data1));
-        $result = $store->read($session);
+		// Save data against session
+		$data1 = array(
+			'Large' => str_repeat('A', 600),
+			'Content' => str_repeat('B', 600)
+		);
+		$store->write($session, serialize($data1));
+		$result = $store->read($session);
 
-        // Cookies should not try to store data that large
-        $this->assertEmpty($result);
-    }
+		// Cookies should not try to store data that large
+		$this->assertEmpty($result);
+	}
 
-    /**
-     * Ensure that subsequent reads without the necessary write do not report data
-     */
-    public function testReadInvalidatesData()
-    {
-        $session = uniqid();
-        $store = $this->getStore();
+	/**
+	 * Ensure that subsequent reads without the necessary write do not report data
+	 */
+	public function testReadInvalidatesData()
+	{
+		$session = uniqid();
+		$store = $this->getStore();
 
-        // Test new session is blank
-        $result = $store->read($session);
-        $this->assertEmpty($result);
+		// Test new session is blank
+		$result = $store->read($session);
+		$this->assertEmpty($result);
 
-        // Save data against session
-        $data1 = array(
-            'Color' => 'red',
-            'Animal' => 'elephant'
-        );
-        $store->write($session, serialize($data1));
-        $result = $store->read($session);
-        $this->assertEquals($data1, unserialize($result));
+		// Save data against session
+		$data1 = array(
+			'Color' => 'red',
+			'Animal' => 'elephant'
+		);
+		$store->write($session, serialize($data1));
+		$result = $store->read($session);
+		$this->assertEquals($data1, unserialize($result));
 
-        // Since we have read the data into the result, the application could modify this content
-        // and be unable to write it back due to headers being sent. We should thus assume
-        // that subsequent reads without a successful write do not purport to have valid data
-        $data1['Color'] = 'blue';
-        $result = $store->read($session);
-        $this->assertEmpty($result);
+		// Since we have read the data into the result, the application could modify this content
+		// and be unable to write it back due to headers being sent. We should thus assume
+		// that subsequent reads without a successful write do not purport to have valid data
+		$data1['Color'] = 'blue';
+		$result = $store->read($session);
+		$this->assertEmpty($result);
 
-        // Check that writing to cookie fails after headers are sent and these results remain
-        // invalidated
-        TestCookieStore::$override_headers_sent = true;
-        $store->write($session, serialize($data1));
-        $result = $store->read($session);
-        $this->assertEmpty($result);
-    }
+		// Check that writing to cookie fails after headers are sent and these results remain
+		// invalidated
+		TestCookieStore::$override_headers_sent = true;
+		$store->write($session, serialize($data1));
+		$result = $store->read($session);
+		$this->assertEmpty($result);
+	}
 }

Spacing +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
     {
         $store = Injector::inst()->get(CookieStore::class);
         $store->setKey(uniqid());
-        $store->open(TempFolder::getTempFolder(BASE_PATH) . '/' . __CLASS__, 'SESSIONCOOKIE');
+        $store->open(TempFolder::getTempFolder(BASE_PATH).'/'.__CLASS__, 'SESSIONCOOKIE');
 
         return $store;
     }

tests/OpenSSLCryptoTest.php

Indentation +10 added lines, -10 removed lines

@@ -10,17 +10,17 @@
  */
 class OpenSSLCryptoTest extends SapphireTest
 {
-    public function testIntegrity()
-    {
-        $key = random_bytes(8);
-        $salt = random_bytes(16);
+	public function testIntegrity()
+	{
+		$key = random_bytes(8);
+		$salt = random_bytes(16);
 
-        $handler = new OpenSSLCrypto($key, $salt);
+		$handler = new OpenSSLCrypto($key, $salt);
 
-        for ($i = 0; $i < 1000; ++$i) {
-            $data = random_bytes(1024 * 4);
+		for ($i = 0; $i < 1000; ++$i) {
+			$data = random_bytes(1024 * 4);
 
-            $this->assertEquals($data, $handler->decrypt($handler->encrypt($data)));
-        }
-    }
+			$this->assertEquals($data, $handler->decrypt($handler->encrypt($data)));
+		}
+	}
 }

tests/DatabaseStoreTest.php

Indentation +25 added lines, -25 removed lines

@@ -9,29 +9,29 @@
 
 class DatabaseStoreTest extends AbstractTest
 {
-    protected function setUp()
-    {
-        parent::setUp();
-
-        if (!DB::get_conn() instanceof MySQLDatabase) {
-            $this->markTestSkipped('Only MySQL databases are supported');
-        }
-    }
-
-    protected function getStore()
-    {
-        $store = Injector::inst()->get(DatabaseStore::class);
-        $store->setKey(uniqid());
-
-        return $store;
-    }
-
-    public function testDataCodecIntegrity()
-    {
-        for ($i = 0; $i < 1000; ++$i) {
-            $data = random_bytes(1024 * 4);
-
-            $this->assertEquals($data, DatabaseStore::binaryDataJsonDecode(DatabaseStore::binaryDataJsonEncode($data)));
-        }
-    }
+	protected function setUp()
+	{
+		parent::setUp();
+
+		if (!DB::get_conn() instanceof MySQLDatabase) {
+			$this->markTestSkipped('Only MySQL databases are supported');
+		}
+	}
+
+	protected function getStore()
+	{
+		$store = Injector::inst()->get(DatabaseStore::class);
+		$store->setKey(uniqid());
+
+		return $store;
+	}
+
+	public function testDataCodecIntegrity()
+	{
+		for ($i = 0; $i < 1000; ++$i) {
+			$data = random_bytes(1024 * 4);
+
+			$this->assertEquals($data, DatabaseStore::binaryDataJsonDecode(DatabaseStore::binaryDataJsonEncode($data)));
+		}
+	}
 }

tests/McryptCryptoTest.php

Indentation +24 added lines, -24 removed lines

@@ -11,28 +11,28 @@
  */
 class McryptCryptoTest extends SapphireTest
 {
-    public function testIntegrity()
-    {
-        $this->markTestSkipped(
-            'McryptCrypto is losing zero bytes at the end of messages: ' .
-            'https://github.com/silverstripe/silverstripe-hybridsessions/issues/53'
-        );
-
-        $error_reporting = ini_set('error_reporting', (int) ini_get('error_reporting') & ~E_DEPRECATED);
-
-        try {
-            $key = random_bytes(8);
-            $salt = random_bytes(16);
-
-            $handler = new McryptCrypto($key, $salt);
-
-            for ($i = 0; $i < 1000; ++$i) {
-                $data = random_bytes(1024 * 4);
-
-                $this->assertEquals($data, $handler->decrypt($handler->encrypt($data)));
-            }
-        } finally {
-            ini_set('error_reporting', $error_reporting);
-        }
-    }
+	public function testIntegrity()
+	{
+		$this->markTestSkipped(
+			'McryptCrypto is losing zero bytes at the end of messages: ' .
+			'https://github.com/silverstripe/silverstripe-hybridsessions/issues/53'
+		);
+
+		$error_reporting = ini_set('error_reporting', (int) ini_get('error_reporting') & ~E_DEPRECATED);
+
+		try {
+			$key = random_bytes(8);
+			$salt = random_bytes(16);
+
+			$handler = new McryptCrypto($key, $salt);
+
+			for ($i = 0; $i < 1000; ++$i) {
+				$data = random_bytes(1024 * 4);
+
+				$this->assertEquals($data, $handler->decrypt($handler->encrypt($data)));
+			}
+		} finally {
+			ini_set('error_reporting', $error_reporting);
+		}
+	}
 }

Spacing +1 added lines, -1 removed lines

@@ -14,7 +14,7 @@
     public function testIntegrity()
     {
         $this->markTestSkipped(
-            'McryptCrypto is losing zero bytes at the end of messages: ' .
+            'McryptCrypto is losing zero bytes at the end of messages: '.
             'https://github.com/silverstripe/silverstripe-hybridsessions/issues/53'
         );