SilverStripe\HybridSessions\Tests\McryptCryptoTest

Complexity

Total Complexity

2

Size/Duplication

Total Lines	27
Duplicated Lines	18.52 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	testIntegrity()	5	24	2

<?php

namespace SilverStripe\HybridSessions\Tests;

use SilverStripe\Dev\SapphireTest;
use SilverStripe\HybridSessions\Crypto\McryptCrypto;

/**
 * @requires extension mcrypt
 * @skip
 */
class McryptCryptoTest extends SapphireTest
{
    public function testIntegrity()
    {
        $this->markTestSkipped(
            'McryptCrypto is losing zero bytes at the end of messages: ' .
            'https://github.com/silverstripe/silverstripe-hybridsessions/issues/53'
        );

        $error_reporting = ini_set('error_reporting', (int) ini_get('error_reporting') & ~E_DEPRECATED);

        try {
            $key = random_bytes(8);
            $salt = random_bytes(16);

            $handler = new McryptCrypto($key, $salt);

The class SilverStripe\HybridSessions\Crypto\McryptCrypto has been deprecated with message: 2.2.0 The PHP mcrypt library is deprecated. Please use OpenSSLCrypto instead. WARNING: Please beware that McryptCrypto does not preserve zero bytes at the end of encrypted messages. Thus, a message such as "data\x00" will become "data" after encrypt-decrypt. As such, it is not binary safe. It is guaranteed for UTF-8 encoded text not to have zero bytes. However, other encodings may contain those. For example, be careful with UTF-16LE, since characters less than U+0100 are very common.

            for ($i = 0; $i < 1000; ++$i) {

This code seems to be duplicated across your project.

                $data = random_bytes(1024 * 4);

                $this->assertEquals($data, $handler->decrypt($handler->encrypt($data)));
            }
        } finally {
            ini_set('error_reporting', $error_reporting);
        }
    }
}