silverstripe / silverstripe-fulltextsearch

src/Solr/Writers/SolrSearchQueryWriterBasic.php

<?php

namespace SilverStripe\FullTextSearch\Solr\Writers;

use SilverStripe\FullTextSearch\Search\Criteria\SearchCriterion;
use SilverStripe\FullTextSearch\Search\Queries\AbstractSearchQueryWriter;

/**
 * Class SolrSearchQueryWriter_Basic
 * @package SilverStripe\FullTextSearch\Solr\Writers
 */
class SolrSearchQueryWriterBasic extends AbstractSearchQueryWriter
{
    /**
     * @var SearchCriterion $searchCriterion
     * @return string
     */
    public function generateQueryString(SearchCriterion $searchCriterion)
    {
        return sprintf(
            '%s(%s%s%s)',
            $this->getComparisonPolarity($searchCriterion->getComparison()),
            addslashes($searchCriterion->getTarget()),
            $this->getComparisonConjunction(),
            $searchCriterion->getQuoteValue($searchCriterion->getValue())

It seems like $searchCriterion->getValue() can also be of type array; however, parameter $value of SilverStripe\FullTextSearch\Search\Criteria\SearchCriterion::getQuoteValue() does only seem to accept string, maybe add an additional type check?

        );
    }

    /**
     * Is this a positive (+) or negative (-) Solr comparison.
     *
     * @param string $comparison
     * @return string
     */
    protected function getComparisonPolarity($comparison)
    {
        switch ($comparison) {
            case SearchCriterion::NOT_EQUAL:
                return '-';
            default:
                return '+';
        }
    }

    /**
     * Decide how we are comparing our left and right values.
     *
     * @return string
     */
    protected function getComparisonConjunction()
    {
        return ':';
    }
}