silverstripe / silverstripe-fulltextsearch

tests/SearchVariantVersionedTest.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use SilverStripe\CMS\Model\SiteTree;
 use SilverStripe\Dev\SapphireTest;
 use SilverStripe\FullTextSearch\Search\FullTextSearch;
-use SilverStripe\FullTextSearch\Search\Indexes\SearchIndex_Recording;
 use SilverStripe\FullTextSearch\Search\Variants\SearchVariantVersioned;
 use SilverStripe\FullTextSearch\Tests\SearchVariantVersionedTest\SearchVariantVersionedTest_Index;
 use SilverStripe\FullTextSearch\Tests\SearchVariantVersionedTest\SearchVariantVersionedTest_Item;

tests/SolrIndexSubsitesTest.php

Doc Comments +3 added lines

@@ -65,6 +65,9 @@
         parent::tearDown();
     }
 
+    /**
+     * @return \SilverStripe\FullTextSearch\Solr\Services\SolrService
+     */
     protected function getServiceMock()
     {
         return \Phockito::mock('Solr4Service');

tests/SolrIndexVersionedTest.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use SilverStripe\ORM\DataObject;
 use SilverStripe\FullTextSearch\Search\FullTextSearch;
 use SilverStripe\FullTextSearch\Search\SearchIntrospection;
-use SilverStripe\FullTextSearch\Search\Indexes\SearchIndex_Recording;
 use SilverStripe\FullTextSearch\Solr\Services\Solr3Service;
 use SilverStripe\FullTextSearch\Tests\SearchVariantVersionedTest\SearchVariantVersionedTest_Item;
 use SilverStripe\FullTextSearch\Tests\SolrIndexVersionedTest\SolrIndexVersionedTest_Object;

Doc Comments +1 added lines, -1 removed lines

@@ -94,7 +94,7 @@
      * @param DataObject $object Item being added
      * @param string $value Value for class
      * @param string $stage Stage updated
-     * @return Apache_Solr_Document
+     * @return \Apache_Solr_Document
      */
     protected function getSolrDocument($class, $object, $value, $stage)
     {

tests/SolrReindexTest.php

Unused Use Statements -2 removed lines

@@ -16,8 +16,6 @@
 use SilverStripe\FullTextSearch\Solr\Tasks\Solr_Reindex;
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Core\Injector\Injector;
-use SilverStripe\ORM\DataObject;
-use SilverStripe\ORM\DB;
 
 class SolrReindexTest extends SapphireTest
 {

tests/SolrReindexTest/SolrReindexTest_Item.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace SilverStripe\FullTextSearch\Tests\SolrReindexTest;
 
-use SilverStripe\Dev\TestOnly;
 use SilverStripe\ORM\DataObject;
 use SilverStripe\FullTextSearch\Tests\SolrReindexTest\SolrReindexTest_ItemExtension;
 

src/Search/FullTextSearch.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 
 use SilverStripe\Core\ClassInfo;
 use SilverStripe\Core\Config\Config;
-use SilverStripe\ORM\DataObject;
 use SilverStripe\FullTextSearch\Search\Indexes\SearchIndex;
 use ReflectionClass;
 

src/Search/Updaters/SearchUpdater.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use SilverStripe\Core\Config\Configurable;
 use SilverStripe\Core\Injector\Injector;
-use SilverStripe\Dev\SapphireTest;
 use SilverStripe\ORM\DataObject;
 use SilverStripe\ORM\DB;
 use SilverStripe\FullTextSearch\Search\FullTextSearch;

src/Search/Variants/SearchVariant.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace SilverStripe\FullTextSearch\Search\Variants;
 
-use SilverStripe\ORM\DataObject;
 use SilverStripe\Core\ClassInfo;
 use SilverStripe\FullTextSearch\Utils\CombinationsArrayIterator;
 use ReflectionClass;

Doc Comments +3 added lines, -1 removed lines

@@ -151,6 +151,7 @@ 
      * A shortcut to with when calling without passing in a class,
      *
      * SearchVariant::call(...) ==== SearchVariant::with()->call(...);
+     * @param string $method
      */
 
     public static function call($method, &...$args)
@@ -161,6 +162,7 @@ 
     /**
      * Get the current state of every variant
      * @static
+     * @param string $class
      * @return array
      */
     public static function current_state($class = null, $includeSubclasses = true)
@@ -194,7 +196,7 @@ 
      * @static
      * @param string $class - The class name to get variants for
      * @param bool $includeSubclasses - True if variants should be included if they apply to at least one subclass of $class
-     * @return SearchVariant_ReindexStateIteratorRet - The iterator to foreach loop over
+     * @return \Traversable - The iterator to foreach loop over
      */
     public static function reindex_states($class = null, $includeSubclasses = true)
     {

src/Search/Variants/SearchVariantSubsites.php

Doc Comments +4 added lines, -1 removed lines

@@ -19,6 +19,9 @@ 
         return class_exists('Subsite');
     }
 
+    /**
+     * @param boolean $includeSubclasses
+     */
     public function appliesTo($class, $includeSubclasses)
     {
         // Include all DataExtensions that contain a SubsiteID.
@@ -135,7 +138,7 @@ 
     /**
      * Determine if a field with a certain name is filtered by the search query or on the index
      * This is the equivalent of saying "show me the results that do ONLY contain this value"
-     * @param $field string name of the field being filtered
+     * @param string $field string name of the field being filtered
      * @param $query SearchQuery currently being executed
      * @param $index SearchIndex which specifies a filter field
      * @return bool true if $field is being filtered, false if it is not being filtered