SilverStripe\FullTextSearch\Solr\Stores\SolrConfigStore_WebDAV

Complexity

Total Complexity

10

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	instanceDir()	0	3	2
A	uploadString()	0	4	1
A	uploadFile()	0	4	1
A	__construct()	0	11	3
A	getTargetDir()	0	13	3

<?php

namespace SilverStripe\FullTextSearch\Solr\Stores;

use SilverStripe\FullTextSearch\Solr\Solr;
use SilverStripe\FullTextSearch\Utils\WebDAV;

/**
 * Class SolrConfigStore_WebDAV
 *
 * A ConfigStore that uploads files to a Solr instance via a WebDAV server
 */
class SolrConfigStore_WebDAV implements SolrConfigStore
{
    public function __construct($config)
    {
        $options = Solr::solr_options();

        $this->url = implode('', array(

The property url does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            'http://',
            isset($config['auth']) ? $config['auth'] . '@' : '',
            $options['host'] . ':' . (isset($config['port']) ? $config['port'] : $options['port']),
            $config['path']
        ));
        $this->remote = $config['remotepath'];

The property remote does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    public function getTargetDir($index)
    {
        $indexdir = "{$this->url}/$index";
        if (!WebDAV::exists($indexdir)) {

The expression SilverStripe\FullTextSearch\Utils\WebDAV::exists($indexdir) of type boolean|null is loosely compared to false; this is ambiguous if the boolean can be false. You might want to explicitly use !== null instead.

            WebDAV::mkdir($indexdir);
        }

        $targetDir = "{$this->url}/$index/conf";
        if (!WebDAV::exists($targetDir)) {

The expression SilverStripe\FullTextSearch\Utils\WebDAV::exists($targetDir) of type boolean|null is loosely compared to false; this is ambiguous if the boolean can be false. You might want to explicitly use !== null instead.

            WebDAV::mkdir($targetDir);
        }

        return $targetDir;
    }

    public function uploadFile($index, $file)
    {
        $targetDir = $this->getTargetDir($index);
        WebDAV::upload_from_file($file, $targetDir . '/' . basename($file));
    }

    public function uploadString($index, $filename, $string)
    {
        $targetDir = $this->getTargetDir($index);
        WebDAV::upload_from_string($string, "$targetDir/$filename");
    }

    public function instanceDir($index)
    {
        return $this->remote ? "{$this->remote}/$index" : $index;
    }
}