Completed
Pull Request — master (#6776)
by Nic
09:32
created
thirdparty/difflib/difflib.php 1 patch
Doc Comments   +12 added lines patch added patch discarded remove patch
@@ -245,6 +245,10 @@  discard block
 block discarded – undo
245 245
      * match.  The caller must trim matching lines from the beginning and end
246 246
      * of the portions it is going to specify.
247 247
      */
248
+
249
+    /**
250
+     * @param double $nchunks
251
+     */
248 252
     private function diag($xoff, $xlim, $yoff, $ylim, $nchunks)
249 253
     {
250 254
         $flip = false;
@@ -356,6 +360,11 @@  discard block
 block discarded – undo
356 360
      * Note that XLIM, YLIM are exclusive bounds.
357 361
      * All line numbers are origin-0 and discarded lines are not counted.
358 362
      */
363
+
364
+    /**
365
+     * @param integer $xoff
366
+     * @param integer $yoff
367
+     */
359 368
     private function compareseq($xoff, $xlim, $yoff, $ylim)
360 369
     {
361 370
         // Slide down the bottom initial diagonal.
@@ -779,6 +788,9 @@  discard block
 block discarded – undo
779 788
         return $xbeg . ($xlen ? ($ylen ? 'c' : 'd') : 'a') . $ybeg;
780 789
     }
781 790
 
791
+    /**
792
+     * @param string $header
793
+     */
782 794
     protected function start_block($header)
783 795
     {
784 796
         echo $header;
Please login to merge, or discard this patch.
thirdparty/simpletest/page.php 1 patch
Doc Comments   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
     /**
146 146
      *    Reads the raw content and send events
147 147
      *    into the page to be built.
148
-     *    @param $response SimpleHttpResponse  Fetched response.
148
+     *    @param SilverStripe\Dev\TestSession_STResponseWrapper $response SimpleHttpResponse  Fetched response.
149 149
      *    @return SimplePage                   Newly parsed page.
150 150
      *    @access public
151 151
      */
@@ -170,8 +170,8 @@  discard block
 block discarded – undo
170 170
 
171 171
     /**
172 172
      *    Creates the parser used with the builder.
173
-     *    @param $listener SimpleSaxListener   Target of parser.
174
-     *    @return SimpleSaxParser              Parser to generate
173
+     *    @param SimplePageBuilder $listener SimpleSaxListener   Target of parser.
174
+     *    @return SimpleHtmlSaxParser              Parser to generate
175 175
      *                                         events for the builder.
176 176
      *    @access protected
177 177
      */
@@ -406,7 +406,7 @@  discard block
 block discarded – undo
406 406
 
407 407
     /**
408 408
      *    Original request as bytes sent down the wire.
409
-     *    @return mixed              Sent content.
409
+     *    @return string|false              Sent content.
410 410
      *    @access public
411 411
      */
412 412
     function getRequest() {
@@ -415,7 +415,7 @@  discard block
 block discarded – undo
415 415
 
416 416
     /**
417 417
      *    Accessor for raw text of page.
418
-     *    @return string        Raw unparsed content.
418
+     *    @return boolean        Raw unparsed content.
419 419
      *    @access public
420 420
      */
421 421
     function getRaw() {
@@ -467,7 +467,7 @@  discard block
 block discarded – undo
467 467
 
468 468
     /**
469 469
      *    Base URL if set via BASE tag page url otherwise
470
-     *    @return SimpleUrl        Base url.
470
+     *    @return boolean        Base url.
471 471
      *    @access public
472 472
      */
473 473
     function getBaseUrl() {
@@ -658,7 +658,7 @@  discard block
 block discarded – undo
658 658
     /**
659 659
      *    Opens a frameset. A frameset may contain nested
660 660
      *    frameset tags.
661
-     *    @param SimpleFramesetTag $tag      Tag to accept.
661
+     *    @param SimpleTag $tag      Tag to accept.
662 662
      *    @access public
663 663
      */
664 664
     function acceptFramesetStart(&$tag) {
Please login to merge, or discard this patch.
src/Control/Controller.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -147,6 +147,7 @@  discard block
 block discarded – undo
147 147
      * {@inheritdoc}
148 148
      *
149 149
      * Also set the URLParams
150
+     * @param HTTPRequest $request
150 151
      */
151 152
     public function setRequest($request)
152 153
     {
@@ -523,7 +524,7 @@  discard block
 block discarded – undo
523 524
      *
524 525
      * @param array $params
525 526
      *
526
-     * @return string
527
+     * @return DBHTMLText
527 528
      */
528 529
     public function render($params = null)
529 530
     {
@@ -702,7 +703,7 @@  discard block
 block discarded – undo
702 703
      * Tests whether a redirection has been requested. If redirect() has been called, it will return
703 704
      * the URL redirected to. Otherwise, it will return null.
704 705
      *
705
-     * @return null|string
706
+     * @return boolean
706 707
      */
707 708
     public function redirectedTo()
708 709
     {
@@ -736,7 +737,6 @@  discard block
 block discarded – undo
736 737
      *
737 738
      * Caution: All parameters are expected to be URI-encoded already.
738 739
      *
739
-     * @param string|array $arg,.. One or more link segments, or list of link segments as an array
740 740
      * @return string
741 741
      */
742 742
     public static function join_links($arg = null)
Please login to merge, or discard this patch.
src/Control/CookieJar.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -151,7 +151,7 @@
 block discarded – undo
151 151
      * @see http://uk3.php.net/manual/en/function.setcookie.php
152 152
      *
153 153
      * @param string $name The name of the cookie
154
-     * @param string|array $value The value for the cookie to hold
154
+     * @param false|string $value The value for the cookie to hold
155 155
      * @param int $expiry The number of days until expiry
156 156
      * @param string $path The path to save the cookie on (falls back to site base)
157 157
      * @param string $domain The domain to make the cookie available on
Please login to merge, or discard this patch.
src/Control/RequestHandler.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -296,7 +296,7 @@
 block discarded – undo
296 296
      *
297 297
      * Must not raise HTTPResponse_Exceptions - instead it should return
298 298
      *
299
-     * @param $request
299
+     * @param HTTPRequest $request
300 300
      * @param $action
301 301
      * @return HTTPResponse
302 302
      */
Please login to merge, or discard this patch.
src/Control/RSS/RSSFeed.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -248,6 +248,7 @@
 block discarded – undo
248 248
      * via the standard template inclusion process.
249 249
      *
250 250
      * @param string
251
+     * @param string|null $template
251 252
      */
252 253
     public function setTemplate($template)
253 254
     {
Please login to merge, or discard this patch.
src/Control/Session.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -330,6 +330,9 @@  discard block
 block discarded – undo
330 330
         }
331 331
     }
332 332
 
333
+    /**
334
+     * @param string $name
335
+     */
333 336
     public function inst_set($name, $val)
334 337
     {
335 338
         // Quicker execution path for "."-free names
@@ -379,6 +382,9 @@  discard block
 block discarded – undo
379 382
         $diffVar[sizeof($var)-1] = $val;
380 383
     }
381 384
 
385
+    /**
386
+     * @param string $name
387
+     */
382 388
     public function inst_get($name)
383 389
     {
384 390
         // Quicker execution path for "."-free names
Please login to merge, or discard this patch.
src/Core/ClassInfo.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -297,6 +297,9 @@  discard block
 block discarded – undo
297 297
 
298 298
     private static $method_from_cache = array();
299 299
 
300
+    /**
301
+     * @param string $method
302
+     */
300 303
     public static function has_method_from($class, $method, $compclass)
301 304
     {
302 305
         $lClass = strtolower($class);
@@ -322,6 +325,8 @@  discard block
 block discarded – undo
322 325
 
323 326
     /**
324 327
      * @deprecated 4.0..5.0
328
+     * @param string $candidateClass
329
+     * @param string $fieldName
325 330
      */
326 331
     public static function table_for_object_field($candidateClass, $fieldName)
327 332
     {
Please login to merge, or discard this patch.
src/Core/CustomMethods.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -151,7 +151,7 @@
 block discarded – undo
151 151
     /**
152 152
      * Get meta-data details on a named method
153 153
      *
154
-     * @param array $method
154
+     * @param string $method
155 155
      * @return array List of custom method details, if defined for this method
156 156
      */
157 157
     protected function getExtraMethodConfig($method)
Please login to merge, or discard this patch.