silverstripe / silverstripe-framework

tasks/EncryptAllPasswordsTask.php

Doc Comments +1 added lines

@@ -66,6 +66,7 @@
 
 	/**
 	 * @todo This should really be taken care of by TestRunner
+	 * @param string $msg
 	 */
 	protected function debugMessage($msg) {
 		if(class_exists('SapphireTest', false) && !SapphireTest::is_running_test()) {

tests/core/manifest/ConfigManifestTest.php

Doc Comments +3 added lines, -2 removed lines

@@ -10,7 +10,7 @@ 
 
 	/**
 	 * This is a helper method for getting a new manifest
-	 * @param $name
+	 * @param string $name
 	 * @return any
 	 */
 	protected function getConfigFixtureValue($name) {
@@ -20,6 +20,7 @@ 
 
 	/**
 	 * This is a helper method for displaying a relevant message about a parsing failure
+	 * @param string $path
 	 */
 	protected function getParsedAsMessage($path) {
 		return sprintf('Reference path "%s" failed to parse correctly', $path);
@@ -41,7 +42,7 @@ 
 
 	/**
 	 * A helper method to return a mock of the manifest in order to test expectations and reduce dependency
-	 * @param $methods
+	 * @param string[] $methods
 	 * @return SS_ConfigManifest
 	 */
 	protected function getManifestMock($methods) {

tests/dev/CsvBulkLoaderTest.php

Doc Comments +3 added lines

@@ -222,6 +222,9 @@
 	}
 
 
+	/**
+	 * @param resource $file
+	 */
 	protected function getLineCount(&$file) {
 		$i = 0;
 		while(fgets($file) !== false) $i++;

tests/dev/DevAdminControllerTest.php

Doc Comments +6 added lines

@@ -47,6 +47,9 @@ 
 
 
 
+	/**
+	 * @param string $url
+	 */
 	protected function getCapture($url){
 		$this->logInWithPermission('ADMIN');
 
@@ -58,6 +61,9 @@ 
 		return $r;
 	}
 
+	/**
+	 * @param string $url
+	 */
 	protected function getAndCheckForError($url){
 		$this->logInWithPermission('ADMIN');
 

tests/forms/EmailFieldTest.php

Doc Comments +5 added lines

@@ -23,6 +23,11 @@
 		$this->internalCheck("domain.but.no.user", "Invalid, no user part", false);
 	}
 
+	/**
+	 * @param string $email
+	 * @param string $checkText
+	 * @param boolean $expectSuccess
+	 */
 	public function internalCheck($email, $checkText, $expectSuccess) {
 		$field = new EmailField("MyEmail");
 		$field->setValue($email);

tests/forms/gridfield/GridField_URLHandlerTest.php

Doc Comments +3 added lines

@@ -111,6 +111,9 @@
 
 	protected $id;
 
+	/**
+	 * @param string $link
+	 */
 	public function __construct($gridField, $id, $link) {
 		$this->gridField = $gridField;
 		$this->id = $id;

tests/forms/NumericFieldTest.php

Doc Comments +3 added lines

@@ -21,6 +21,9 @@
 		return str_replace(' ', $nbsp, trim($input));
 	}
 
+	/**
+	 * @param string $locale
+	 */
 	protected function checkInputValidation($locale, $tests) {
 		i18n::set_locale($locale);
 		$field = new NumericField('Number');

tests/forms/uploadfield/AssetFieldTest.php

Doc Comments +4 added lines, -2 removed lines

@@ -298,7 +298,6 @@ 
 	 * Simulates a form post to the test controller with the specified file tuple (Filename, Hash, Variant)
 	 *
 	 * @param string $fileField Name of field to assign ids to
-	 * @param array $ids list of file IDs
 	 * @return boolean Array with key 'errors'
 	 */
 	protected function mockUploadFileSave($fileField, $filename, $hash, $variant = null) {
@@ -328,7 +327,7 @@ 
 	 * Simulates a file upload
 	 *
 	 * @param string $fileField Name of the field to mock upload for
-	 * @param array $tmpFileName Name of temporary file to upload
+	 * @param string $tmpFileName Name of temporary file to upload
 	 * @return SS_HTTPResponse form response
 	 */
 	protected function mockFileUpload($fileField, $tmpFileName) {
@@ -360,6 +359,9 @@ 
 		return $this->record;
 	}
 
+	/**
+	 * @param AssetFieldTest_Controller $controller
+	 */
 	function __construct($controller = null, $name = 'Form') {
 		if(empty($controller)) {
 			$controller = new AssetFieldTest_Controller();

tests/forms/uploadfield/UploadFieldTest.php

Doc Comments +7 added lines, -1 removed lines

@@ -936,7 +936,7 @@ 
 	 * Simulates a file upload
 	 *
 	 * @param string $fileField Name of the field to mock upload for
-	 * @param array $tmpFileName Name of temporary file to upload
+	 * @param string $tmpFileName Name of temporary file to upload
 	 * @return SS_HTTPResponse form response
 	 */
 	protected function mockFileUpload($fileField, $tmpFileName) {
@@ -948,6 +948,9 @@ 
 		);
 	}
 
+	/**
+	 * @param string $fileField
+	 */
 	protected function mockFileExists($fileField, $fileName) {
 		return $this->get(
 			"UploadFieldTest_Controller/Form/field/{$fileField}/fileexists?filename=".urlencode($fileName)
@@ -1075,6 +1078,9 @@ 
 		return $this->record;
 	}
 
+	/**
+	 * @param UploadFieldTest_Controller $controller
+	 */
 	function __construct($controller = null, $name = 'Form') {
 		if(empty($controller)) {
 			$controller = new UploadFieldTest_Controller();