silverstripe / silverstripe-framework

src/Dev/SapphireTest.php

Doc Comments +4 added lines, -4 removed lines

@@ -632,10 +632,10 @@ 
     /**
      * Assert that the matching email was sent since the last call to clearEmails()
      * All of the parameters can either be a string, or, if they start with "/", a PREG-compatible regular expression.
-     * @param $to
+     * @param string $to
      * @param $from
-     * @param $subject
-     * @param $content
+     * @param string $subject
+     * @param string $content
      * @return array Contains the keys: 'type', 'to', 'from', 'subject', 'content', 'plainContent', 'attachedFiles',
      *               'customHeaders', 'htmlContent', inlineImages'
      */
@@ -868,7 +868,7 @@ 
      * @param string $expectedSQL
      * @param string $actualSQL
      * @param string $message
-     * @param float|int $delta
+     * @param integer $delta
      * @param integer $maxDepth
      * @param boolean $canonicalize
      * @param boolean $ignoreCase

src/Dev/SapphireTestReporter.php

Doc Comments +4 added lines, -1 removed lines

@@ -368,7 +368,7 @@ 
      *
      * @param PHPUnit_Framework_Test $test current test that is being run
      * @param Exception $e PHPUnit error
-     * @return array
+     * @return string
      */
     private function getTestException(PHPUnit_Framework_Test $test, Exception $e)
     {
@@ -483,6 +483,9 @@ 
         echo "</div>";
     }
 
+    /**
+     * @param string $name
+     */
     protected function testNameToPhrase($name)
     {
         return ucfirst(preg_replace("/([a-z])([A-Z])/", "$1 $2", $name));

src/Forms/AssetField.php

Doc Comments +6 added lines, -2 removed lines

@@ -204,7 +204,7 @@ 
     /**
      * Determine if the target folder for new uploads in is visible the field UI.
      *
-     * @return boolean
+     * @return boolean|string
      */
     public function canPreviewFolder()
     {
@@ -279,6 +279,10 @@ 
         return $this->record;
     }
 
+    /**
+     * @param null|DataObject $value
+     * @param DataObject $record
+     */
     public function setValue($value, $record = null)
     {
         // Extract value from underlying record
@@ -392,7 +396,7 @@ 
     /**
      * Determine if the user has permission to upload.
      *
-     * @return boolean
+     * @return boolean|string
      */
     public function canUpload()
     {

src/Forms/CompositeField.php

Doc Comments +14 added lines

@@ -261,6 +261,9 @@ 
 
 
 
+    /**
+     * @param boolean $disabled
+     */
     public function setDisabled($disabled)
     {
         parent::setDisabled($disabled);
@@ -270,6 +273,9 @@ 
         return $this;
     }
 
+    /**
+     * @param boolean $readonly
+     */
     public function setReadonly($readonly)
     {
         parent::setReadonly($readonly);
@@ -362,6 +368,10 @@ 
         $this->children->removeByName($fieldName, $dataFieldOnly);
     }
 
+    /**
+     * @param string $fieldName
+     * @param FormField $newField
+     */
     public function replaceField($fieldName, $newField)
     {
         return $this->children->replaceField($fieldName, $newField);
@@ -437,6 +447,9 @@ 
         return $clone;
     }
 
+    /**
+     * @return boolean
+     */
     public function IsReadonly()
     {
         return $this->readonly;
@@ -447,6 +460,7 @@ 
      * the children collection. Doesn't work recursively.
      *
      * @param string|FormField
+     * @param string $field
      * @return int Position in children collection (first position starts with 0). Returns FALSE if the field can't
      *             be found.
      */

src/Forms/DateField.php

Doc Comments +6 added lines, -1 removed lines

@@ -103,6 +103,11 @@ 
      */
     protected $valueObj = null;
 
+    /**
+     * @param string $name
+     * @param string $title
+     * @param string $value
+     */
     public function __construct($name, $title = null, $value = null)
     {
         if (!$this->locale) {
@@ -311,7 +316,7 @@ 
     }
 
     /**
-     * @param mixed $class
+     * @param string $class
      * @return FormField
      */
     public function castedCopy($class)

src/Forms/DatetimeField.php

Doc Comments +20 added lines, -4 removed lines

@@ -70,6 +70,10 @@ 
      */
     protected $config;
 
+    /**
+     * @param string $name
+     * @param string $title
+     */
     public function __construct($name, $title = null, $value = "")
     {
         $this->config = $this->config()->default_config;
@@ -81,6 +85,9 @@ 
         parent::__construct($name, $title, $value);
     }
 
+    /**
+     * @param Form $form
+     */
     public function setForm($form)
     {
         parent::setForm($form);
@@ -92,6 +99,9 @@ 
         return $this;
     }
 
+    /**
+     * @param string $name
+     */
     public function setName($name)
     {
         parent::setName($name);
@@ -105,7 +115,7 @@ 
 
     /**
      * @param array $properties
-     * @return string
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText
      */
     public function FieldHolder($properties = array())
     {
@@ -120,7 +130,7 @@ 
 
     /**
      * @param array $properties
-     * @return string
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText
      */
     public function Field($properties = array())
     {
@@ -254,6 +264,9 @@ 
         return $this;
     }
 
+    /**
+     * @param boolean $bool
+     */
     public function setReadonly($bool)
     {
         parent::setReadonly($bool);
@@ -354,7 +367,7 @@ 
      * to set field-specific config options.
      *
      * @param string $name
-     * @param mixed $val
+     * @param string $val
      * @return $this
      */
     public function setConfig($name, $val)
@@ -374,7 +387,7 @@ 
      * to get field-specific config options.
      *
      * @param String $name Optional, returns the whole configuration array if empty
-     * @return mixed
+     * @return string|null
      */
     public function getConfig($name = null)
     {
@@ -385,6 +398,9 @@ 
         }
     }
 
+    /**
+     * @param RequiredFields $validator
+     */
     public function validate($validator)
     {
         $dateValid = $this->dateField->validate($validator);

src/Forms/Form.php

Doc Comments +4 added lines, -3 removed lines

@@ -541,7 +541,7 @@ 
      * The callback can opt out of handling specific responses by returning NULL,
      * in which case the default form behaviour will kick in.
      *
-     * @param $callback
+     * @param \Closure $callback
      * @return self
      */
     public function setValidationResponseCallback($callback)
@@ -603,7 +603,7 @@ 
     /**
      * Fields can have action to, let's check if anyone of the responds to $funcname them
      *
-     * @param SS_List|array $fields
+     * @param FieldList $fields
      * @param callable $funcName
      * @return FormField
      */
@@ -755,6 +755,7 @@ 
      * Set actions that are exempt from validation
      *
      * @param array
+     * @param string[] $actions
      * @return $this
      */
     public function setValidationExemptActions($actions)
@@ -1198,7 +1199,7 @@ 
      * If set to false (the default), then the form method is only used to construct the default
      * form.
      *
-     * @param $bool boolean
+     * @param boolean $bool boolean
      * @return $this
      */
     public function setStrictFormMethodCheck($bool)

src/Forms/FormAction.php

Doc Comments +1 added lines

@@ -214,6 +214,7 @@
      * Enable or disable the rendering of this action as a <button />
      *
      * @param boolean
+     * @param boolean $bool
      * @return $this
      */
     public function setUseButtonTag($bool)

src/Forms/FormField.php

Doc Comments +2 added lines, -3 removed lines

@@ -807,7 +807,6 @@ 
      * Set the field value.
      *
      * @param mixed $value
-     * @param null|array|DataObject $data {@see Form::loadDataFrom}
      * @return $this
      */
     public function setValue($value)
@@ -1251,7 +1250,7 @@ 
     /**
      * @param FormTransformation $transformation
      *
-     * @return mixed
+     * @return FormField
      */
     public function transform(FormTransformation $transformation)
     {
@@ -1362,7 +1361,7 @@ 
      * This function is used by the template processor. If you refer to a field as a $ variable, it
      * will return the $Field value.
      *
-     * @return string
+     * @return DBHTMLText
      */
     public function forTemplate()
     {