silverstripe / silverstripe-framework

src/Control/Controller.php

Doc Comments +3 added lines, -3 removed lines

@@ -147,6 +147,7 @@ 
      * {@inheritdoc}
      *
      * Also set the URLParams
+     * @param HTTPRequest $request
      */
     public function setRequest($request)
     {
@@ -523,7 +524,7 @@ 
      *
      * @param array $params
      *
-     * @return string
+     * @return DBHTMLText
      */
     public function render($params = null)
     {
@@ -702,7 +703,7 @@ 
      * Tests whether a redirection has been requested. If redirect() has been called, it will return
      * the URL redirected to. Otherwise, it will return null.
      *
-     * @return null|string
+     * @return boolean
      */
     public function redirectedTo()
     {
@@ -736,7 +737,6 @@ 
      *
      * Caution: All parameters are expected to be URI-encoded already.
      *
-     * @param string|array $arg,.. One or more link segments, or list of link segments as an array
      * @return string
      */
     public static function join_links($arg = null)

src/Control/CookieJar.php

Doc Comments +1 added lines, -1 removed lines

@@ -151,7 +151,7 @@
      * @see http://uk3.php.net/manual/en/function.setcookie.php
      *
      * @param string $name The name of the cookie
-     * @param string|array $value The value for the cookie to hold
+     * @param false|string $value The value for the cookie to hold
      * @param int $expiry The number of days until expiry
      * @param string $path The path to save the cookie on (falls back to site base)
      * @param string $domain The domain to make the cookie available on

src/Control/HTTPRequest.php

Doc Comments +2 added lines, -2 removed lines

@@ -458,9 +458,9 @@
      * it's only advisable to send small files through this method.
      *
      * @static
-     * @param $fileData
+     * @param string $fileData
      * @param $fileName
-     * @param null $mimeType
+     * @param string $mimeType
      * @return HTTPResponse
      */
     public static function send_file($fileData, $fileName, $mimeType = null)

src/Control/RequestHandler.php

Doc Comments +1 added lines, -1 removed lines

@@ -296,7 +296,7 @@
      *
      * Must not raise HTTPResponse_Exceptions - instead it should return
      *
-     * @param $request
+     * @param HTTPRequest $request
      * @param $action
      * @return HTTPResponse
      */

src/Control/RSS/RSSFeed.php

Doc Comments +1 added lines

@@ -248,6 +248,7 @@
      * via the standard template inclusion process.
      *
      * @param string
+     * @param string|null $template
      */
     public function setTemplate($template)
     {

src/Control/Session.php

Doc Comments +6 added lines

@@ -330,6 +330,9 @@ 
         }
     }
 
+    /**
+     * @param string $name
+     */
     public function inst_set($name, $val)
     {
         // Quicker execution path for "."-free names
@@ -379,6 +382,9 @@ 
         $diffVar[sizeof($var)-1] = $val;
     }
 
+    /**
+     * @param string $name
+     */
     public function inst_get($name)
     {
         // Quicker execution path for "."-free names

src/Core/ClassInfo.php

Doc Comments +5 added lines

@@ -297,6 +297,9 @@ 
 
     private static $method_from_cache = array();
 
+    /**
+     * @param string $method
+     */
     public static function has_method_from($class, $method, $compclass)
     {
         $lClass = strtolower($class);
@@ -322,6 +325,8 @@ 
 
     /**
      * @deprecated 4.0..5.0
+     * @param string $candidateClass
+     * @param string $fieldName
      */
     public static function table_for_object_field($candidateClass, $fieldName)
     {

src/Core/Config/Config.php

Doc Comments +7 added lines, -1 removed lines

@@ -521,12 +521,18 @@ 
 
     protected $extraConfigSources = array();
 
+    /**
+     * @param string $class
+     */
     public function extraConfigSourcesChanged($class)
     {
         unset($this->extraConfigSources[$class]);
         $this->cache->clean("__{$class}");
     }
 
+    /**
+     * @param integer $sourceOptions
+     */
     protected function getUncached($class, $name, $sourceOptions, &$result, $suppress, &$tags)
     {
         $tags[] = "__{$class}";
@@ -627,7 +633,7 @@ 
      * caching heavily here.
      *
      * @param $class string - The name of the class to get the value for
-     * @param $name string - The property to get the value for
+     * @param string $name string - The property to get the value for
      * @param int $sourceOptions Bitmask which can be set to some combintain of Config::UNINHERITED,
      *                           Config::FIRST_SET, and Config::EXCLUDE_EXTENSIONS.
      *

src/Core/Convert.php

Doc Comments +5 added lines, -4 removed lines

@@ -57,9 +57,9 @@ 
      *
      * @see http://www.w3.org/TR/REC-html40/types.html#type-cdata
      *
-     * @param array|string $val String to escape, or array of strings
+     * @param string $val String to escape, or array of strings
      *
-     * @return array|string
+     * @return string
      */
     public static function raw2htmlname($val)
     {
@@ -200,7 +200,7 @@ 
      * table, or column name. Supports encoding of multi identfiers separated by
      * a delimiter (e.g. ".")
      *
-     * @param string|array $identifier The identifier to escape. E.g. 'SiteTree.Title' or list of identifiers
+     * @param string $identifier The identifier to escape. E.g. 'SiteTree.Title' or list of identifiers
      * to be joined via the separator.
      * @param string $separator The string that delimits subsequent identifiers
      * @return string The escaped identifier. E.g. '"SiteTree"."Title"'
@@ -301,6 +301,7 @@ 
      * call this function directly, Please use {@link Convert::xml2array()}
      *
      * @param SimpleXMLElement
+     * @param SimpleXMLElement $xml
      *
      * @return mixed
      */
@@ -514,7 +515,7 @@ 
      * - IDField => idField
      * - iDField => iDField
      *
-     * @param $str
+     * @param string $str
      * @return string
      */
     public static function upperCamelToLowerCamel($str)