Completed
Pull Request — master (#6604)
by Andrew
11:43
created
tests/php/Forms/AssetFieldTest/TestForm.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
 
25 25
     /**
26 26
      * @skipUpgrade
27
-     * @param null   $controller
27
+     * @param TestController   $controller
28 28
      * @param string $name
29 29
      */
30 30
     public function __construct($controller = null, $name = 'Form')
Please login to merge, or discard this patch.
tests/php/Forms/DropdownFieldTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -399,7 +399,7 @@
 block discarded – undo
399 399
      * string of HTML.
400 400
      *
401 401
      * @param  string $html HTML to scan for elements
402
-     * @return SimpleXMLElement
402
+     * @return \SimpleXMLElement
403 403
      */
404 404
     public function findOptionElements($html)
405 405
     {
Please login to merge, or discard this patch.
php/Forms/GridField/GridField_URLHandlerTest/TestComponent_ItemRequest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -20,6 +20,9 @@
 block discarded – undo
20 20
 
21 21
     protected $id;
22 22
 
23
+    /**
24
+     * @param string $link
25
+     */
23 26
     public function __construct($gridField, $id, $link)
24 27
     {
25 28
         $this->gridField = $gridField;
Please login to merge, or discard this patch.
tests/php/Forms/NumericFieldTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -29,6 +29,9 @@
 block discarded – undo
29 29
         return str_replace(' ', $nbsp, trim($input));
30 30
     }
31 31
 
32
+    /**
33
+     * @param string $locale
34
+     */
32 35
     protected function checkInputValidation($locale, $tests)
33 36
     {
34 37
         i18n::set_locale($locale);
Please login to merge, or discard this patch.
tests/php/Forms/UploadFieldTest.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1023,7 +1023,7 @@  discard block
 block discarded – undo
1023 1023
      * Simulates a file upload
1024 1024
      *
1025 1025
      * @param  string $fileField   Name of the field to mock upload for
1026
-     * @param  array  $tmpFileName Name of temporary file to upload
1026
+     * @param  string  $tmpFileName Name of temporary file to upload
1027 1027
      * @return HTTPResponse form response
1028 1028
      */
1029 1029
     protected function mockFileUpload($fileField, $tmpFileName)
@@ -1036,6 +1036,9 @@  discard block
 block discarded – undo
1036 1036
         );
1037 1037
     }
1038 1038
 
1039
+    /**
1040
+     * @param string $fileField
1041
+     */
1039 1042
     protected function mockFileExists($fileField, $fileName)
1040 1043
     {
1041 1044
         return $this->get(
Please login to merge, or discard this patch.
tests/php/ORM/ChangeSetTest/Permissions.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -39,6 +39,9 @@
 block discarded – undo
39 39
         return $this->can(__FUNCTION__, $member, $context);
40 40
     }
41 41
 
42
+    /**
43
+     * @param string $perm
44
+     */
42 45
     public function can($perm, $member = null, $context = array())
43 46
     {
44 47
         $perms = [
Please login to merge, or discard this patch.
tests/php/ORM/HierarchyTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -670,7 +670,7 @@
 block discarded – undo
670 670
      * Get the HTML class attribute from a node in the sitetree
671 671
      *
672 672
      * @param  $html
673
-     * @param  $node
673
+     * @param  DataObject|null $node
674 674
      * @return string
675 675
      */
676 676
     protected function getNodeClassFromTree($html, $node)
Please login to merge, or discard this patch.
tests/php/Security/GroupTest/MemberForm.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -9,6 +9,10 @@
 block discarded – undo
9 9
 class MemberForm extends Form
10 10
 {
11 11
 
12
+    /**
13
+     * @param \SilverStripe\Control\Controller $controller
14
+     * @param string $name
15
+     */
12 16
     public function __construct($controller, $name)
13 17
     {
14 18
         $fields = TestMember::singleton()->getCMSFields();
Please login to merge, or discard this patch.
tests/php/Security/SecurityTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -676,6 +676,8 @@  discard block
 block discarded – undo
676 676
     /**
677 677
      * Execute a log-in form using Director::test().
678 678
      * Helper method for the tests above
679
+     * @param string $email
680
+     * @param string $password
679 681
      */
680 682
     public function doTestLoginForm($email, $password, $backURL = 'test/link')
681 683
     {
@@ -697,6 +699,8 @@  discard block
 block discarded – undo
697 699
 
698 700
     /**
699 701
      * Helper method to execute a change password form
702
+     * @param string $oldPassword
703
+     * @param string $newPassword
700 704
      */
701 705
     public function doTestChangepasswordForm($oldPassword, $newPassword)
702 706
     {
Please login to merge, or discard this patch.