Completed
Push — 3.6 ( 598edd...b9c29e )
by Robbie
23s queued 10s
created
control/ContentNegotiator.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -97,6 +97,7 @@
 block discarded – undo
97 97
 	/**
98 98
 	 * Returns true if negotation is enabled for the given response.
99 99
 	 * By default, negotiation is only enabled for pages that have the xml header.
100
+	 * @param SS_HTTPResponse $response
100 101
 	 */
101 102
 	public static function enabled_for($response) {
102 103
 		$contentType = $response->getHeader("Content-Type");
Please login to merge, or discard this patch.
control/HTTP.php 1 patch
Doc Comments   +11 added lines, -1 removed lines patch added patch discarded remove patch
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
 	 * @param string|callable $code Either a string that can evaluate to an expression
100 100
 	 * to rewrite links (depreciated), or a callable that takes a single
101 101
 	 * parameter and returns the rewritten URL
102
-	 * @return The content with all links rewritten as per the logic specified in $code
102
+	 * @return string content with all links rewritten as per the logic specified in $code
103 103
 	 */
104 104
 	public static function urlRewriter($content, $code) {
105 105
 		if(!is_callable($code)) {
@@ -243,6 +243,9 @@  discard block
 block discarded – undo
243 243
 		return count($result) ? $result : null;
244 244
 	}
245 245
 
246
+	/**
247
+	 * @param string $content
248
+	 */
246 249
 	public static function getLinksIn($content) {
247 250
 		return self::findByTagAndAttribute($content, array("a" => "href"));
248 251
 	}
@@ -285,6 +288,7 @@  discard block
 block discarded – undo
285 288
 
286 289
 	/**
287 290
 	 * Set the maximum age of this page in web caches, in seconds
291
+	 * @param integer $age
288 292
 	 */
289 293
 	public static function set_cache_age($age) {
290 294
 		self::$cache_age = $age;
@@ -296,11 +300,17 @@  discard block
 block discarded – undo
296 300
 			self::$modification_date = $timestamp;
297 301
 	}
298 302
 
303
+	/**
304
+	 * @param integer $timestamp
305
+	 */
299 306
 	public static function register_modification_timestamp($timestamp) {
300 307
 		if($timestamp > self::$modification_date)
301 308
 			self::$modification_date = $timestamp;
302 309
 	}
303 310
 
311
+	/**
312
+	 * @param string $etag
313
+	 */
304 314
 	public static function register_etag($etag) {
305 315
 		if (0 !== strpos($etag, '"')) {
306 316
 			$etag = sprintf('"%s"', $etag);
Please login to merge, or discard this patch.
dev/Debug.php 1 patch
Doc Comments   +14 added lines, -7 removed lines patch added patch discarded remove patch
@@ -226,6 +226,12 @@  discard block
 block discarded – undo
226 226
 		set_exception_handler('exceptionHandler');
227 227
 	}
228 228
 
229
+	/**
230
+	 * @param integer $errno
231
+	 * @param string $errstr
232
+	 * @param string $errfile
233
+	 * @param integer $errline
234
+	 */
229 235
 	public static function noticeHandler($errno, $errstr, $errfile, $errline, $errcontext) {
230 236
 		if(error_reporting() == 0) return;
231 237
 		ini_set('display_errors', 0);
@@ -252,10 +258,10 @@  discard block
 block discarded – undo
252 258
 	/**
253 259
 	 * Handle a non-fatal warning error thrown by PHP interpreter.
254 260
 	 *
255
-	 * @param unknown_type $errno
256
-	 * @param unknown_type $errstr
257
-	 * @param unknown_type $errfile
258
-	 * @param unknown_type $errline
261
+	 * @param integer $errno
262
+	 * @param string $errstr
263
+	 * @param string $errfile
264
+	 * @param integer $errline
259 265
 	 * @param unknown_type $errcontext
260 266
 	 */
261 267
 	public static function warningHandler($errno, $errstr, $errfile, $errline, $errcontext) {
@@ -286,8 +292,8 @@  discard block
 block discarded – undo
286 292
 	 *
287 293
 	 * Runtime execution dies immediately once the error is generated.
288 294
 	 *
289
-	 * @param unknown_type $errno
290
-	 * @param unknown_type $errstr
295
+	 * @param integer $errno
296
+	 * @param string $errstr
291 297
 	 * @param unknown_type $errfile
292 298
 	 * @param unknown_type $errline
293 299
 	 * @param unknown_type $errcontext
@@ -327,7 +333,7 @@  discard block
 block discarded – undo
327 333
 	 *                                     or "tech-speak". Used in the HTTP Header and ajax responses.
328 334
 	 * @param string $friendlyErrorDetail Detailed user-focused message. Is just used if no {@link ErrorPage} is found
329 335
 	 *                                    for this specific status code.
330
-	 * @return string HTML error message for non-ajax requests, plaintext for ajax-request.
336
+	 * @return boolean HTML error message for non-ajax requests, plaintext for ajax-request.
331 337
 	 */
332 338
 	public static function friendlyError($statusCode=500, $friendlyErrorMessage=null, $friendlyErrorDetail=null) {
333 339
 		// Ensure the error message complies with the HTTP 1.1 spec
@@ -399,6 +405,7 @@  discard block
 block discarded – undo
399 405
 	 * @param unknown_type $errfile
400 406
 	 * @param unknown_type $errline
401 407
 	 * @param unknown_type $errcontext
408
+	 * @param string $errtype
402 409
 	 */
403 410
 	public static function showError($errno, $errstr, $errfile, $errline, $errcontext, $errtype) {
404 411
 		if(!headers_sent()) {
Please login to merge, or discard this patch.
dev/FixtureFactory.php 1 patch
Doc Comments   +5 added lines, -4 removed lines patch added patch discarded remove patch
@@ -117,6 +117,7 @@  discard block
 block discarded – undo
117 117
 	/**
118 118
 	 * Return all of the IDs in the fixture of a particular class name.
119 119
 	 *
120
+	 * @param string $class
120 121
 	 * @return A map of fixture-identifier => object-id
121 122
 	 */
122 123
 	public function getIds($class) {
@@ -131,6 +132,7 @@  discard block
 block discarded – undo
131 132
 	 * @param String
132 133
 	 * @param String $identifier
133 134
 	 * @param Int $databaseId
135
+	 * @param string $class
134 136
 	 */
135 137
 	public function setId($class, $identifier, $databaseId) {
136 138
 		$this->fixtures[$class][$identifier] = $databaseId;
@@ -140,8 +142,8 @@  discard block
 block discarded – undo
140 142
 	/**
141 143
 	 * Get an object from the fixture.
142 144
 	 *
143
-	 * @param $class The data class, as specified in your fixture file.  Parent classes won't work
144
-	 * @param $identifier The identifier string, as provided in your fixture file
145
+	 * @param string $class The data class, as specified in your fixture file.  Parent classes won't work
146
+	 * @param string $identifier The identifier string, as provided in your fixture file
145 147
 	 */
146 148
 	public function get($class, $identifier) {
147 149
 		$id = $this->getId($class, $identifier);
@@ -161,7 +163,7 @@  discard block
 block discarded – undo
161 163
 	 * or {@link createRaw()}, both from the internal fixture mapping and the database.
162 164
 	 * If the $class argument is set, limit clearing to items of this class.
163 165
 	 *
164
-	 * @param String $class
166
+	 * @param string $limitToClass
165 167
 	 */
166 168
 	public function clear($limitToClass = null) {
167 169
 		$classes = ($limitToClass) ? array($limitToClass) : array_keys($this->fixtures);
@@ -202,7 +204,6 @@  discard block
 block discarded – undo
202 204
 	 * Parse a value from a fixture file.  If it starts with =>
203 205
 	 * it will get an ID from the fixture dictionary
204 206
 	 *
205
-	 * @param String $fieldVal
206 207
 	 * @return String Fixture database ID, or the original value
207 208
 	 */
208 209
 	protected function parseValue($value) {
Please login to merge, or discard this patch.
filesystem/Folder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@
 block discarded – undo
42 42
 	 *
43 43
 	 * @param $folderPath string Absolute or relative path to the file.
44 44
 	 *  If path is relative, its interpreted relative to the "assets/" directory.
45
-	 * @return Folder|null
45
+	 * @return null|DataObject
46 46
 	 */
47 47
 	public static function find_or_make($folderPath) {
48 48
 		// Create assets directory, if it is missing
Please login to merge, or discard this patch.
i18n/i18nTextCollector.php 1 patch
Doc Comments   +6 added lines, -1 removed lines patch added patch discarded remove patch
@@ -709,7 +709,8 @@  discard block
 block discarded – undo
709 709
 	 * Input for langArrayCodeForEntitySpec() should be suitable for insertion
710 710
 	 * into single-quoted strings, so needs to be escaped already.
711 711
 	 *
712
-	 * @param string $entity The entity name, e.g. CMSMain.BUTTONSAVE
712
+	 * @param string $entitySpec The entity name, e.g. CMSMain.BUTTONSAVE
713
+	 * @param string $locale
713 714
 	 */
714 715
 	public function langArrayCodeForEntitySpec($entityFullName, $entitySpec, $locale) {
715 716
 		$php = '';
@@ -772,6 +773,9 @@  discard block
 block discarded – undo
772 773
 		return true;
773 774
 	}
774 775
 
776
+	/**
777
+	 * @param string $locale
778
+	 */
775 779
 	public function getYaml($entities, $locale) {
776 780
 		// Use the Zend copy of this script to prevent class conflicts when RailsYaml is included
777 781
 		require_once 'thirdparty/zend_translate_railsyaml/library/Translate/Adapter/thirdparty/sfYaml/lib'
@@ -846,6 +850,7 @@  discard block
 block discarded – undo
846 850
 
847 851
 	/**
848 852
 	 * Parses a template and returns any translatable entities
853
+	 * @param string $template
849 854
 	 */
850 855
 	public static function GetTranslatables($template) {
851 856
 		self::$entities = array();
Please login to merge, or discard this patch.
model/Aggregate.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,6 +47,7 @@  discard block
 block discarded – undo
47 47
 	/**
48 48
 	 * Clear the aggregate cache for a given type, or pass nothing to clear all aggregate caches.
49 49
 	 * {@link $class} is just effective if the cache backend supports tags.
50
+	 * @param string $class
50 51
 	 */
51 52
 	public static function flushCache($class=null) {
52 53
 		$cache = self::cache();
@@ -85,7 +86,7 @@  discard block
 block discarded – undo
85 86
 	 * Build the SQLSelect to calculate the aggregate
86 87
 	 * This is a seperate function so that subtypes of Aggregate can change just this bit
87 88
 	 * @param string $attr - the SQL field statement for selection (i.e. "MAX(LastUpdated)")
88
-	 * @return SQLSelect
89
+	 * @return DataList
89 90
 	 */
90 91
 	protected function query($attr) {
91 92
 		$query = DataList::create($this->type)->where($this->filter);
Please login to merge, or discard this patch.
model/DataQuery.php 1 patch
Doc Comments   +10 added lines, -2 removed lines patch added patch discarded remove patch
@@ -44,6 +44,7 @@  discard block
 block discarded – undo
44 44
 	 * Create a new DataQuery.
45 45
 	 *
46 46
 	 * @param String The name of the DataObject class that you wish to query
47
+	 * @param string $dataClass
47 48
 	 */
48 49
 	public function __construct($dataClass) {
49 50
 		$this->dataClass = $dataClass;
@@ -166,7 +167,7 @@  discard block
 block discarded – undo
166 167
 	/**
167 168
 	 * Ensure that the query is ready to execute.
168 169
 	 *
169
-	 * @param array|null $queriedColumns Any columns to filter the query by
170
+	 * @param string[] $queriedColumns Any columns to filter the query by
170 171
 	 * @return SQLQuery The finalised sql query
171 172
 	 */
172 173
 	public function getFinalisedQuery($queriedColumns = null) {
@@ -664,7 +665,7 @@  discard block
 block discarded – undo
664 665
 	 * mappings to the query object state. This has to be called
665 666
 	 * in any overloaded {@link SearchFilter->apply()} methods manually.
666 667
 	 *
667
-	 * @param String|array $relation The array/dot-syntax relation to follow
668
+	 * @param string $relation The array/dot-syntax relation to follow
668 669
 	 * @return The model class of the related item
669 670
 	 */
670 671
 	public function applyRelation($relation) {
@@ -844,6 +845,7 @@  discard block
 block discarded – undo
844 845
 
845 846
 	/**
846 847
 	 * Set an arbitrary query parameter, that can be used by decorators to add additional meta-data to the query.
848
+	 * @param string $key
847 849
 	 */
848 850
 	public function getQueryParam($key) {
849 851
 		if(isset($this->queryParams[$key])) return $this->queryParams[$key];
@@ -878,6 +880,9 @@  discard block
 block discarded – undo
878 880
 	 */
879 881
 	protected $whereQuery;
880 882
 
883
+	/**
884
+	 * @param string $connective
885
+	 */
881 886
 	public function __construct(DataQuery $base, $connective) {
882 887
 		$this->dataClass = $base->dataClass;
883 888
 		$this->query = $base->query;
@@ -887,6 +892,9 @@  discard block
 block discarded – undo
887 892
 		$base->where($this);
888 893
 	}
889 894
 
895
+	/**
896
+	 * @param string $filter
897
+	 */
890 898
 	public function where($filter) {
891 899
 		if($filter) {
892 900
 			$this->whereQuery->addWhere($filter);
Please login to merge, or discard this patch.
model/fieldtypes/Currency.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -23,6 +23,9 @@  discard block
 block discarded – undo
23 23
 	 */
24 24
 	private static $currency_symbol = '$';
25 25
 
26
+	/**
27
+	 * @param string $name
28
+	 */
26 29
 	public function __construct($name = null, $wholeSize = 9, $decimalSize = 2, $defaultValue = 0) {
27 30
 		parent::__construct($name, $wholeSize, $decimalSize, $defaultValue);
28 31
 	}
@@ -46,6 +49,9 @@  discard block
 block discarded – undo
46 49
 		else return $val;
47 50
 	}
48 51
 
52
+	/**
53
+	 * @param string $value
54
+	 */
49 55
 	public function setValue($value, $record = null) {
50 56
 		$matches = null;
51 57
 		if(is_numeric($value)) {
Please login to merge, or discard this patch.