silverstripe / silverstripe-framework

src/Forms/TimeField.php

Doc Comments +2 added lines, -2 removed lines

@@ -247,7 +247,7 @@ 
     /**
      * Assign value posted from form submission
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */
@@ -264,7 +264,7 @@ 
     /**
      * Set time assigned from database value
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */

src/Control/Email/Email.php

Doc Comments +13 added lines, -13 removed lines

@@ -135,12 +135,12 @@ 
 
     /**
      * Email constructor.
-     * @param string|array|null $from
-     * @param string|array|null $to
+     * @param string $from
+     * @param string $to
      * @param string|null $subject
      * @param string|null $body
-     * @param string|array|null $cc
-     * @param string|array|null $bcc
+     * @param string $cc
+     * @param string $bcc
      * @param string|null $returnPath
      */
     public function __construct(
@@ -226,7 +226,7 @@ 
     }
 
     /**
-     * @param string|array $address
+     * @param string $address
      * @param string|null $name
      * @return $this
      */
@@ -238,7 +238,7 @@ 
     }
 
     /**
-     * @return array
+     * @return string
      */
     public function getSender()
     {
@@ -303,7 +303,7 @@ 
     }
 
     /**
-     * @param string|array $address
+     * @param string $address
      * @param string|null $name
      * @return $this
      */
@@ -335,7 +335,7 @@ 
     }
 
     /**
-     * @param string|array $address
+     * @param string $address
      * @param string|null $name
      * @return $this
      */
@@ -367,7 +367,7 @@ 
     }
 
     /**
-     * @param string|array $address
+     * @param string $address
      * @param string|null $name
      * @return $this
      */
@@ -384,7 +384,7 @@ 
     }
 
     /**
-     * @param string|array $address
+     * @param string $address
      * @param string|null $name
      * @return $this
      */
@@ -396,7 +396,7 @@ 
     }
 
     /**
-     * @param string|array $address
+     * @param string $address
      * @param string|null $name
      * @return $this
      */
@@ -502,7 +502,7 @@ 
     }
 
     /**
-     * @param string|array $name The data name to add or array to names => value
+     * @param string $name The data name to add or array to names => value
      * @param string|null $value The value of the data to add
      * @return $this
      */
@@ -728,7 +728,7 @@ 
     }
 
     /**
-     * @return Swift_MimePart|false
+     * @return \Swift_Mime_MimeEntity
      */
     public function findPlainPart()
     {

src/Control/Session.php

Doc Comments +8 added lines

@@ -330,6 +330,9 @@ 
         }
     }
 
+    /**
+     * @param string $name
+     */
     public function inst_set($name, $val)
     {
         // Quicker execution path for "."-free names
@@ -379,6 +382,11 @@ 
         $diffVar[sizeof($var)-1] = $val;
     }
 
+    /**
+     * @param string $name
+     *
+     * @return string
+     */
     public function inst_get($name)
     {
         // Quicker execution path for "."-free names

src/Core/Manifest/ClassManifest.php

Doc Comments +2 added lines, -2 removed lines

@@ -225,7 +225,7 @@ 
     /**
      * Returns a lowercase array of all the class names in the manifest.
      *
-     * @return array
+     * @return string[]
      */
     public function getClassNames()
     {
@@ -256,7 +256,7 @@ 
      * Returns an array containing all the descendants (direct and indirect)
      * of a class.
      *
-     * @param  string|object $class
+     * @param  string $class
      * @return array
      */
     public function getDescendantsOf($class)

src/ORM/DataObject.php

Doc Comments +8 added lines, -7 removed lines

@@ -2176,7 +2176,7 @@ 
      * Called by {@link __get()} and any getFieldName() methods you might create.
      *
      * @param string $field The name of the field
-     * @return mixed The field value
+     * @return string|null The field value
      */
     public function getField($field)
     {
@@ -2458,6 +2458,7 @@ 
 
     /**
      * {@inheritdoc}
+     * @param string $field
      */
     public function castingHelper($field)
     {
@@ -2586,7 +2587,7 @@ 
 
     /**
      * @param Member $member
-     * @return boolean
+     * @return boolean|string
      */
     public function canView($member = null)
     {
@@ -2599,7 +2600,7 @@ 
 
     /**
      * @param Member $member
-     * @return boolean
+     * @return boolean|string
      */
     public function canEdit($member = null)
     {
@@ -2612,7 +2613,7 @@ 
 
     /**
      * @param Member $member
-     * @return boolean
+     * @return boolean|string
      */
     public function canDelete($member = null)
     {
@@ -2627,7 +2628,7 @@ 
      * @param Member $member
      * @param array $context Additional context-specific data which might
      * affect whether (or where) this object could be created.
-     * @return boolean
+     * @return boolean|string
      */
     public function canCreate($member = null, $context = array())
     {
@@ -2742,7 +2743,7 @@ 
      * Traverses to a field referenced by relationships between data objects, returning the value
      * The path to the related field is specified with dot separated syntax (eg: Parent.Child.Child.FieldName)
      *
-     * @param $fieldName string
+     * @param string $fieldName string
      * @return string | null - will return null on a missing value
      */
     public function relField($fieldName)
@@ -2820,7 +2821,7 @@ 
      * @param string $callerClass The class of objects to be returned
      * @param string|array $filter A filter to be inserted into the WHERE clause.
      * Supports parameterised queries. See SQLSelect::addWhere() for syntax examples.
-     * @param string|array $sort A sort expression to be inserted into the ORDER
+     * @param string $sort A sort expression to be inserted into the ORDER
      * BY clause.  If omitted, self::$default_sort will be used.
      * @param string $join Deprecated 3.0 Join clause. Use leftJoin($table, $joinClause) instead.
      * @param string|array $limit A limit expression to be inserted into the LIMIT clause.

src/ORM/FieldType/DBField.php

Doc Comments +2 added lines, -2 removed lines

@@ -175,7 +175,7 @@ 
     /**
      * Returns the value of this field.
      *
-     * @return mixed
+     * @return string
      */
     public function getValue()
     {
@@ -533,7 +533,7 @@ 
     }
 
     /**
-     * @param array $value
+     * @param string $value
      * @return $this
      */
     public function setArrayValue($value)

tests/php/Core/Manifest/ManifestFileFinderTest.php

Doc Comments +4 added lines

@@ -19,6 +19,10 @@
         parent::__construct();
     }
 
+    /**
+     * @param ManifestFileFinder $finder
+     * @param string[] $expect
+     */
     public function assertFinderFinds($finder, $expect, $message = null)
     {
         $found = $finder->find($this->base);

tests/php/Core/Manifest/ThemeResourceLoaderTest.php

Doc Comments +6 added lines

@@ -279,6 +279,9 @@ 
         );
     }
 
+    /**
+     * @param string[] $templates
+     */
     protected function createTestTemplates($templates)
     {
         foreach ($templates as $template) {
@@ -286,6 +289,9 @@ 
         }
     }
 
+    /**
+     * @param string[] $templates
+     */
     protected function removeTestTemplates($templates)
     {
         foreach ($templates as $template) {

tests/php/Core/Startup/ParameterConfirmationTokenTest.php

Doc Comments +3 added lines

@@ -10,6 +10,9 @@
 class ParameterConfirmationTokenTest extends SapphireTest
 {
 
+    /**
+     * @param string $part
+     */
     private function addPart($answer, $slash, $part)
     {
         $bare = str_replace('/', '', $part);