silverstripe / silverstripe-framework

src/Forms/FileField.php

Doc Comments +1 added lines, -1 removed lines

@@ -238,7 +238,7 @@
 
     /**
      * @param array $properties
-     * @return string
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText
      */
     public function Field($properties = array())
     {

src/Forms/UploadReceiver.php

Doc Comments -1 removed lines

@@ -97,7 +97,6 @@
      * for each of these categories
      *
      * @param string $category Category name
-     * @param string,... $categories Additional category names
      * @return $this
      */
     public function setAllowedFileCategories($category)

src/Dev/Deprecation.php

Doc Comments +2 added lines, -2 removed lines

@@ -75,7 +75,7 @@ 
      * greater than or equal to this version, a message will be raised
      *
      * @static
-     * @param $ver string -
+     * @param string $ver string -
      *     A php standard version string, see http://php.net/manual/en/function.version-compare.php for details.
      * @param null $forModule string -
      *    The name of a module. The passed version will be used as the check value for
@@ -141,7 +141,7 @@ 
     /**
      * Determine if deprecation notices should be displayed
      *
-     * @return bool
+     * @return boolean|string
      */
     public static function get_enabled()
     {

admin/code/GroupImportForm.php

Doc Comments +4 added lines

@@ -24,6 +24,10 @@
      */
     protected $group;
 
+    /**
+     * @param SecurityAdmin $controller
+     * @param string $name
+     */
     public function __construct($controller, $name, $fields = null, $actions = null, $validator = null)
     {
         if (!$fields) {

admin/code/MemberImportForm.php

Doc Comments +5 added lines, -1 removed lines

@@ -25,6 +25,10 @@ 
      */
     protected $group;
 
+    /**
+     * @param SecurityAdmin $controller
+     * @param string $name
+     */
     public function __construct($controller, $name, $fields = null, $actions = null, $validator = null)
     {
         if (!$fields) {
@@ -127,7 +131,7 @@ 
     }
 
     /**
-     * @param $group Group
+     * @param Group $group Group
      */
     public function setGroup($group)
     {

admin/code/SecurityAdmin.php

Doc Comments +2 added lines, -2 removed lines

@@ -260,7 +260,7 @@ 
     /**
      * @see SecurityAdmin_MemberImportForm
      *
-     * @return Form
+     * @return null|MemberImportForm
      */
     public function MemberImportForm()
     {
@@ -297,7 +297,7 @@ 
      * @see SecurityAdmin_MemberImportForm
      *
      * @skipUpgrade
-     * @return Form
+     * @return null|GroupImportForm
      */
     public function GroupImportForm()
     {

tests/behat/features/bootstrap/SilverStripe/Framework/Test/Behaviour/CmsFormsContext.php

Doc Comments +1 added lines

@@ -38,6 +38,7 @@
 
     /**
      * Get Mink session from MinkContext
+     * @return \Behat\Mink\Session
      */
     public function getSession($name = null)
     {

tests/php/Assets/Storage/AssetStoreTest/TestStore.php

Doc Comments +6 added lines

@@ -163,6 +163,9 @@ 
     }
 
 
+    /**
+     * @param string $fileID
+     */
     public function getOriginalFilename($fileID)
     {
         return parent::getOriginalFilename($fileID);
@@ -173,6 +176,9 @@ 
         return parent::removeVariant($fileID);
     }
 
+    /**
+     * @param null|string $variant
+     */
     public function getDefaultConflictResolution($variant)
     {
         return parent::getDefaultConflictResolution($variant);

tests/php/Core/ObjectTest/Extending.php

Doc Comments +17 added lines

@@ -12,11 +12,22 @@ 
         Extending_Extension::class,
     );
 
+    /**
+     * @param integer $first
+     * @param integer $second
+     * @param integer $third
+     */
     public function getResults(&$first, &$second, &$third)
     {
         // Before extending should be invoked second
         $this->beforeExtending(
             'updateResult',
+
+            /**
+             * @param integer $first
+             * @param integer $second
+             * @param integer $third
+             */
             function (&$first, &$second, &$third) {
                 if ($first === 1 && $second === 2 && $third === 3) {
                     $first = 11;
@@ -31,6 +42,12 @@ 
         // After extending should be invoked fourth
         $this->afterExtending(
             'updateResult',
+
+            /**
+             * @param integer $first
+             * @param integer $second
+             * @param integer $third
+             */
             function (&$first, &$second, &$third) {
                 if ($first === 21 && $second === 22 && $third = 23) {
                     $first = 31;