Completed
Pull Request — master (#5771)
by Florian
12:04
created
forms/gridfield/GridFieldExportButton.php 1 patch
Doc Comments   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -86,6 +86,7 @@  discard block
 block discarded – undo
86 86
 
87 87
 	/**
88 88
 	 * Handle the export, for both the action button and the URL
89
+ 	 * @param GridField $gridField
89 90
  	 */
90 91
 	public function handleExport($gridField, $request = null) {
91 92
 		$now = Date("d-m-Y-H-i");
@@ -100,7 +101,7 @@  discard block
 block discarded – undo
100 101
 	 * Generate export fields for CSV.
101 102
 	 *
102 103
 	 * @param GridField $gridField
103
-	 * @return array
104
+	 * @return string
104 105
 	 */
105 106
 	public function generateExportFileData($gridField) {
106 107
 		$csvColumns = ($this->exportColumns)
@@ -227,6 +228,7 @@  discard block
 block discarded – undo
227 228
 
228 229
 	/**
229 230
 	 * @param boolean
231
+	 * @param boolean $bool
230 232
 	 */
231 233
 	public function setCsvHasHeader($bool) {
232 234
 		$this->csvHasHeader = $bool;
Please login to merge, or discard this patch.
forms/gridfield/GridFieldFilterHeader.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -23,6 +23,7 @@
 block discarded – undo
23 23
 	 *
24 24
 	 * By default, this is set to true so that it's clearer what's happening, but the predefined
25 25
 	 * {@link GridFieldConfig} subclasses set this to false for flexibility.
26
+	 * @param boolean $throwExceptionOnBadDataType
26 27
 	 */
27 28
 	public function setThrowExceptionOnBadDataType($throwExceptionOnBadDataType) {
28 29
 		$this->throwExceptionOnBadDataType = $throwExceptionOnBadDataType;
Please login to merge, or discard this patch.
forms/gridfield/GridFieldPageCount.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@
 block discarded – undo
23 23
 	protected $itemClass = 'GridFieldPageCount';
24 24
 
25 25
 	/**
26
-	 * @param string $targetFrament The fragment indicating the placement of this page count
26
+	 * @param string $targetFragment The fragment indicating the placement of this page count
27 27
 	 */
28 28
 	public function __construct($targetFragment = 'before') {
29 29
 		$this->targetFragment = $targetFragment;
Please login to merge, or discard this patch.
forms/gridfield/GridFieldPaginator.php 1 patch
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -50,6 +50,7 @@  discard block
 block discarded – undo
50 50
 	 *
51 51
 	 * By default, this is set to true so that it's clearer what's happening, but the predefined
52 52
 	 * {@link GridFieldConfig} subclasses set this to false for flexibility.
53
+	 * @param boolean $throwExceptionOnBadDataType
53 54
 	 */
54 55
 	public function setThrowExceptionOnBadDataType($throwExceptionOnBadDataType) {
55 56
 		$this->throwExceptionOnBadDataType = $throwExceptionOnBadDataType;
@@ -65,6 +66,7 @@  discard block
 block discarded – undo
65 66
 	/**
66 67
 	 * Check that this dataList is of the right data type.
67 68
 	 * Returns false if it's a bad data type, and if appropriate, throws an exception.
69
+	 * @param SS_List $dataList
68 70
 	 */
69 71
 	protected function checkDataType($dataList) {
70 72
 		if($dataList instanceof SS_Limitable) {
Please login to merge, or discard this patch.
forms/gridfield/GridFieldPrintButton.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 	 *
67 67
 	 * @param GridField
68 68
 	 *
69
-	 * @return array
69
+	 * @return string[]
70 70
 	 */
71 71
 	public function getActions($gridField) {
72 72
 		return array('print');
@@ -100,6 +100,7 @@  discard block
 block discarded – undo
100 100
 
101 101
 	/**
102 102
 	 * Handle the print, for both the action button and the URL
103
+ 	 * @param GridField $gridField
103 104
  	 */
104 105
 	public function handlePrint($gridField, $request = null) {
105 106
 		set_time_limit(60);
Please login to merge, or discard this patch.
forms/gridfield/GridFieldSortableHeader.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,6 +29,7 @@  discard block
 block discarded – undo
29 29
 	 *
30 30
 	 * By default, this is set to true so that it's clearer what's happening, but the predefined
31 31
 	 * {@link GridFieldConfig} subclasses set this to false for flexibility.
32
+	 * @param boolean $throwExceptionOnBadDataType
32 33
 	 */
33 34
 	public function setThrowExceptionOnBadDataType($throwExceptionOnBadDataType) {
34 35
 		$this->throwExceptionOnBadDataType = $throwExceptionOnBadDataType;
@@ -61,7 +62,7 @@  discard block
 block discarded – undo
61 62
 	 * Specify sortings with fieldname as the key, and actual fieldname to sort as value.
62 63
 	 * Example: array("MyCustomTitle"=>"Title", "MyCustomBooleanField" => "ActualBooleanField")
63 64
 	 *
64
-	 * @param array $casting
65
+	 * @param array $sorting
65 66
 	 */
66 67
 	public function setFieldSorting($sorting) {
67 68
 		$this->fieldSorting = $sorting;
Please login to merge, or discard this patch.
forms/gridfield/GridState.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -24,8 +24,7 @@
 block discarded – undo
24 24
 
25 25
 	/**
26 26
 	 *
27
-	 * @param GridField $name
28
-	 * @param string $data - json encoded string
27
+	 * @param GridField $grid
29 28
 	 */
30 29
 	public function __construct($grid, $value = null) {
31 30
 		$this->grid = $grid;
Please login to merge, or discard this patch.
forms/HiddenField.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@
 block discarded – undo
10 10
 	/**
11 11
 	 * @param array $properties
12 12
 	 *
13
-	 * @return HTMLText
13
+	 * @return string
14 14
 	 */
15 15
 	public function FieldHolder($properties = array()) {
16 16
 		return $this->Field($properties);
Please login to merge, or discard this patch.
forms/NestedForm.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@
 block discarded – undo
11 11
 
12 12
 	/**
13 13
 	 * Represent the given form in a tabular style
14
-	 * @param form The form to decorate.
14
+	 * @param form Form form to decorate.
15 15
 	 */
16 16
 	public function __construct(Form $form) {
17 17
 		$this->form = $form;
Please login to merge, or discard this patch.