Completed
Pull Request — 3.4 (#6867)
by Gregory
09:46
created
forms/HtmlEditorSanitiser.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 	/**
40 40
 	 * Given a TinyMCE pattern (close to unix glob style), create a regex that does the match
41 41
 	 *
42
-	 * @param $str - The TinyMCE pattern
42
+	 * @param string|null $str - The TinyMCE pattern
43 43
 	 * @return string - The equivalent regex
44 44
 	 */
45 45
 	protected function patternToRegex($str) {
@@ -180,6 +180,7 @@  discard block
 block discarded – undo
180 180
 	/**
181 181
 	 * Given an attribute name, return the rule structure for that attribute
182 182
 	 * @param string $name - The attribute name
183
+	 * @param stdClass $elementRule
183 184
 	 * @return stdClass - The attribute rule
184 185
 	 */
185 186
 	protected function getRuleForAttribute($elementRule, $name) {
Please login to merge, or discard this patch.
forms/InlineFormAction.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@
 block discarded – undo
14 14
 
15 15
 	/**
16 16
 	 * Create a new action button.
17
-	 * @param action The method to call when the button is clicked
17
+	 * @param action string method to call when the button is clicked
18 18
 	 * @param title The label on the button
19 19
 	 * @param extraClass A CSS class to apply to the button in addition to 'action'
20 20
 	 */
Please login to merge, or discard this patch.
forms/NestedForm.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@
 block discarded – undo
11 11
 
12 12
 	/**
13 13
 	 * Represent the given form in a tabular style
14
-	 * @param form The form to decorate.
14
+	 * @param form Form form to decorate.
15 15
 	 */
16 16
 	public function __construct(Form $form) {
17 17
 		$this->form = $form;
Please login to merge, or discard this patch.
forms/RequiredFields.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -176,6 +176,7 @@
 block discarded – undo
176 176
 	 * Add {@link RequiredField} objects together
177 177
 	 *
178 178
 	 * @param RequiredFields
179
+	 * @param RequiredFields $requiredFields
179 180
 	 *
180 181
 	 * @return RequiredFields
181 182
 	 */
Please login to merge, or discard this patch.
forms/SelectionGroup.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -134,7 +134,7 @@
 block discarded – undo
134 134
 
135 135
 	/**
136 136
 	 * @param String $value Form field identifier
137
-	 * @param FormField $field Contents of the option
137
+	 * @param FormField $fields Contents of the option
138 138
 	 * @param String $title Title to show for the radio button option
139 139
 	 */
140 140
 	function __construct($value, $fields = null, $title = null) {
Please login to merge, or discard this patch.
forms/Tab.php 1 patch
Doc Comments   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -23,8 +23,6 @@  discard block
 block discarded – undo
23 23
 	 * @uses FormField::name_to_label()
24 24
 	 *
25 25
 	 * @param string $name Identifier of the tab, without characters like dots or spaces
26
-	 * @param string $title Natural language title of the tab. If its left out,
27
-	 *  the class uses {@link FormField::name_to_label()} to produce a title from the {@link $name} parameter.
28 26
 	 * @param FormField All following parameters are inserted as children to this tab
29 27
 	 */
30 28
 	public function __construct($name) {
@@ -54,6 +52,9 @@  discard block
 block discarded – undo
54 52
 		return $this->children;
55 53
 	}
56 54
 
55
+	/**
56
+	 * @param TabSet $val
57
+	 */
57 58
 	public function setTabSet($val) {
58 59
 		$this->tabSet = $val;
59 60
 		return $this;
Please login to merge, or discard this patch.
forms/TabSet.php 1 patch
Doc Comments   -2 removed lines patch added patch discarded remove patch
@@ -29,8 +29,6 @@
 block discarded – undo
29 29
 
30 30
 	/**
31 31
 	 * @param string $name Identifier
32
-	 * @param string $title (Optional) Natural language title of the tabset
33
-	 * @param Tab|TabSet $unknown All further parameters are inserted as children into the TabSet
34 32
 	 */
35 33
 	public function __construct($name) {
36 34
 		$args = func_get_args();
Please login to merge, or discard this patch.
forms/TimeField.php 1 patch
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -50,6 +50,10 @@  discard block
 block discarded – undo
50 50
 	 */
51 51
 	protected $valueObj = null;
52 52
 
53
+	/**
54
+	 * @param string $name
55
+	 * @param string $title
56
+	 */
53 57
 	public function __construct($name, $title = null, $value = ""){
54 58
 		if(!$this->locale) {
55 59
 			$this->locale = i18n::get_locale();
@@ -228,6 +232,9 @@  discard block
 block discarded – undo
228 232
 		return $this->castedCopy('TimeField_Readonly');
229 233
 	}
230 234
 
235
+	/**
236
+	 * @param string $class
237
+	 */
231 238
 	public function castedCopy($class) {
232 239
 		$copy = parent::castedCopy($class);
233 240
 		if($copy->hasMethod('setConfig')) {
Please login to merge, or discard this patch.
i18n/i18n.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
 
119 119
 	/**
120 120
 	 * Return an instance of the cache used for i18n data.
121
-	 * @return Zend_Cache
121
+	 * @return Zend_Cache_Core
122 122
 	 */
123 123
 	public static function get_cache() {
124 124
 		return SS_Cache::factory('i18n', 'Output', array('lifetime' => null, 'automatic_serialization' => true));
@@ -2156,6 +2156,7 @@  discard block
 block discarded – undo
2156 2156
 
2157 2157
 	/**
2158 2158
 	 * @param String
2159
+	 * @param string $name
2159 2160
 	 * @return Zend_Translate
2160 2161
 	 */
2161 2162
 	public static function get_translator($name) {
@@ -2169,6 +2170,7 @@  discard block
 block discarded – undo
2169 2170
 	 * @param Zend_Translate Needs to implement {@link i18nTranslateAdapterInterface}
2170 2171
 	 * @param String If left blank will override the default translator.
2171 2172
 	 * @param Int
2173
+	 * @param string $name
2172 2174
 	 */
2173 2175
 	public static function register_translator($translator, $name, $priority = 10) {
2174 2176
 		if (!is_int($priority)) throw new InvalidArgumentException("register_translator expects an int priority");
@@ -2298,7 +2300,7 @@  discard block
 block discarded – undo
2298 2300
 	 *
2299 2301
 	 * @see get_locale_name()
2300 2302
 	 *
2301
-	 * @param mixed $code Language code
2303
+	 * @param string $code Language code
2302 2304
 	 * @param boolean $native If true, the native name will be returned
2303 2305
 	 * @return Name of the language
2304 2306
 	 */
@@ -2455,6 +2457,7 @@  discard block
 block discarded – undo
2455 2457
 	 *
2456 2458
 	 * Note: Does not check for {@link $allowed_locales}.
2457 2459
 	 *
2460
+	 * @param string $locale
2458 2461
 	 * @return boolean
2459 2462
 	 */
2460 2463
 	public static function validate_locale($locale) {
Please login to merge, or discard this patch.