Completed
Pull Request — master (#6233)
by David
09:20
created
Security/Group.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -331,6 +331,7 @@
 block discarded – undo
331 331
 	 * Overloaded to ensure the code is always descent.
332 332
 	 *
333 333
 	 * @param string
334
+	 * @param string $val
334 335
 	 */
335 336
 	public function setCode($val){
336 337
 		$this->setField("Code", Convert::raw2url($val));
Please login to merge, or discard this patch.
Security/Member.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1563,7 +1563,7 @@  discard block
 block discarded – undo
1563 1563
 	 * This is likely to be customized for social sites etc. with a looser permission model.
1564 1564
 	 *
1565 1565
 	 * @param Member $member
1566
-	 * @return bool
1566
+	 * @return boolean|string
1567 1567
 	 */
1568 1568
     public function canView($member = null) {
1569 1569
         //get member
@@ -1593,7 +1593,7 @@  discard block
 block discarded – undo
1593 1593
 	 * Otherwise they'll need ADMIN or CMS_ACCESS_SecurityAdmin permissions
1594 1594
 	 *
1595 1595
 	 * @param Member $member
1596
-	 * @return bool
1596
+	 * @return boolean|string
1597 1597
 	 */
1598 1598
     public function canEdit($member = null) {
1599 1599
         //get member
@@ -1627,7 +1627,7 @@  discard block
 block discarded – undo
1627 1627
      * Otherwise they'll need ADMIN or CMS_ACCESS_SecurityAdmin permissions
1628 1628
 	 *
1629 1629
 	 * @param Member $member
1630
-	 * @return bool
1630
+	 * @return boolean|string
1631 1631
      */
1632 1632
     public function canDelete($member = null) {
1633 1633
         if(!($member instanceof Member)) {
Please login to merge, or discard this patch.
Security/MemberAuthenticator.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -147,7 +147,7 @@
 block discarded – undo
147 147
 	 * @param Form $form Optional: If passed, better error messages can be
148 148
 	 *                             produced by using
149 149
 	 *                             {@link Form::sessionMessage()}
150
-	 * @return bool|Member Returns FALSE if authentication fails, otherwise
150
+	 * @return Member|null Returns FALSE if authentication fails, otherwise
151 151
 	 *                     the member object
152 152
 	 * @see Security::setDefaultAdmin()
153 153
 	 */
Please login to merge, or discard this patch.
Security/RememberLoginHash.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -76,6 +76,9 @@
 block discarded – undo
76 76
 		return $this->token;
77 77
 	}
78 78
 
79
+	/**
80
+	 * @param string $token
81
+	 */
79 82
 	public function setToken($token) {
80 83
 		$this->token = $token;
81 84
 	}
Please login to merge, or discard this patch.
ORM/FieldType/DBDate.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -38,6 +38,9 @@  discard block
 block discarded – undo
38 38
 	 */
39 39
 	private static $nice_format = 'd/m/Y';
40 40
 
41
+	/**
42
+	 * @param string|null $value
43
+	 */
41 44
 	public function setValue($value, $record = null, $markChanged = true) {
42 45
 		if($value === false || $value === null || (is_string($value) && !strlen($value))) {
43 46
 			// don't try to evaluate empty values with strtotime() below, as it returns "1970-01-01" when it should be
@@ -194,7 +197,7 @@  discard block
 block discarded – undo
194 197
 	 * Return a date formatted as per a CMS user's settings.
195 198
 	 *
196 199
 	 * @param Member $member
197
-	 * @return boolean | string A date formatted as per user-defined settings.
200
+	 * @return false|string | string A date formatted as per user-defined settings.
198 201
 	 */
199 202
 	public function FormatFromSettings($member = null) {
200 203
 		require_once 'Zend/Date.php';
Please login to merge, or discard this patch.
ORM/FieldType/DBDecimal.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 	 * @param string $name
22 22
 	 * @param int $wholeSize
23 23
 	 * @param int $decimalSize
24
-	 * @param float|int $defaultValue
24
+	 * @param integer $defaultValue
25 25
 	 */
26 26
 	public function __construct($name = null, $wholeSize = 9, $decimalSize = 2, $defaultValue = 0) {
27 27
 		$this->wholeSize = is_int($wholeSize) ? $wholeSize : 9;
@@ -33,14 +33,14 @@  discard block
 block discarded – undo
33 33
 	}
34 34
 
35 35
 	/**
36
-	 * @return float
36
+	 * @return string
37 37
 	 */
38 38
 	public function Nice() {
39 39
 		return number_format($this->value, $this->decimalSize);
40 40
 	}
41 41
 
42 42
 	/**
43
-	 * @return int
43
+	 * @return double
44 44
 	 */
45 45
 	public function Int() {
46 46
 		return floor($this->value);
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
 	}
84 84
 
85 85
 	/**
86
-	 * @return float
86
+	 * @return integer
87 87
 	 */
88 88
 	public function nullValue() {
89 89
 		return 0;
Please login to merge, or discard this patch.
thirdparty/jsmin/jsmin.php 1 patch
Doc Comments   +14 added lines patch added patch discarded remove patch
@@ -59,6 +59,9 @@  discard block
 block discarded – undo
59 59
 
60 60
   // -- Public Static Methods --------------------------------------------------
61 61
 
62
+  /**
63
+   * @param string $js
64
+   */
62 65
   public static function minify($js) {
63 66
     $jsmin = new JSMin($js);
64 67
     return $jsmin->min();
@@ -82,6 +85,10 @@  discard block
 block discarded – undo
82 85
      action treats a string as a single character. Wow!
83 86
      action recognizes a regular expression if it is preceded by ( or , or =.
84 87
   */
88
+
89
+  /**
90
+   * @param integer $d
91
+   */
85 92
   protected function action($d) {
86 93
     switch($d) {
87 94
       case 1:
@@ -160,6 +167,9 @@  discard block
 block discarded – undo
160 167
     }
161 168
   }
162 169
 
170
+  /**
171
+   * @return string
172
+   */
163 173
   protected function get() {
164 174
     $c = $this->lookAhead;
165 175
     $this->lookAhead = null;
@@ -187,6 +197,10 @@  discard block
 block discarded – undo
187 197
   /* isAlphanum -- return true if the character is a letter, digit, underscore,
188 198
         dollar sign, or non-ASCII character.
189 199
   */
200
+
201
+  /**
202
+   * @param string $c
203
+   */
190 204
   protected function isAlphaNum($c) {
191 205
     return ord($c) > 126 || $c === '\\' || preg_match('/^[\w\$]$/', $c) === 1;
192 206
   }
Please login to merge, or discard this patch.
ORM/FieldType/DBField.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -477,7 +477,7 @@
 block discarded – undo
477 477
 	}
478 478
 
479 479
 	/**
480
-	 * @param array $value
480
+	 * @param string $value
481 481
 	 * @return $this
482 482
 	 */
483 483
 	public function setArrayValue($value) {
Please login to merge, or discard this patch.
thirdparty/Zend/Cache/Backend/BlackHole.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
      * Test if a cache is available or not (for the given id)
57 57
      *
58 58
      * @param  string $id cache id
59
-     * @return mixed false (a cache is not available) or "last modified" timestamp (int) of the available cache record
59
+     * @return boolean false (a cache is not available) or "last modified" timestamp (int) of the available cache record
60 60
      */
61 61
     public function test($id)
62 62
     {
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
      * - mtime : timestamp of last modification time
193 193
      *
194 194
      * @param  string $id cache id
195
-     * @return array array of metadatas (false if the cache id is not found)
195
+     * @return boolean array of metadatas (false if the cache id is not found)
196 196
      */
197 197
     public function getMetadatas($id)
198 198
     {
Please login to merge, or discard this patch.