Completed
Pull Request — master (#6233)
by David
09:20
created
thirdparty/simpletest/page.php 1 patch
Doc Comments   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
     /**
146 146
      *    Reads the raw content and send events
147 147
      *    into the page to be built.
148
-     *    @param $response SimpleHttpResponse  Fetched response.
148
+     *    @param SilverStripe\Dev\TestSession_STResponseWrapper $response SimpleHttpResponse  Fetched response.
149 149
      *    @return SimplePage                   Newly parsed page.
150 150
      *    @access public
151 151
      */
@@ -170,8 +170,8 @@  discard block
 block discarded – undo
170 170
 
171 171
     /**
172 172
      *    Creates the parser used with the builder.
173
-     *    @param $listener SimpleSaxListener   Target of parser.
174
-     *    @return SimpleSaxParser              Parser to generate
173
+     *    @param SimplePageBuilder $listener SimpleSaxListener   Target of parser.
174
+     *    @return SimpleHtmlSaxParser              Parser to generate
175 175
      *                                         events for the builder.
176 176
      *    @access protected
177 177
      */
@@ -406,7 +406,7 @@  discard block
 block discarded – undo
406 406
 
407 407
     /**
408 408
      *    Original request as bytes sent down the wire.
409
-     *    @return mixed              Sent content.
409
+     *    @return string|false              Sent content.
410 410
      *    @access public
411 411
      */
412 412
     function getRequest() {
@@ -415,7 +415,7 @@  discard block
 block discarded – undo
415 415
 
416 416
     /**
417 417
      *    Accessor for raw text of page.
418
-     *    @return string        Raw unparsed content.
418
+     *    @return boolean        Raw unparsed content.
419 419
      *    @access public
420 420
      */
421 421
     function getRaw() {
@@ -467,7 +467,7 @@  discard block
 block discarded – undo
467 467
 
468 468
     /**
469 469
      *    Base URL if set via BASE tag page url otherwise
470
-     *    @return SimpleUrl        Base url.
470
+     *    @return boolean        Base url.
471 471
      *    @access public
472 472
      */
473 473
     function getBaseUrl() {
@@ -658,7 +658,7 @@  discard block
 block discarded – undo
658 658
     /**
659 659
      *    Opens a frameset. A frameset may contain nested
660 660
      *    frameset tags.
661
-     *    @param SimpleFramesetTag $tag      Tag to accept.
661
+     *    @param SimpleTag $tag      Tag to accept.
662 662
      *    @access public
663 663
      */
664 664
     function acceptFramesetStart(&$tag) {
Please login to merge, or discard this patch.
View/Parsers/Diff.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -160,7 +160,7 @@
 block discarded – undo
160 160
 	}
161 161
 
162 162
 	/**
163
-	 * @param string|array $content If passed as an array, values will be concatenated with a comma.
163
+	 * @param string $content If passed as an array, values will be concatenated with a comma.
164 164
 	 * @return array
165 165
 	 */
166 166
 	public static function getHTMLChunks($content) {
Please login to merge, or discard this patch.
View/Parsers/ShortcodeParser.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -168,6 +168,9 @@
 block discarded – undo
168 168
 
169 169
 	// --------------------------------------------------------------------------------------------------------------
170 170
 
171
+	/**
172
+	 * @param DOMElement $node
173
+	 */
171 174
 	protected function removeNode($node) {
172 175
 		$node->parentNode->removeChild($node);
173 176
 	}
Please login to merge, or discard this patch.
View/Parsers/URLSegmentFilter.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -89,6 +89,7 @@
 block discarded – undo
89 89
 	 * Determines if the field should render open or closed by default.
90 90
 	 * 
91 91
 	 * @param boolean
92
+	 * @param boolean $bool
92 93
 	 */
93 94
 	public function startClosed($bool) {
94 95
 		($bool) ? $this->addExtraClass('startClosed') : $this->removeExtraClass('startClosed');
Please login to merge, or discard this patch.
View/Requirements_Backend.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -321,6 +321,7 @@
 block discarded – undo
321 321
 	 * Forces the JavaScript requirements to the end of the body, right before the closing tag
322 322
 	 *
323 323
 	 * @param bool
324
+	 * @param boolean $var
324 325
 	 * @return $this
325 326
 	 */
326 327
 	public function setForceJSToBottom($var)
Please login to merge, or discard this patch.
View/SSTemplateParser.php.inc 1 patch
Doc Comments   +7 added lines, -3 removed lines patch added patch discarded remove patch
@@ -114,6 +114,8 @@  discard block
 block discarded – undo
114 114
 
115 115
 	/**
116 116
 	 * Override the function that constructs the result arrays to also prepare a 'php' item in the array
117
+	 * @param string $matchrule
118
+	 * @param string $name
117 119
 	 */
118 120
 	function construct($matchrule, $name, $arguments = null) {
119 121
 		$res = parent::construct($matchrule, $name, $arguments);
@@ -175,9 +177,9 @@  discard block
 block discarded – undo
175 177
 
176 178
 	/**
177 179
 	 * Ensures that the arguments to addOpenBlock and addClosedBlock are valid
178
-	 * @param $name
179
-	 * @param $callable
180
-	 * @param $type
180
+	 * @param string $name
181
+	 * @param callable $callable
182
+	 * @param string $type
181 183
 	 * @throws InvalidArgumentException
182 184
 	 */
183 185
 	protected function validateExtensionBlock($name, $callable, $type) {
@@ -262,6 +264,7 @@  discard block
 block discarded – undo
262 264
 	 * The basic generated PHP of LookupStep and LastLookupStep is the same, except that LookupStep calls 'obj' to
263 265
 	 * get the next ViewableData in the sequence, and LastLookupStep calls different methods (XML_val, hasValue, obj)
264 266
 	 * depending on the context the lookup is used in.
267
+	 * @param string $method
265 268
 	 */
266 269
 	function Lookup_AddLookupStep(&$res, $sub, $method) {
267 270
 		$res['LookupSteps'][] = $sub;
@@ -1174,6 +1177,7 @@  discard block
 block discarded – undo
1174 1177
 
1175 1178
 	/**
1176 1179
 	 * @param string $code
1180
+	 * @param string $templateName
1177 1181
 	 * @return string $code
1178 1182
 	 */
1179 1183
 	protected function includeDebuggingComments($code, $templateName) {
Please login to merge, or discard this patch.
View/SSViewer.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -622,7 +622,7 @@  discard block
 block discarded – undo
622 622
 	 * @param mixed $data Data context
623 623
 	 * @param array $arguments Additional arguments
624 624
 	 * @param Object $scope
625
-	 * @return string Evaluated result
625
+	 * @return DBHTMLText Evaluated result
626 626
 	 */
627 627
 	public static function execute_template($template, $data, $arguments = null, $scope = null) {
628 628
 		$v = new SSViewer($template);
@@ -648,6 +648,9 @@  discard block
 block discarded – undo
648 648
 		return $v->process($data, $arguments);
649 649
 	}
650 650
 
651
+	/**
652
+	 * @param string $content
653
+	 */
651 654
 	public function parseTemplateContent($content, $template="") {
652 655
 		return $this->getParser()->compileString(
653 656
 			$content,
Please login to merge, or discard this patch.
View/SSViewer_DataPresenter.php 1 patch
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -33,6 +33,10 @@  discard block
 block discarded – undo
33 33
 	 */
34 34
 	protected $underlay;
35 35
 
36
+	/**
37
+	 * @param ViewableData $item
38
+	 * @param ViewableData $inheritedScope
39
+	 */
36 40
 	public function __construct($item, $overlay = null, $underlay = null, $inheritedScope = null)
37 41
 	{
38 42
 		parent::__construct($item, $inheritedScope);
@@ -58,6 +62,10 @@  discard block
 block discarded – undo
58 62
 		$this->underlay = $underlay ? $underlay : array();
59 63
 	}
60 64
 
65
+	/**
66
+	 * @param string $interfaceToQuery
67
+	 * @param string $variableMethod
68
+	 */
61 69
 	protected function createCallableArray(&$extraArray, $interfaceToQuery, $variableMethod, $createObject = false)
62 70
 	{
63 71
 		$implementers = ClassInfo::implementorsOf($interfaceToQuery);
Please login to merge, or discard this patch.
View/SSViewer_FromString.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -30,6 +30,9 @@
 block discarded – undo
30 30
 	 */
31 31
 	protected $cacheTemplate;
32 32
 
33
+	/**
34
+	 * @param string $content
35
+	 */
33 36
 	public function __construct($content, TemplateParser $parser = null)
34 37
 	{
35 38
 		if ($parser) {
Please login to merge, or discard this patch.