Completed
Pull Request — master (#6233)
by David
09:20
created
Forms/HTMLEditor/HTMLEditorConfig.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -140,14 +140,14 @@
 block discarded – undo
140 140
 	 * Get the current value of an option
141 141
      *
142 142
 	 * @param string $key The key of the option to get
143
-	 * @return mixed The value of the specified option
143
+	 * @return string The value of the specified option
144 144
 	 */
145 145
 	abstract public function getOption($key);
146 146
 
147 147
 	/**
148 148
 	 * Set the value of one option
149 149
 	 * @param string $key The key of the option to set
150
-	 * @param mixed $value The value of the option to set
150
+	 * @param string $value The value of the option to set
151 151
 	 * @return $this
152 152
 	 */
153 153
 	abstract public function setOption($key, $value);
Please login to merge, or discard this patch.
Forms/HTMLEditor/HTMLEditorField.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
 	/**
69 69
 	 * Assign a new configuration instance or identifier
70 70
 	 *
71
-	 * @param string|HTMLEditorConfig $config
71
+	 * @param string $config
72 72
 	 * @return $this
73 73
 	 */
74 74
 	public function setEditorConfig($config) {
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
 	 *
83 83
 	 * @param string $name The internal field name, passed to forms.
84 84
 	 * @param string $title The human-readable field label.
85
-	 * @param mixed $value The value of the field.
85
+	 * @param integer $value The value of the field.
86 86
 	 * @param string $config HTMLEditorConfig identifier to be used. Default to the active one.
87 87
 	 */
88 88
 	public function __construct($name, $title = null, $value = '', $config = null) {
@@ -127,6 +127,9 @@  discard block
 block discarded – undo
127 127
 		$record->{$this->name} = $htmlValue->getContent();
128 128
 	}
129 129
 
130
+	/**
131
+	 * @param string|null $value
132
+	 */
130 133
 	public function setValue($value) {
131 134
 		// Regenerate links prior to preview, so that the editor can see them.
132 135
 		$value = Image::regenerate_html_links($value);
Please login to merge, or discard this patch.
Forms/HTMLEditor/HTMLEditorField_Embed.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -140,7 +140,7 @@
 block discarded – undo
140 140
 	}
141 141
 
142 142
 	/**
143
-	 * @return AdapterInterface
143
+	 * @return Embed
144 144
 	 */
145 145
 	public function getEmbed()
146 146
 	{
Please login to merge, or discard this patch.
Forms/HTMLEditor/HTMLEditorSanitiser.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
 	/**
47 47
 	 * Given a TinyMCE pattern (close to unix glob style), create a regex that does the match
48 48
 	 *
49
-	 * @param $str - The TinyMCE pattern
49
+	 * @param string|null $str - The TinyMCE pattern
50 50
 	 * @return string - The equivalent regex
51 51
 	 */
52 52
 	protected function patternToRegex($str) {
Please login to merge, or discard this patch.
Forms/MoneyField.php 1 patch
Doc Comments   +11 added lines, -1 removed lines patch added patch discarded remove patch
@@ -57,6 +57,10 @@  discard block
 block discarded – undo
57 57
 		return $this->fieldAmount;
58 58
 	}
59 59
 
60
+	/**
61
+	 * @param string $name
62
+	 * @param string $title
63
+	 */
60 64
 	public function __construct($name, $title = null, $value = "") {
61 65
 		$this->setName($name);
62 66
 
@@ -129,7 +133,7 @@  discard block
 block discarded – undo
129 133
 	 *
130 134
 	 * (see @link MoneyFieldTest_CustomSetter_Object for more information)
131 135
 	 *
132
-	 * @param DataObjectInterface|Object $dataObject
136
+	 * @param DataObjectInterface $dataObject
133 137
 	 */
134 138
 	public function saveInto(DataObjectInterface $dataObject) {
135 139
 		$fieldName = $this->getName();
@@ -158,6 +162,9 @@  discard block
 block discarded – undo
158 162
 		return $clone;
159 163
 	}
160 164
 
165
+	/**
166
+	 * @param boolean $bool
167
+	 */
161 168
 	public function setReadonly($bool) {
162 169
 		parent::setReadonly($bool);
163 170
 
@@ -198,6 +205,9 @@  discard block
 block discarded – undo
198 205
 		return $this->allowedCurrencies;
199 206
 	}
200 207
 
208
+	/**
209
+	 * @param string $locale
210
+	 */
201 211
 	public function setLocale($locale) {
202 212
 		$this->_locale = $locale;
203 213
 		return $this;
Please login to merge, or discard this patch.
Forms/PrintableTransformation_TabSet.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@
 block discarded – undo
8 8
 class PrintableTransformation_TabSet extends TabSet
9 9
 {
10 10
 	/**
11
-	 * @param array $tabs
11
+	 * @param FieldList $tabs
12 12
 	 */
13 13
 	public function __construct($tabs)
14 14
 	{
Please login to merge, or discard this patch.
Forms/ReadonlyField.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -95,7 +95,7 @@
 block discarded – undo
95 95
 	 * If $dontEscape is false the returned value will be safely encoded,
96 96
 	 * but should not be escaped by the frontend.
97 97
 	 *
98
-	 * @return mixed|string
98
+	 * @return string
99 99
 	 */
100 100
 	public function Value() {
101 101
 		// Get raw value
Please login to merge, or discard this patch.
Forms/Schema/FormSchema.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -74,6 +74,9 @@
 block discarded – undo
74 74
 		return $state;
75 75
 	}
76 76
 
77
+	/**
78
+	 * @param \SilverStripe\Forms\FieldList $fields
79
+	 */
77 80
 	protected function getFieldStates($fields) {
78 81
 		$states = [];
79 82
 		foreach ($fields as $field) {
Please login to merge, or discard this patch.
Forms/SelectionGroup_Item.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -152,6 +152,9 @@  discard block
 block discarded – undo
152 152
 		return $this->title;
153 153
 	}
154 154
 
155
+	/**
156
+	 * @param string $title
157
+	 */
155 158
 	function setTitle($title) {
156 159
 		$this->title = $title;
157 160
 		return $this;
@@ -161,6 +164,9 @@  discard block
 block discarded – undo
161 164
 		return $this->value;
162 165
 	}
163 166
 
167
+	/**
168
+	 * @param string $Value
169
+	 */
164 170
 	function setValue($Value) {
165 171
 		$this->value = $Value;
166 172
 		return $this;
Please login to merge, or discard this patch.