Completed
Pull Request — master (#6769)
by Sam
11:43 queued 04:20
created
src/Forms/GridField/GridField.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -228,7 +228,7 @@
 block discarded – undo
228 228
      *
229 229
      * @todo refactor this into GridFieldComponent
230 230
      *
231
-     * @param mixed $value
231
+     * @param string $value
232 232
      * @param string|array $castingDefinition
233 233
      *
234 234
      * @return mixed
Please login to merge, or discard this patch.
src/Forms/GridField/GridFieldDetailForm_ItemRequest.php 1 patch
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -92,6 +92,9 @@  discard block
 block discarded – undo
92 92
         parent::__construct();
93 93
     }
94 94
 
95
+    /**
96
+     * @param string $action
97
+     */
95 98
     public function Link($action = null)
96 99
     {
97 100
         return Controller::join_links(
@@ -341,6 +344,9 @@  discard block
 block discarded – undo
341 344
         return $c;
342 345
     }
343 346
 
347
+    /**
348
+     * @return string
349
+     */
344 350
     protected function getBackLink()
345 351
     {
346 352
         // TODO Coupling with CMS
@@ -448,6 +454,9 @@  discard block
 block discarded – undo
448 454
         }
449 455
     }
450 456
 
457
+    /**
458
+     * @param integer $errorCode
459
+     */
451 460
     public function httpError($errorCode, $errorMessage = null)
452 461
     {
453 462
         $controller = $this->getToplevelController();
Please login to merge, or discard this patch.
src/Forms/GridField/GridFieldEditButton.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
      * Which columns are handled by this component
66 66
      *
67 67
      * @param GridField $gridField
68
-     * @return array
68
+     * @return string[]
69 69
      */
70 70
     public function getColumnsHandled($gridField)
71 71
     {
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
      * @param GridField $gridField
88 88
      * @param DataObject $record
89 89
      * @param string $columnName
90
-     * @return string The HTML for the column
90
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText The HTML for the column
91 91
      */
92 92
     public function getColumnContent($gridField, $record, $columnName)
93 93
     {
Please login to merge, or discard this patch.
src/Forms/GridField/GridFieldExportButton.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
      * export is an action button
76 76
      *
77 77
      * @param GridField $gridField
78
-     * @return array
78
+     * @return string[]
79 79
      */
80 80
     public function getActions($gridField)
81 81
     {
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
      * Generate export fields for CSV.
150 150
      *
151 151
      * @param GridField $gridField
152
-     * @return array
152
+     * @return string
153 153
      */
154 154
     public function generateExportFileData($gridField)
155 155
     {
Please login to merge, or discard this patch.
src/Forms/HiddenField.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
 
13 13
     /**
14 14
      * @param array $properties
15
-     * @return string
15
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText
16 16
      */
17 17
     public function FieldHolder($properties = array())
18 18
     {
Please login to merge, or discard this patch.
src/Forms/HTMLEditor/EmbedShortcodeProvider.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
     /**
18 18
      * Gets the list of shortcodes provided by this handler
19 19
      *
20
-     * @return mixed
20
+     * @return string[]
21 21
      */
22 22
     public static function get_shortcodes()
23 23
     {
Please login to merge, or discard this patch.
src/Forms/HTMLEditor/HTMLEditorField_Embed.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -142,7 +142,7 @@
 block discarded – undo
142 142
     }
143 143
 
144 144
     /**
145
-     * @return AdapterInterface
145
+     * @return Embed
146 146
      */
147 147
     public function getEmbed()
148 148
     {
Please login to merge, or discard this patch.
src/Forms/HTMLEditor/HTMLEditorField_Toolbar.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -67,6 +67,10 @@  discard block
 block discarded – undo
67 67
      */
68 68
     protected $name;
69 69
 
70
+    /**
71
+     * @param Controller|null $controller
72
+     * @param string $name
73
+     */
70 74
     public function __construct($controller, $name)
71 75
     {
72 76
         parent::__construct();
@@ -508,7 +512,7 @@  discard block
 block discarded – undo
508 512
     /**
509 513
      * Find all anchors available on the given page.
510 514
      *
511
-     * @return array
515
+     * @return string
512 516
      * @throws HTTPResponse_Exception
513 517
      */
514 518
     public function getanchors()
Please login to merge, or discard this patch.
src/Forms/HTMLEditor/HTMLEditorSanitiser.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
     /**
53 53
      * Given a TinyMCE pattern (close to unix glob style), create a regex that does the match
54 54
      *
55
-     * @param $str - The TinyMCE pattern
55
+     * @param string|null $str - The TinyMCE pattern
56 56
      * @return string - The equivalent regex
57 57
      */
58 58
     protected function patternToRegex($str)
Please login to merge, or discard this patch.