SearchContextTest::testPrimarySearchFilterIsUsed() - Code Metrics - Inspection of "NEW Search across multiple searchable fields by de..." - silverstripe/silverstripe-framework - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Pull Request — 4 (#10382)

by Guy
created 2022-07-04 01:53 UTC
SearchContextTest::testPrimarySearchFilterIsUsed() A

↳ Parent: SearchContextTest
Complexity

Conditions	1
Paths	1
Size

Total Lines	21
Code Lines	14
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	1
eloc	14
nc	1
nop	0
dl	0
loc	21
rs	9.7998
c	0
b	0
f	0
<?php

namespace SilverStripe\ORM\Tests\Search;

use LogicException;
use SilverStripe\Core\Config\Config;
use SilverStripe\Dev\SapphireTest;
use SilverStripe\Forms\TextField;
use SilverStripe\Forms\TextareaField;
use SilverStripe\Forms\NumericField;
use SilverStripe\Forms\DropdownField;
use SilverStripe\Forms\CheckboxField;
use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\HiddenField;
use SilverStripe\ORM\DataList;
use SilverStripe\ORM\Filters\EndsWithFilter;
use SilverStripe\ORM\Filters\ExactMatchFilter;
use SilverStripe\ORM\Filters\PartialMatchFilter;
use SilverStripe\ORM\Search\SearchContext;

class SearchContextTest extends SapphireTest
{

    protected static $fixture_file = 'SearchContextTest.yml';

    protected static $extra_dataobjects = [
        SearchContextTest\Person::class,
        SearchContextTest\NoSearchableFields::class,
        SearchContextTest\Book::class,
        SearchContextTest\Company::class,
        SearchContextTest\Project::class,
        SearchContextTest\Deadline::class,
        SearchContextTest\Action::class,
        SearchContextTest\AllFilterTypes::class,
        SearchContextTest\Customer::class,
        SearchContextTest\Address::class,
        SearchContextTest\Order::class,
        SearchContextTest\PrimarySearch::class,
    ];

    public function testResultSetFilterReturnsExpectedCount()
    {
        $person = SearchContextTest\Person::singleton();
        $context = $person->getDefaultSearchContext();
        $results = $context->getResults(['Name' => '']);
        $this->assertEquals(5, $results->Count());

        $results = $context->getResults(['EyeColor' => 'green']);
        $this->assertEquals(2, $results->Count());

        $results = $context->getResults(['EyeColor' => 'green', 'HairColor' => 'black']);
        $this->assertEquals(1, $results->Count());
    }

    public function testSearchableFieldsDefaultsToSummaryFields()
    {
        $obj = new SearchContextTest\NoSearchableFields();
        $summaryFields = $obj->summaryFields();
        $expected = [];
        foreach ($summaryFields as $field => $label) {
            $expected[$field] = [
                'title' => $obj->fieldLabel($field),
                'filter' => 'PartialMatchFilter',
            ];
        }
        $this->assertEquals($expected, $obj->searchableFields());
    }

    public function testSummaryIncludesDefaultFieldsIfNotDefined()
    {
        $person = SearchContextTest\Person::singleton();
        $this->assertContains('Name', $person->summaryFields());

        $book = SearchContextTest\Book::singleton();
        $this->assertContains('Title', $book->summaryFields());
    }

    public function testAccessDefinedSummaryFields()
    {
        $company = SearchContextTest\Company::singleton();
        $this->assertContains('Industry', $company->summaryFields());
    }

    public function testPartialMatchUsedByDefaultWhenNotExplicitlySet()
    {
        $person = SearchContextTest\Person::singleton();
        $context = $person->getDefaultSearchContext();

        $this->assertEquals(
            [
                "Name" => new PartialMatchFilter("Name"),
                "HairColor" => new PartialMatchFilter("HairColor"),
                "EyeColor" => new PartialMatchFilter("EyeColor")
            ],
            $context->getFilters()
        );
    }

    public function testDefaultFiltersDefinedWhenNotSetInDataObject()
    {
        $book = SearchContextTest\Book::singleton();
        $context = $book->getDefaultSearchContext();

        $this->assertEquals(
            [
                "Title" => new PartialMatchFilter("Title")
            ],
            $context->getFilters()
        );
    }

    public function testUserDefinedFiltersAppearInSearchContext()
    {
        $company = SearchContextTest\Company::singleton();
        $context = $company->getDefaultSearchContext();

        $this->assertEquals(
            [
                "Name" => new PartialMatchFilter("Name"),
                "Industry" => new PartialMatchFilter("Industry"),
                "AnnualProfit" => new PartialMatchFilter("AnnualProfit")
            ],
            $context->getFilters()
        );
    }

    public function testUserDefinedFieldsAppearInSearchContext()
    {
        $company = SearchContextTest\Company::singleton();
        $context = $company->getDefaultSearchContext();
        $this->assertEquals(
            new FieldList(
                new HiddenField($company->primarySearchFieldName(), 'Primary Search'),
                (new TextField("Name", 'Name'))
                    ->setMaxLength(255),
                new TextareaField("Industry", 'Industry'),
                new NumericField("AnnualProfit", 'The Almighty Annual Profit')
            ),
            $context->getFields()
        );
    }

    public function testRelationshipObjectsLinkedInSearch()
    {
        $action3 = $this->objFromFixture(SearchContextTest\Action::class, 'action3');

        $project = SearchContextTest\Project::singleton();
        $context = $project->getDefaultSearchContext();

        $params = ["Name" => "Blog Website", "Actions__SolutionArea" => "technical"];

        /** @var DataList $results */
        $results = $context->getResults($params);

        $this->assertEquals(1, $results->count());

        /** @var SearchContextTest\Project $project */
        $project = $results->first();

        $this->assertInstanceOf(SearchContextTest\Project::class, $project);
        $this->assertEquals("Blog Website", $project->Name);
        $this->assertEquals(2, $project->Actions()->Count());

        $this->assertEquals(
            "Get RSS feeds working",
            $project->Actions()->find('ID', $action3->ID)->Description

        );
    }

    public function testCanGenerateQueryUsingAllFilterTypes()
    {
        $all = SearchContextTest\AllFilterTypes::singleton();
        $context = $all->getDefaultSearchContext();
        $params = [
            "ExactMatch" => "Match me exactly",
            "PartialMatch" => "partially",
            "CollectionMatch" => [
                "ExistingCollectionValue",
                "NonExistingCollectionValue",
                4,
                "Inline'Quotes'"
            ],
            "StartsWith" => "12345",
            "EndsWith" => "ijkl",
            "Fulltext" => "two"
        ];

        $results = $context->getResults($params);
        $this->assertEquals(1, $results->Count());
        $this->assertEquals("Filtered value", $results->First()->HiddenValue);
    }

    public function testStartsWithFilterCaseInsensitive()
    {
        $all = SearchContextTest\AllFilterTypes::singleton();
        $context = $all->getDefaultSearchContext();
        $params = [
            "StartsWith" => "12345-6789 camelcase", // spelled lowercase
        ];

        $results = $context->getResults($params);
        $this->assertEquals(1, $results->Count());
        $this->assertEquals("Filtered value", $results->First()->HiddenValue);
    }

    public function testEndsWithFilterCaseInsensitive()
    {
        $all = SearchContextTest\AllFilterTypes::singleton();
        $context = $all->getDefaultSearchContext();
        $params = [
            "EndsWith" => "IJKL", // spelled uppercase
        ];

        $results = $context->getResults($params);
        $this->assertEquals(1, $results->Count());
        $this->assertEquals("Filtered value", $results->First()->HiddenValue);
    }

    public function testSearchContextSummary()
    {
        $filters = [
            'KeywordSearch' => PartialMatchFilter::create('KeywordSearch'),
            'Country' => PartialMatchFilter::create('Country'),
            'CategoryID' => PartialMatchFilter::create('CategoryID'),
            'Featured' => PartialMatchFilter::create('Featured'),
            'Nothing' => PartialMatchFilter::create('Nothing'),
        ];

        $fields = FieldList::create(
            TextField::create('KeywordSearch', 'Keywords'),
            TextField::create('Country', 'Country'),
            DropdownField::create('CategoryID', 'Category', [
                1 => 'Category one',
                2 => 'Category two',
            ]),
            CheckboxField::create('Featured', 'Featured')
        );

        $context = SearchContext::create(
            SearchContextTest\Person::class,
            $fields,
            $filters
        );

        $context->setSearchParams([
            'KeywordSearch' => 'tester',
            'Country' => null,
            'CategoryID' => 2,
            'Featured' => 1,
            'Nothing' => 'empty',
        ]);

        $list = $context->getSummary();

        $this->assertEquals(3, $list->count());
        // KeywordSearch should be in the summary
        $keyword = $list->find('Field', 'Keywords');
        $this->assertNotNull($keyword);
        $this->assertEquals('tester', $keyword->Value);

        // Country should be skipped over
        $country = $list->find('Field', 'Country');
        $this->assertNull($country);

        // Category should be expressed as the label
        $category = $list->find('Field', 'Category');
        $this->assertNotNull($category);
        $this->assertEquals('Category two', $category->Value);

        // Featured should have no value, since it's binary
        $featured = $list->find('Field', 'Featured');
        $this->assertNotNull($featured);
        $this->assertNull($featured->Value);

        // "Nothing" should come back null since there's no field for it
        $nothing = $list->find('Field', 'Nothing');
        $this->assertNull($nothing);
    }

    public function testPrimarySearch()
    {
        $primary1 = $this->objFromFixture(SearchContextTest\PrimarySearch::class, 'primary1');
        $context = $primary1->getDefaultSearchContext();
        $primaryField = $primary1->primarySearchFieldName();

        // Matches on a variety of fields
        $results = $context->getResults([$primaryField => 'Primary']);
        $this->assertCount(2, $results);
        $this->assertNotContains('MatchNothing', $results->column('Name'));
        $results = $context->getResults([$primaryField => 'brown']);
        $this->assertCount(1, $results);
        $this->assertEquals('Primary One', $results->first()->Name);


        // Uses its own filter (not field filters)
        $results = $context->getResults([$primaryField => 'exact']);
        $this->assertCount(1, $results);
        $this->assertEquals('Primary One', $results->first()->Name);

        // Uses match_any fields
        $results = $context->getResults([$primaryField => 'first']);
        $this->assertCount(1, $results);
        $this->assertEquals('Primary One', $results->first()->Name);
        // Even across a relation
        $results = $context->getResults([$primaryField => 'arbitrary']);
        $this->assertCount(1, $results);
        $this->assertEquals('Primary One', $results->first()->Name);
    }

    public function testNonPrimarySearchFields()
    {
        $primary1 = $this->objFromFixture(SearchContextTest\PrimarySearch::class, 'primary1');
        $context = $primary1->getDefaultSearchContext();
        $primaryField = $primary1->primarySearchFieldName();
        $results = $context->getResults([$primaryField => $primary1->ExcludeThisField]);

        $this->assertNotEmpty($primary1->ExcludeThisField);
        $this->assertCount(0, $results);
    }

    public function testPrimaryOnlyUsesSearchableFields()
    {
        $primary1 = $this->objFromFixture(SearchContextTest\PrimarySearch::class, 'primary1');
        $context = $primary1->getDefaultSearchContext();
        $primaryField = $primary1->primarySearchFieldName();
        $results = $context->getResults([$primaryField => $primary1->DoNotUseThisField]);

        $this->assertNotEmpty($primary1->DoNotUseThisField);
        $this->assertCount(0, $results);
    }

    public function testPrimarySearchSplitsTerms()
    {
        $primary1 = $this->objFromFixture(SearchContextTest\PrimarySearch::class, 'primary1');
        $context = $primary1->getDefaultSearchContext();
        $primaryField = $primary1->primarySearchFieldName();

        // These terms don't exist in a single field in this order on any object
        $results = $context->getResults([$primaryField => 'primary blue']);
        $this->assertCount(1, $results);
        $this->assertEquals('Primary Zero', $results->first()->Name);


        // These terms exist in a single field, but not in this order.
        $results = $context->getResults([$primaryField => 'matches partial']);
        $this->assertCount(1, $results);
        $this->assertEquals('Primary One', $results->first()->Name);
    }

    public function testPrimarySearchNoSplitTerms()
    {
        Config::modify()->set(SearchContextTest\PrimarySearch::class, 'primary_search_split_terms', false);
        $primary1 = $this->objFromFixture(SearchContextTest\PrimarySearch::class, 'primary1');
        $context = $primary1->getDefaultSearchContext();
        $primaryField = $primary1->primarySearchFieldName();

        // These terms don't exist in a single field in this order on any object
        $results = $context->getResults([$primaryField => 'primary blue']);
        $this->assertCount(0, $results);

        // These terms exist in a single field, but not in this order.
        $results = $context->getResults([$primaryField => 'matches partial']);
        $this->assertCount(0, $results);

        // These terms exist in a single field in this order.
        $results = $context->getResults([$primaryField => 'partial matches']);
        $this->assertCount(1, $results);
        $this->assertEquals('Primary One', $results->first()->Name);

    }

    public function testGetPrimarySearchFilter()
    {
        $primary1 = $this->objFromFixture(SearchContextTest\PrimarySearch::class, 'primary1');
        $context = $primary1->getDefaultSearchContext();
        $primaryField = $primary1->primarySearchFieldName();


        // By default, uses the PartialMatchFilter.
        $this->assertSame(
            PartialMatchFilter::class,
            get_class($context->getPrimarySearchFilter($primary1->ClassName, 'ExactMatchField'))
        );
        $this->assertSame(
            PartialMatchFilter::class,
            get_class($context->getPrimarySearchFilter($primary1->ClassName, 'PartialMatchField'))
        );

        // Changing the config changes the filter.
        Config::modify()->set(SearchContextTest\PrimarySearch::class, 'primary_search_field_filter', EndsWithFilter::class);
        $this->assertSame(
            EndsWithFilter::class,
            get_class($context->getPrimarySearchFilter($primary1->ClassName, 'ExactMatchField'))
        );
        $this->assertSame(
            EndsWithFilter::class,
            get_class($context->getPrimarySearchFilter($primary1->ClassName, 'PartialMatchField'))
        );

        // Removing the filter config defaults to use the field's filter.
        Config::modify()->set(SearchContextTest\PrimarySearch::class, 'primary_search_field_filter', '');
        $this->assertSame(
            ExactMatchFilter::class,
            get_class($context->getPrimarySearchFilter($primary1->ClassName, 'ExactMatchField'))
        );
        $this->assertSame(
            PartialMatchFilter::class,
            get_class($context->getPrimarySearchFilter($primary1->ClassName, 'PartialMatchField'))
        );
    }

    public function testPrimarySearchFilterIsUsed()
    {
        Config::modify()->set(SearchContextTest\PrimarySearch::class, 'primary_search_field_filter', '');
        $primary1 = $this->objFromFixture(SearchContextTest\PrimarySearch::class, 'primary1');
        $context = $primary1->getDefaultSearchContext();
        $primaryField = $primary1->primarySearchFieldName();

        // Respects ExactMatchFilter
        $results = $context->getResults([$primaryField => 'exact']);
        $this->assertCount(0, $results);
        // No match when splitting terms
        $results = $context->getResults([$primaryField => 'This requires an exact match']);
        $this->assertCount(0, $results);

        Config::modify()->set(SearchContextTest\PrimarySearch::class, 'primary_search_split_terms', false);
        // Respects ExactMatchFilter
        $results = $context->getResults([$primaryField => 'exact']);
        $this->assertCount(0, $results);
        $results = $context->getResults([$primaryField => 'This requires an exact match']);
        $this->assertCount(1, $results);
        $this->assertEquals('Primary One', $results->first()->Name);

    }

    public function testPrimarySearchDisabled()
    {
        Config::modify()->set(SearchContextTest\PrimarySearch::class, 'primary_search_field_name', '');
        $primary1 = $this->objFromFixture(SearchContextTest\PrimarySearch::class, 'primary1');
        $context = $primary1->getDefaultSearchContext();
        $primaryField = $primary1->primarySearchFieldName();
        $this->assertEmpty($primaryField);

        // Defaults to returning all objects, because the field doesn't exist in the SearchContext
        $numObjs = SearchContextTest\PrimarySearch::get()->count();
        $results = $context->getResults([$primaryField => 'Primary']);
        $this->assertCount($numObjs, $results);
        $results = $context->getResults([$primaryField => 'brown']);
        $this->assertCount($numObjs, $results);

        // Searching on other fields still works as expected (e.g. first field, which is the UI default in this situation)
        $results = $context->getResults(['Name' => 'Primary']);
        $this->assertCount(2, $results);
        $this->assertNotContains('MatchNothing', $results->column('Name'));
    }

    public function testPrimarySearchCustomFieldName()
    {
        Config::modify()->set(SearchContextTest\PrimarySearch::class, 'primary_search_field_name', 'some_arbitrary_field_name');
        $obj = new SearchContextTest\PrimarySearch();
        $this->assertSame('some_arbitrary_field_name', $obj->primarySearchFieldName());
        $this->testPrimarySearch();
    }

    public function testprimarySearchFieldNameMustBeUnique()
    {
        Config::modify()->set(SearchContextTest\PrimarySearch::class, 'primary_search_field_name', 'MatchAny');
        $primary1 = $this->objFromFixture(SearchContextTest\PrimarySearch::class, 'primary1');
        $this->expectException(LogicException::class);
        $primary1->getDefaultSearchContext();
    }

    public function testMatchAnySearch()
    {
        $order1 = $this->objFromFixture(SearchContextTest\Order::class, 'order1');
        $context = $order1->getDefaultSearchContext();

        // Search should match Order's customer FirstName
        $results = $context->getResults(['CustomFirstName' => 'Bill']);
        $this->assertCount(2, $results);
        $this->assertListContains([
            ['Name' => 'Jane'],
            ['Name' => 'Jack'],
        ], $results);

        // Search should match Order's shipping address FirstName
        $results = $context->getResults(['CustomFirstName' => 'Bob']);
        $this->assertCount(2, $results);
        $this->assertListContains([
            ['Name' => 'Jane'],
            ['Name' => 'Jill'],
        ], $results);

        // Search should match Order's Name db field
        $results = $context->getResults(['CustomFirstName' => 'Jane']);
        $this->assertCount(1, $results);
        $this->assertSame('Jane', $results->first()->Name);


        // Search should not match any Order
        $results = $context->getResults(['CustomFirstName' => 'NoMatches']);
        $this->assertCount(0, $results);
    }

    public function testMatchAnySearchWithFilters()
    {
        $order1 = $this->objFromFixture(SearchContextTest\Order::class, 'order1');
        $context = $order1->getDefaultSearchContext();

        $results = $context->getResults(['ExactMatchField' => 'Bil']);
        $this->assertCount(0, $results);
        $results = $context->getResults(['PartialMatchField' => 'Bil']);
        $this->assertCount(2, $results);

        $results = $context->getResults(['ExactMatchField' => 'ob']);
        $this->assertCount(0, $results);
        $results = $context->getResults(['PartialMatchField' => 'ob']);
        $this->assertCount(2, $results);

        $results = $context->getResults(['ExactMatchField' => 'an']);
        $this->assertCount(0, $results);
        $results = $context->getResults(['PartialMatchField' => 'an']);
        $this->assertCount(1, $results);
    }
}

silverstripe / silverstripe-framework

Pull Request — 4 (#10382)

SearchContextTest::testPrimarySearchFilterIsUsed() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like
