Completed
Pull Request — master (#7083)
by Sam
07:25
created
src/View/SSViewer_DataPresenter.php 1 patch
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -33,6 +33,10 @@  discard block
 block discarded – undo
33 33
      */
34 34
     protected $underlay;
35 35
 
36
+    /**
37
+     * @param ViewableData $item
38
+     * @param ViewableData $inheritedScope
39
+     */
36 40
     public function __construct($item, $overlay = null, $underlay = null, $inheritedScope = null)
37 41
     {
38 42
         parent::__construct($item, $inheritedScope);
@@ -65,6 +69,9 @@  discard block
 block discarded – undo
65 69
         $this->underlay = $underlay ? $underlay : array();
66 70
     }
67 71
 
72
+    /**
73
+     * @param string $variableMethod
74
+     */
68 75
     protected function createCallableArray(&$extraArray, $interfaceToQuery, $variableMethod, $createObject = false)
69 76
     {
70 77
         $implementers = ClassInfo::implementorsOf($interfaceToQuery);
Please login to merge, or discard this patch.
thirdparty/php-peg/Parser.php 1 patch
Doc Comments   +28 added lines patch added patch discarded remove patch
@@ -9,6 +9,10 @@  discard block
 block discarded – undo
9 9
  *  the bracket if a failed match + restore has moved the current position backwards - so we have to check that too.
10 10
  */
11 11
 class ParserRegexp {
12
+
13
+	/**
14
+	 * @param Parser $parser
15
+	 */
12 16
 	function __construct( $parser, $rx ) {
13 17
 		$this->parser = $parser ;
14 18
 		$this->rx = $rx . 'Sx' ;
@@ -83,6 +87,9 @@  discard block
 block discarded – undo
83 87
 		return FALSE ;
84 88
 	}
85 89
 
90
+ 	/**
91
+ 	 * @param string $token
92
+ 	 */
86 93
  	function literal( $token ) {
87 94
  		/* Debugging: * / print( "Looking for token '$token' @ '" . substr( $this->string, $this->pos ) . "'\n" ) ; /* */
88 95
  		$toklen = strlen( $token ) ;
@@ -94,11 +101,17 @@  discard block
 block discarded – undo
94 101
 		return FALSE ;
95 102
 	}
96 103
 
104
+	/**
105
+	 * @param string $rx
106
+	 */
97 107
 	function rx( $rx ) {
98 108
 		if ( !isset( $this->regexps[$rx] ) ) $this->regexps[$rx] = new ParserRegexp( $this, $rx ) ;
99 109
 		return $this->regexps[$rx]->match() ;
100 110
 	}
101 111
 
112
+	/**
113
+	 * @param string $value
114
+	 */
102 115
 	function expression( $result, $stack, $value ) {
103 116
 		$stack[] = $result; $rv = false;
104 117
 		
@@ -120,14 +133,26 @@  discard block
 block discarded – undo
120 133
 		return is_array($rv) ? $rv['text'] : ($rv ? $rv : '');
121 134
 	}
122 135
 	
136
+	/**
137
+	 * @param string $key
138
+	 * @param integer $pos
139
+	 */
123 140
 	function packhas( $key, $pos ) {
124 141
 		return false ;
125 142
 	}
126 143
 
144
+	/**
145
+	 * @param string $key
146
+	 * @param integer $pos
147
+	 */
127 148
 	function packread( $key, $pos ) {
128 149
 		throw new \Exception('PackRead after PackHas=>false in Parser.php');
129 150
 	}
130 151
 
152
+	/**
153
+	 * @param string $key
154
+	 * @param integer $pos
155
+	 */
131 156
 	function packwrite( $key, $pos, $res ) {
132 157
 		return $res ;
133 158
 	}
@@ -164,6 +189,9 @@  discard block
 block discarded – undo
164 189
 		return $result ;
165 190
 	}
166 191
 
192
+	/**
193
+	 * @param string $storetag
194
+	 */
167 195
 	function store ( &$result, $subres, $storetag = NULL ) {
168 196
 		$result['text'] .= $subres['text'] ;
169 197
 
Please login to merge, or discard this patch.
src/Forms/FieldList.php 1 patch
Doc Comments   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -89,6 +89,9 @@  discard block
 block discarded – undo
89 89
         $this->sequentialSaveableSet = null;
90 90
     }
91 91
 
92
+    /**
93
+     * @param FormField[] $list
94
+     */
92 95
     protected function collateDataFields(&$list, $saveableOnly = false)
93 96
     {
94 97
         if (!isset($list)) {
@@ -198,7 +201,7 @@  discard block
 block discarded – undo
198 201
      * Removes a number of fields from a Tab/TabSet within this FieldList.
199 202
      *
200 203
      * @param string $tabName The name of the Tab or TabSet field
201
-     * @param array $fields A list of fields, e.g. array('Name', 'Email')
204
+     * @param string[] $fields A list of fields, e.g. array('Name', 'Email')
202 205
      */
203 206
     public function removeFieldsFromTab($tabName, $fields)
204 207
     {
@@ -625,7 +628,7 @@  discard block
 block discarded – undo
625 628
     }
626 629
 
627 630
     /**
628
-     * @param $field
631
+     * @param CompositeField $field
629 632
      * @return $this
630 633
      */
631 634
     public function setContainerField($field)
@@ -707,6 +710,7 @@  discard block
 block discarded – undo
707 710
      * the children collection. Doesn't work recursively.
708 711
      *
709 712
      * @param string|FormField
713
+     * @param string $field
710 714
      * @return int Position in children collection (first position starts with 0).
711 715
      * Returns FALSE if the field can't be found.
712 716
      */
Please login to merge, or discard this patch.
src/Forms/GridField/GridFieldPrintButton.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@
 block discarded – undo
77 77
      *
78 78
      * @param GridField
79 79
      *
80
-     * @return array
80
+     * @return string[]
81 81
      */
82 82
     public function getActions($gridField)
83 83
     {
Please login to merge, or discard this patch.
src/Forms/FormField.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1222,7 +1222,7 @@  discard block
 block discarded – undo
1222 1222
     /**
1223 1223
      * @param FormTransformation $transformation
1224 1224
      *
1225
-     * @return mixed
1225
+     * @return FormField
1226 1226
      */
1227 1227
     public function transform(FormTransformation $transformation)
1228 1228
     {
@@ -1333,7 +1333,7 @@  discard block
 block discarded – undo
1333 1333
      * This function is used by the template processor. If you refer to a field as a $ variable, it
1334 1334
      * will return the $Field value.
1335 1335
      *
1336
-     * @return string
1336
+     * @return DBHTMLText
1337 1337
      */
1338 1338
     public function forTemplate()
1339 1339
     {
Please login to merge, or discard this patch.
src/Forms/HTMLEditor/HTMLEditorField.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
     /**
80 80
      * Assign a new configuration instance or identifier
81 81
      *
82
-     * @param string|HTMLEditorConfig $config
82
+     * @param string $config
83 83
      * @return $this
84 84
      */
85 85
     public function setEditorConfig($config)
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
      *
95 95
      * @param string $name The internal field name, passed to forms.
96 96
      * @param string $title The human-readable field label.
97
-     * @param mixed $value The value of the field.
97
+     * @param integer $value The value of the field.
98 98
      * @param string $config HTMLEditorConfig identifier to be used. Default to the active one.
99 99
      */
100 100
     public function __construct($name, $title = null, $value = '', $config = null)
@@ -142,6 +142,9 @@  discard block
 block discarded – undo
142 142
         $record->{$this->name} = $htmlValue->getContent();
143 143
     }
144 144
 
145
+    /**
146
+     * @param string|null $value
147
+     */
145 148
     public function setValue($value, $data = null)
146 149
     {
147 150
         // Regenerate links prior to preview, so that the editor can see them.
Please login to merge, or discard this patch.
src/Forms/MoneyField.php 1 patch
Doc Comments   +9 added lines, -2 removed lines patch added patch discarded remove patch
@@ -57,6 +57,10 @@  discard block
 block discarded – undo
57 57
         return $this->fieldAmount;
58 58
     }
59 59
 
60
+    /**
61
+     * @param string $name
62
+     * @param string $title
63
+     */
60 64
     public function __construct($name, $title = null, $value = "")
61 65
     {
62 66
         $this->setName($name);
@@ -210,7 +214,7 @@  discard block
 block discarded – undo
210 214
      *
211 215
      * (see @link MoneyFieldTest_CustomSetter_Object for more information)
212 216
      *
213
-     * @param DataObjectInterface|Object $dataObject
217
+     * @param DataObjectInterface $dataObject
214 218
      */
215 219
     public function saveInto(DataObjectInterface $dataObject)
216 220
     {
@@ -238,6 +242,9 @@  discard block
 block discarded – undo
238 242
         return $clone;
239 243
     }
240 244
 
245
+    /**
246
+     * @param boolean $bool
247
+     */
241 248
     public function setReadonly($bool)
242 249
     {
243 250
         parent::setReadonly($bool);
@@ -261,7 +268,7 @@  discard block
 block discarded – undo
261 268
     /**
262 269
      * Set list of currencies. Currencies should be in the 3-letter ISO 4217 currency code.
263 270
      *
264
-     * @param array $currencies
271
+     * @param string[] $currencies
265 272
      * @return $this
266 273
      */
267 274
     public function setAllowedCurrencies($currencies)
Please login to merge, or discard this patch.
src/Forms/NumericField.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -279,7 +279,7 @@
 block discarded – undo
279 279
      * Get number of digits to show to the right of the decimal point.
280 280
      * 0 for integer, any number for floating point, or null to flexible
281 281
      *
282
-     * @return int|null
282
+     * @return string
283 283
      */
284 284
     public function getScale()
285 285
     {
Please login to merge, or discard this patch.
src/Forms/SelectionGroup_Item.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -37,6 +37,9 @@  discard block
 block discarded – undo
37 37
         return $this->title;
38 38
     }
39 39
 
40
+    /**
41
+     * @param string $title
42
+     */
40 43
     function setTitle($title)
41 44
     {
42 45
         $this->title = $title;
@@ -48,6 +51,9 @@  discard block
 block discarded – undo
48 51
         return $this->value;
49 52
     }
50 53
 
54
+    /**
55
+     * @param string $Value
56
+     */
51 57
     function setValue($Value, $data = null)
52 58
     {
53 59
         $this->value = $Value;
Please login to merge, or discard this patch.