silverstripe / silverstripe-framework

src/View/SSViewer_FromString.php

Doc Comments +3 added lines

@@ -30,6 +30,9 @@
      */
     protected $cacheTemplate;
 
+    /**
+     * @param string $content
+     */
     public function __construct($content, TemplateParser $parser = null)
     {
         if ($parser) {

src/Forms/FileField.php

Doc Comments +1 added lines, -1 removed lines

@@ -238,7 +238,7 @@
 
     /**
      * @param array $properties
-     * @return string
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText
      */
     public function Field($properties = array())
     {

src/Forms/UploadReceiver.php

Doc Comments -1 removed lines

@@ -97,7 +97,6 @@
      * for each of these categories
      *
      * @param string $category Category name
-     * @param string,... $categories Additional category names
      * @return $this
      */
     public function setAllowedFileCategories($category)

tests/php/Core/ObjectTest/Extending.php

Doc Comments +17 added lines

@@ -12,11 +12,22 @@ 
         Extending_Extension::class,
     );
 
+    /**
+     * @param integer $first
+     * @param integer $second
+     * @param integer $third
+     */
     public function getResults(&$first, &$second, &$third)
     {
         // Before extending should be invoked second
         $this->beforeExtending(
             'updateResult',
+
+            /**
+             * @param integer $first
+             * @param integer $second
+             * @param integer $third
+             */
             function (&$first, &$second, &$third) {
                 if ($first === 1 && $second === 2 && $third === 3) {
                     $first = 11;
@@ -31,6 +42,12 @@ 
         // After extending should be invoked fourth
         $this->afterExtending(
             'updateResult',
+
+            /**
+             * @param integer $first
+             * @param integer $second
+             * @param integer $third
+             */
             function (&$first, &$second, &$third) {
                 if ($first === 21 && $second === 22 && $third = 23) {
                     $first = 31;

tests/php/Core/Startup/ErrorControlChainTest/ErrorControlChainTest_Chain.php

Doc Comments +5 added lines, -1 removed lines

@@ -31,7 +31,7 @@ 
     /**
      * Modify method visibility to public for testing
      *
-     * @param mixed $errors
+     * @param string $errors
      */
     public function setDisplayErrors($errors)
     {
@@ -40,6 +40,10 @@ 
     }
 
     // Change function visibility to be testable directly
+
+    /**
+     * @param string $memstring
+     */
     public function translateMemstring($memstring)
     {
         return parent::translateMemstring($memstring);

tests/php/Dev/CsvBulkLoaderTest.php

Doc Comments +3 added lines

@@ -271,6 +271,9 @@
     }
 
 
+    /**
+     * @param resource $file
+     */
     protected function getLineCount(&$file)
     {
         $i = 0;

tests/php/Security/GroupTest/MemberForm.php

Doc Comments +4 added lines

@@ -9,6 +9,10 @@
 class MemberForm extends Form
 {
 
+    /**
+     * @param \SilverStripe\Control\Controller $controller
+     * @param string $name
+     */
     public function __construct($controller, $name)
     {
         $fields = TestMember::singleton()->getCMSFields();

tests/php/View/SSViewerCacheBlockTest/VersionedModel.php

Doc Comments +3 added lines

@@ -16,6 +16,9 @@
         Versioned::class
     );
 
+    /**
+     * @param string $entropy
+     */
     public function setEntropy($entropy)
     {
         $this->entropy = $entropy;

src/Forms/GridField/GridFieldAddExistingAutocompleter.php

Doc Comments +3 added lines, -3 removed lines

@@ -155,7 +155,7 @@ 
     /**
      *
      * @param GridField $gridField
-     * @return array
+     * @return string[]
      */
     public function getActions($gridField)
     {
@@ -219,7 +219,7 @@ 
      *
      * @param GridField $gridField
      * @param HTTPRequest $request
-     * @return string
+     * @return HTTPResponse
      */
     public function doSearch($gridField, $request)
     {
@@ -299,7 +299,7 @@ 
     }
 
     /**
-     * @param array $fields
+     * @param string[] $fields
      * @return $this
      */
     public function setSearchFields($fields)