Completed
Pull Request — master (#7083)
by Sam
07:25
created
thirdparty/simpletest/page.php 1 patch
Doc Comments   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
     /**
146 146
      *    Reads the raw content and send events
147 147
      *    into the page to be built.
148
-     *    @param $response SimpleHttpResponse  Fetched response.
148
+     *    @param SilverStripe\Dev\TestSession_STResponseWrapper $response SimpleHttpResponse  Fetched response.
149 149
      *    @return SimplePage                   Newly parsed page.
150 150
      *    @access public
151 151
      */
@@ -170,8 +170,8 @@  discard block
 block discarded – undo
170 170
 
171 171
     /**
172 172
      *    Creates the parser used with the builder.
173
-     *    @param $listener SimpleSaxListener   Target of parser.
174
-     *    @return SimpleSaxParser              Parser to generate
173
+     *    @param SimplePageBuilder $listener SimpleSaxListener   Target of parser.
174
+     *    @return SimpleHtmlSaxParser              Parser to generate
175 175
      *                                         events for the builder.
176 176
      *    @access protected
177 177
      */
@@ -406,7 +406,7 @@  discard block
 block discarded – undo
406 406
 
407 407
     /**
408 408
      *    Original request as bytes sent down the wire.
409
-     *    @return mixed              Sent content.
409
+     *    @return string|false              Sent content.
410 410
      *    @access public
411 411
      */
412 412
     function getRequest() {
@@ -415,7 +415,7 @@  discard block
 block discarded – undo
415 415
 
416 416
     /**
417 417
      *    Accessor for raw text of page.
418
-     *    @return string        Raw unparsed content.
418
+     *    @return boolean        Raw unparsed content.
419 419
      *    @access public
420 420
      */
421 421
     function getRaw() {
@@ -467,7 +467,7 @@  discard block
 block discarded – undo
467 467
 
468 468
     /**
469 469
      *    Base URL if set via BASE tag page url otherwise
470
-     *    @return SimpleUrl        Base url.
470
+     *    @return boolean        Base url.
471 471
      *    @access public
472 472
      */
473 473
     function getBaseUrl() {
@@ -658,7 +658,7 @@  discard block
 block discarded – undo
658 658
     /**
659 659
      *    Opens a frameset. A frameset may contain nested
660 660
      *    frameset tags.
661
-     *    @param SimpleFramesetTag $tag      Tag to accept.
661
+     *    @param SimpleTag $tag      Tag to accept.
662 662
      *    @access public
663 663
      */
664 664
     function acceptFramesetStart(&$tag) {
Please login to merge, or discard this patch.
src/Control/Controller.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -147,6 +147,7 @@  discard block
 block discarded – undo
147 147
      * {@inheritdoc}
148 148
      *
149 149
      * Also set the URLParams
150
+     * @param HTTPRequest $request
150 151
      */
151 152
     public function setRequest($request)
152 153
     {
@@ -523,7 +524,7 @@  discard block
 block discarded – undo
523 524
      *
524 525
      * @param array $params
525 526
      *
526
-     * @return string
527
+     * @return DBHTMLText
527 528
      */
528 529
     public function render($params = null)
529 530
     {
@@ -702,7 +703,7 @@  discard block
 block discarded – undo
702 703
      * Tests whether a redirection has been requested. If redirect() has been called, it will return
703 704
      * the URL redirected to. Otherwise, it will return null.
704 705
      *
705
-     * @return null|string
706
+     * @return boolean
706 707
      */
707 708
     public function redirectedTo()
708 709
     {
@@ -736,7 +737,6 @@  discard block
 block discarded – undo
736 737
      *
737 738
      * Caution: All parameters are expected to be URI-encoded already.
738 739
      *
739
-     * @param string|array $arg,.. One or more link segments, or list of link segments as an array
740 740
      * @return string
741 741
      */
742 742
     public static function join_links($arg = null)
Please login to merge, or discard this patch.
src/Control/CookieJar.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -151,7 +151,7 @@
 block discarded – undo
151 151
      * @see http://uk3.php.net/manual/en/function.setcookie.php
152 152
      *
153 153
      * @param string $name The name of the cookie
154
-     * @param string|array $value The value for the cookie to hold
154
+     * @param false|string $value The value for the cookie to hold
155 155
      * @param int $expiry The number of days until expiry
156 156
      * @param string $path The path to save the cookie on (falls back to site base)
157 157
      * @param string $domain The domain to make the cookie available on
Please login to merge, or discard this patch.
src/Control/HTTPRequest.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -458,9 +458,9 @@
 block discarded – undo
458 458
      * it's only advisable to send small files through this method.
459 459
      *
460 460
      * @static
461
-     * @param $fileData
461
+     * @param string $fileData
462 462
      * @param $fileName
463
-     * @param null $mimeType
463
+     * @param string $mimeType
464 464
      * @return HTTPResponse
465 465
      */
466 466
     public static function send_file($fileData, $fileName, $mimeType = null)
Please login to merge, or discard this patch.
src/Control/RequestHandler.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -296,7 +296,7 @@
 block discarded – undo
296 296
      *
297 297
      * Must not raise HTTPResponse_Exceptions - instead it should return
298 298
      *
299
-     * @param $request
299
+     * @param HTTPRequest $request
300 300
      * @param $action
301 301
      * @return HTTPResponse
302 302
      */
Please login to merge, or discard this patch.
src/Control/RSS/RSSFeed.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -248,6 +248,7 @@
 block discarded – undo
248 248
      * via the standard template inclusion process.
249 249
      *
250 250
      * @param string
251
+     * @param string|null $template
251 252
      */
252 253
     public function setTemplate($template)
253 254
     {
Please login to merge, or discard this patch.
src/Core/Startup/ErrorControlChain.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
     /**
107 107
      * Get value of display_errors ini value
108 108
      *
109
-     * @return mixed
109
+     * @return string
110 110
      */
111 111
     protected function getDisplayErrors()
112 112
     {
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
      * Add this callback to the chain of callbacks to call along with the state
118 118
      * that $error must be in this point in the chain for the callback to be called
119 119
      *
120
-     * @param $callback - The callback to call
120
+     * @param callable $callback - The callback to call
121 121
      * @param $onErrorState - false if only call if no errors yet, true if only call if already errors, null for either
122 122
      * @return $this
123 123
      */
Please login to merge, or discard this patch.
src/Dev/Backtrace.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -132,7 +132,7 @@
 block discarded – undo
132 132
      * @param mixed $returnVal
133 133
      * @param bool $ignoreAjax
134 134
      * @param array $ignoredFunctions
135
-     * @return mixed
135
+     * @return string|null
136 136
      */
137 137
     public static function backtrace($returnVal = false, $ignoreAjax = false, $ignoredFunctions = null)
138 138
     {
Please login to merge, or discard this patch.
src/Dev/BulkLoader_Result.php 1 patch
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -132,8 +132,8 @@  discard block
 block discarded – undo
132 132
     }
133 133
 
134 134
     /**
135
-     * @param $obj DataObject
136
-     * @param $message string
135
+     * @param DataObject $obj DataObject
136
+     * @param string $message string
137 137
      */
138 138
     public function addCreated($obj, $message = null)
139 139
     {
@@ -146,8 +146,8 @@  discard block
 block discarded – undo
146 146
     }
147 147
 
148 148
     /**
149
-     * @param $obj DataObject
150
-     * @param $message string
149
+     * @param DataObject $obj DataObject
150
+     * @param string $message string
151 151
      */
152 152
     public function addUpdated($obj, $message = null)
153 153
     {
@@ -160,8 +160,8 @@  discard block
 block discarded – undo
160 160
     }
161 161
 
162 162
     /**
163
-     * @param $obj DataObject
164
-     * @param $message string
163
+     * @param DataObject|null $obj DataObject
164
+     * @param string $message string
165 165
      */
166 166
     public function addDeleted($obj, $message = null)
167 167
     {
Please login to merge, or discard this patch.