silverstripe / silverstripe-framework

src/Forms/TimeField.php

Doc Comments +2 added lines, -2 removed lines

@@ -247,7 +247,7 @@ 
     /**
      * Assign value posted from form submission
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */
@@ -264,7 +264,7 @@ 
     /**
      * Set time assigned from database value
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */

src/Forms/DateField.php

Doc Comments +2 added lines, -2 removed lines

@@ -311,7 +311,7 @@ 
     /**
      * Assign value posted from form submission
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */
@@ -336,7 +336,7 @@ 
      *
      * When $html5=true, assign value from ISO 8601 string.
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */

tests/behat/src/CmsUiContext.php

Doc Comments +1 added lines

@@ -479,6 +479,7 @@
      *
      * @When /^(?:|I )fill in the "(?P<field>(?:[^"]|\\")*)" dropdown with "(?P<value>(?:[^"]|\\")*)"$/
      * @When /^(?:|I )fill in "(?P<value>(?:[^"]|\\")*)" for the "(?P<field>(?:[^"]|\\")*)" dropdown$/
+     * @param string $field
      */
     public function theIFillInTheDropdownWith($field, $value)
     {

src/Forms/DatetimeField.php

Doc Comments +6 added lines, -3 removed lines

@@ -135,7 +135,7 @@ 
     }
 
     /**
-     * @param $bool
+     * @param boolean $bool
      * @return $this
      */
     public function setHTML5($bool)
@@ -148,7 +148,7 @@ 
      * Assign value posted from form submission, based on {@link $datetimeFormat}.
      * When $html5=true, this needs to be normalised ISO format (with "T" separator).
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */
@@ -314,7 +314,7 @@ 
      * When $html5=true, assign value from ISO 8601 normalised string (with a "T" separator).
      * Falls back to an ISO 8601 string (with a whitespace separator).
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */
@@ -489,6 +489,9 @@ 
         return $this;
     }
 
+    /**
+     * @param boolean $bool
+     */
     public function setReadonly($bool)
     {
         parent::setReadonly($bool);

src/Forms/CompositeField.php

Doc Comments +11 added lines

@@ -270,6 +270,9 @@ 
 
 
 
+    /**
+     * @param boolean $disabled
+     */
     public function setDisabled($disabled)
     {
         parent::setDisabled($disabled);
@@ -279,6 +282,9 @@ 
         return $this;
     }
 
+    /**
+     * @param boolean $readonly
+     */
     public function setReadonly($readonly)
     {
         parent::setReadonly($readonly);
@@ -371,6 +377,10 @@ 
         $this->children->removeByName($fieldName, $dataFieldOnly);
     }
 
+    /**
+     * @param string $fieldName
+     * @param FormField $newField
+     */
     public function replaceField($fieldName, $newField)
     {
         return $this->children->replaceField($fieldName, $newField);
@@ -456,6 +466,7 @@ 
      * the children collection. Doesn't work recursively.
      *
      * @param string|FormField
+     * @param string $field
      * @return int Position in children collection (first position starts with 0). Returns FALSE if the field can't
      *             be found.
      */

tests/php/Forms/GridField/GridFieldAddNewButtonTest.php

Doc Comments +3 added lines

@@ -88,6 +88,9 @@
         $this->mockButtonFragments($list, null);
     }
 
+    /**
+     * @param \SilverStripe\ORM\DataObject $parent
+     */
     protected function mockButtonFragments(SS_List $list, $parent = null)
     {
         $form = Form::create(

src/Security/InheritedPermissions.php

Doc Comments +1 added lines, -1 removed lines

@@ -86,7 +86,7 @@
     /**
      * Global permissions required to edit
      *
-     * @param array $permissions
+     * @param string[] $permissions
      * @return $this
      */
     public function setGlobalEditPermissions($permissions)

tests/php/Core/Manifest/ManifestFileFinderTest.php

Doc Comments +5 added lines

@@ -19,6 +19,11 @@
         parent::__construct();
     }
 
+    /**
+     * @param ManifestFileFinder $finder
+     * @param null|string $base
+     * @param string[] $expect
+     */
     public function assertFinderFinds($finder, $base, $expect, $message = null)
     {
         if (!$base) {

tests/php/Security/InheritedPermissionsTest/TestPermissionNode.php

Doc Comments +3 added lines

@@ -42,6 +42,9 @@
         return Injector::inst()->get(PermissionChecker::class.'.testpermissions');
     }
 
+    /**
+     * @param DataObject $member
+     */
     public function canEdit($member = null)
     {
         if (!$member) {