silverstripe / silverstripe-framework

tests/php/View/SSViewerTest.php

Doc Comments +13 added lines

@@ -159,6 +159,10 @@ 
         ]);
     }
 
+    /**
+     * @param \SilverStripe\ORM\FieldType\DBHTMLText $result
+     * @param string[] $expected
+     */
     private function assertExpectedStrings($result, $expected)
     {
         foreach ($expected as $expectedStr) {
@@ -1089,6 +1093,10 @@ 
         $this->assertEquals('A A1 A1 i A1 ii A2 A3', $rationalisedResult);
     }
 
+    /**
+     * @param string $a
+     * @param string $b
+     */
     public function assertEqualIgnoringWhitespace($a, $b, $message = '')
     {
         $this->assertEquals(preg_replace('/\s+/', '', $a), preg_replace('/\s+/', '', $b), $message);
@@ -1817,6 +1825,11 @@ 
             $this->_renderWithSourceFileComments('SSViewerTestComments/'.$template['name'], $template['expected']);
         }
     }
+
+    /**
+     * @param string $name
+     * @param string $expected
+     */
     private function _renderWithSourceFileComments($name, $expected)
     {
         $viewer = new SSViewer(array($name));

src/Core/ClassInfo.php

Doc Comments +3 added lines

@@ -310,6 +310,9 @@
 
     private static $method_from_cache = array();
 
+    /**
+     * @param string $method
+     */
     public static function has_method_from($class, $method, $compclass)
     {
         $lClass = strtolower($class);

src/ORM/DataQuery.php

Doc Comments +1 added lines, -1 removed lines

@@ -190,7 +190,7 @@
     /**
      * Ensure that the query is ready to execute.
      *
-     * @param array|null $queriedColumns Any columns to filter the query by
+     * @param string[] $queriedColumns Any columns to filter the query by
      * @return SQLSelect The finalised sql query
      */
     public function getFinalisedQuery($queriedColumns = null)

src/ORM/Connect/DBSchemaManager.php

Doc Comments +2 added lines, -2 removed lines

@@ -331,7 +331,7 @@ 
      *   - array('fields' => array('A','B','C'), 'type' => 'index/unique/fulltext'): This gives you full
      *     control over the index.
      * @param boolean $hasAutoIncPK A flag indicating that the primary key on this table is an autoincrement type
-     * @param array $options Create table options (ENGINE, etc.)
+     * @param string|null $options Create table options (ENGINE, etc.)
      * @param array|bool $extensions List of extensions
      */
     public function requireTable(
@@ -595,7 +595,7 @@ 
      *
      * @param string $table The table name.
      * @param string $field The field name.
-     * @param array|string $spec The field specification. If passed in array syntax, the specific database
+     * @param string $spec The field specification. If passed in array syntax, the specific database
      *  driver takes care of the ALTER TABLE syntax. If passed as a string, its assumed to
      *  be prepared as a direct SQL framgment ready for insertion into ALTER TABLE. In this case you'll
      *  need to take care of database abstraction in your DBField subclass.

src/Security/CMSSecurity.php

Doc Comments +6 added lines

@@ -49,6 +49,9 @@ 
         return parent::login($request, Authenticator::CMS_LOGIN);
     }
 
+    /**
+     * @param string $action
+     */
     public function Link($action = null)
     {
         /** @skipUpgrade */
@@ -79,6 +82,9 @@ 
         return null;
     }
 
+    /**
+     * @param string $title
+     */
     public function getResponseController($title)
     {
         // Use $this to prevent use of Page to render underlying templates

src/Core/Injector/Injector.php

Doc Comments +3 added lines, -3 removed lines

@@ -371,7 +371,7 @@ 
      *
      * @param string $property
      *                the name of the property
-     * @param object $object
+     * @param string $object
      *                the object to be set
      * @return $this
      */
@@ -466,7 +466,7 @@ 
      *              The name of the service to update the definition for
      * @param string $property
      *              The name of the property to update.
-     * @param mixed $value
+     * @param string $value
      *              The value to set
      * @param boolean $append
      *              Whether to append (the default) when the property is an array
@@ -788,7 +788,7 @@ 
     /**
      * @deprecated 4.0.0:5.0.0 Use Injector::has() instead
      * @param $name
-     * @return string
+     * @return boolean
      */
     public function hasService($name)
     {

src/ORM/DataObjectSchema.php

Doc Comments +1 added lines, -1 removed lines

@@ -488,7 +488,7 @@
      * Cache all indexes for the given class.
      * Will do nothing if already cached
      *
-     * @param $class
+     * @param string $class
      */
     protected function cacheDatabaseIndexes($class)
     {

src/Security/BasicAuth.php

Doc Comments +1 added lines, -1 removed lines

@@ -59,7 +59,7 @@
      * @param string|array $permissionCode Optional
      * @param boolean $tryUsingSessionLogin If true, then the method with authenticate against the
      *  session log-in if those credentials are disabled.
-     * @return bool|Member
+     * @return null|Member
      * @throws HTTPResponse_Exception
      */
     public static function requireLogin(

src/Security/MemberAuthenticator/ChangePasswordHandler.php

Doc Comments +1 added lines, -1 removed lines

@@ -169,7 +169,7 @@
     /**
      * Return a link to this request handler.
      * The link returned is supplied in the constructor
-     * @param null $action
+     * @param string $action
      * @return string
      */
     public function link($action = null)