DataObjectDuplicationTest::testDuplicateManyManyClasses() - Code Metrics - Inspection of "Merge pull request #8843 from dhensby/pulls/4.0/do..." - silverstripe/silverstripe-framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — 4.0 ( b59aea...80f83b )

by Loz
created 2019-03-06 09:53 UTC
testDuplicateManyManyClasses() B

↳ Parent: DataObjectDuplicationTest
Complexity

Conditions	1
Paths	1
Size

Total Lines	90
Code Lines	60
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	1
eloc	60
nc	1
nop	0
dl	0
loc	90
rs	8.8727
c	0
b	0
f	0
How to fix Long Method

<?php

namespace SilverStripe\ORM\Tests;

use SilverStripe\ORM\DataObject;
use SilverStripe\Dev\SapphireTest;
use SilverStripe\ORM\FieldType\DBDatetime;

class DataObjectDuplicationTest extends SapphireTest
{

    protected $usesDatabase = true;

    protected static $extra_dataobjects = array(
        DataObjectDuplicationTest\Class1::class,
        DataObjectDuplicationTest\Class2::class,
        DataObjectDuplicationTest\Class3::class,
        DataObjectDuplicationTest\Class4::class,
    );

    public function testDuplicate()
    {
        DBDatetime::set_mock_now('2016-01-01 01:01:01');
        $orig = new DataObjectDuplicationTest\Class1();
        $orig->text = 'foo';

        $orig->write();
        DBDatetime::set_mock_now('2016-01-02 01:01:01');
        $duplicate = $orig->duplicate();
        $this->assertInstanceOf(
            DataObjectDuplicationTest\Class1::class,
            $duplicate,
            'Creates the correct type'
        );
        $this->assertNotEquals(
            $duplicate->ID,
            $orig->ID,
            'Creates a unique record'
        );
        $this->assertEquals(
            'foo',
            $duplicate->text,

            'Copies fields'
        );
        $this->assertEquals(
            2,
            DataObjectDuplicationTest\Class1::get()->Count(),
            'Only creates a single duplicate'
        );
        $this->assertEquals(DBDatetime::now()->Nice(), $duplicate->dbObject('Created')->Nice());
        $this->assertEquals(DBDatetime::now()->Nice(), $duplicate->dbObject('Created')->/** @scrutinizer ignore-call */ Nice());
        $this->assertNotEquals($orig->dbObject('Created')->Nice(), $duplicate->dbObject('Created')->Nice());
    }

    public function testDuplicateHasOne()
    {
        $relationObj = new DataObjectDuplicationTest\Class1();
        $relationObj->text = 'class1';

        $relationObj->write();

        $orig = new DataObjectDuplicationTest\Class2();
        $orig->text = 'class2';

        $orig->oneID = $relationObj->ID;

        $orig->write();

        $duplicate = $orig->duplicate();
        $this->assertEquals(
            $relationObj->ID,
            $duplicate->oneID,

            'Copies has_one relationship'
        );
        $this->assertEquals(
            2,
            DataObjectDuplicationTest\Class2::get()->Count(),
            'Only creates a single duplicate'
        );
        $this->assertEquals(
            1,
            DataObjectDuplicationTest\Class1::get()->Count(),
            'Does not create duplicate of has_one relationship'
        );
    }


    public function testDuplicateManyManyClasses()
    {
        //create new test classes below
        $one = new DataObjectDuplicationTest\Class1();
        $two = new DataObjectDuplicationTest\Class2();
        $three = new DataObjectDuplicationTest\Class3();

        //set some simple fields
        $text1 = "Test Text 1";
        $text2 = "Test Text 2";
        $text3 = "Test Text 3";
        $one->text = $text1;

        $two->text = $text2;

        $three->text = $text3;


        //write the to DB
        $one->write();
        $two->write();
        $three->write();

        //create relations
        $one->twos()->add($two);
              twos()->add($two);
        $one->threes()->add($three, array('TestExtra'=>'three'));
              threes()->add($three, array('TestExtra'=>'three'));

        $one = DataObject::get_by_id(DataObjectDuplicationTest\Class1::class, $one->ID);
        $two = DataObject::get_by_id(DataObjectDuplicationTest\Class2::class, $two->ID);
        $three = DataObject::get_by_id(DataObjectDuplicationTest\Class3::class, $three->ID);

        $this->assertCount(1, $one->twos());
        $this->assertCount(1, $one->/** @scrutinizer ignore-call */ twos());
        $this->assertCount(1, $one->threes());
        $this->assertCount(1, $one->/** @scrutinizer ignore-call */ threes());
        $this->assertCount(1, $three->ones());
        $this->assertCount(1, $three->/** @scrutinizer ignore-call */ ones());

        //test duplication
        $oneCopy = $one->duplicate(true, true);
        $twoCopy = $two->duplicate(true, true);
        $threeCopy = $three->duplicate(true, true);

        $oneCopy = DataObject::get_by_id(DataObjectDuplicationTest\Class1::class, $oneCopy->ID);
        $twoCopy = DataObject::get_by_id(DataObjectDuplicationTest\Class2::class, $twoCopy->ID);
        $threeCopy = DataObject::get_by_id(DataObjectDuplicationTest\Class3::class, $threeCopy->ID);

        $this->assertNotNull($oneCopy, "Copy of 1 exists");
        $this->assertNotNull($twoCopy, "Copy of 2 exists");
        $this->assertNotNull($threeCopy, "Copy of 3 exists");

        $this->assertEquals($text1, $oneCopy->text);

        $this->assertEquals($text2, $twoCopy->text);
        $this->assertEquals($text3, $threeCopy->text);

        $this->assertCount(
            0,
            $oneCopy->twos(),
            "Many-to-one relation not copied (has_many)"
        );
        $this->assertCount(
            2,
            $oneCopy->threes(),
            "Object has the correct number of relations"
        );
        $this->assertCount(
            2,
            $threeCopy->ones(),
            "Object has the correct number of relations"
        );

        $this->assertEquals(
            $one->ID,
            $twoCopy->one()->ID,
                      one()->ID,
            "Match between relation of copy and the original"
        );
        $this->assertCount(
            0,
            $oneCopy->twos(),
            "Many-to-one relation not copied (has_many)"
        );
        $this->assertContains(
            $three->ID,
            $oneCopy->threes()->column('ID'),
            $oneCopy->threes()->/** @scrutinizer ignore-call */ column('ID'),
            "Match between relation of copy and the original"
        );
        $this->assertContains(
            $one->ID,
            $threeCopy->ones()->column('ID'),
            "Match between relation of copy and the original"
        );

        $this->assertEquals(
            'three',
            $oneCopy->threes()->byID($three->ID)->TestExtra,
            $oneCopy->threes()->/** @scrutinizer ignore-call */ byID($three->ID)->TestExtra,
            "Match between extra field of copy and the original"
        );
    }

    public function testDuplicateManyManyFiltered()
    {
        $parent = new DataObjectDuplicationTest\Class4();
        $parent->Title = 'Parent';

        $parent->write();

        $child = new DataObjectDuplicationTest\Class4();
        $child->Title = 'Child';
        $child->write();

        $grandChild = new DataObjectDuplicationTest\Class4();
        $grandChild->Title = 'GrandChild';
        $grandChild->write();

        $parent->Children()->add($child);
        $child->Children()->add($grandChild);

        // Duplcating $child should only duplicate grandchild
        $childDuplicate = $child->duplicate(true, 'many_many');
        $this->assertEquals(0, $childDuplicate->Parents()->count());
        $this->assertListEquals(
            [['Title' => 'GrandChild']],
            $childDuplicate->Children()
        );

        // Duplicate belongs_many_many only
        $belongsDuplicate = $child->duplicate(true, 'belongs_many_many');
        $this->assertEquals(0, $belongsDuplicate->Children()->count());
        $this->assertListEquals(
            [['Title' => 'Parent']],
            $belongsDuplicate->Parents()
        );

        // Duplicate all
        $allDuplicate = $child->duplicate(true, true);
        $this->assertListEquals(
            [['Title' => 'Parent']],
            $allDuplicate->Parents()
        );
        $this->assertListEquals(
            [['Title' => 'GrandChild']],
            $allDuplicate->Children()
        );
    }

    /**
     * Test duplication of UnsavedRelations
     */
    public function testDuplicateUnsaved()
    {
        $one = new DataObjectDuplicationTest\Class1();
        $one->text = "Test Text 1";

        $three = new DataObjectDuplicationTest\Class3();
        $three->text = "Test Text 3";

        $one->threes()->add($three);
        $this->assertListEquals(
            [['text' => 'Test Text 3']],
            $one->threes()
        );
        // Test duplicate
        $dupe = $one->duplicate(false, true);
        $this->assertEquals('Test Text 1', $dupe->text);

        $this->assertListEquals(
            [['text' => 'Test Text 3']],
            $dupe->threes()
        );
    }
}

silverstripe / silverstripe-framework

Push — 4.0 ( b59aea...80f83b )

testDuplicateManyManyClasses() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
